From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CAC732115BE3D for ; Sat, 29 Sep 2018 15:36:06 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 56B1188303; Sat, 29 Sep 2018 22:36:06 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-26.ams2.redhat.com [10.36.116.26]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5D3B37A3FA; Sat, 29 Sep 2018 22:36:01 +0000 (UTC) From: Laszlo Ersek To: edk2-devel-01 References: <20180929222312.32150-1-lersek@redhat.com> Cc: Michael D Kinney , Liming Gao Message-ID: <6b7c93fe-377a-4958-15b2-da582b338d04@redhat.com> Date: Sun, 30 Sep 2018 00:35:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180929222312.32150-1-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Sat, 29 Sep 2018 22:36:06 +0000 (UTC) Subject: Re: [PATCH 0/5] MdePkg/BaseSynchronizationLib GCC: fixes, cleanups X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Sep 2018 22:36:07 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 09/30/18 00:23, Laszlo Ersek wrote: > Repo: https://github.com/lersek/edk2.git > Branch: inline_asm_rw_ops_1208 > > This series mainly fixes the operand constraints (missing input-output > qualifications) in "BaseSynchronizationLib/*/GccInline.c". > > (It would be better to remove these files altogether in favor of the > already existing NASM implementation, but due to > , we can't generally > do that in libraries yet.) > > Cc: Liming Gao > Cc: Michael D Kinney > > Thanks, > Laszlo > > Laszlo Ersek (5): > MdePkg/BaseSynchronizationLib GCC: fix whitespace and comments > MdePkg/BaseSynchronizationLib GCC: fix InternalSyncCompareExchange16() > MdePkg/BaseSynchronizationLib GCC: fix InternalSyncCompareExchange32() > MdePkg/BaseSynchronizationLib GCC: fix X64 > InternalSyncCompareExchange64() > MdePkg/BaseSynchronizationLib GCC: simplify IA32 > InternalSyncCompareExchange64() > > MdePkg/Library/BaseSynchronizationLib/Ia32/GccInline.c | 42 +++++++---------- > MdePkg/Library/BaseSynchronizationLib/X64/GccInline.c | 47 +++++++------------- > 2 files changed, 34 insertions(+), 55 deletions(-) > Forgot to mention the testing. Ran my usual OVMF tests described at on multi-VCPU guests. I tested the series against all my longterm guests (including 32-bit and 64-bit Fedora, and 64-bit Windows 7 / Server 2008 r2, 8.1 / Server 2012 r2, 10 / Server 2016). Also covered an SMM-less build on i440fx, with 64-bit Fedora. Thanks Laszlo