From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web10.2945.1587377889483755348 for ; Mon, 20 Apr 2020 03:18:09 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=GmwiSf68; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587377888; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Easm6CeH/cainRrty9PQvpMe1+8EXGwNieI+SS+nzgU=; b=GmwiSf686zsyqhSTaqGdvIRLHxq4F2A6BMstLAg4DaAY7ZMP/lw1dMyMcr0XBL57RVHWM/ PGSzEp200mRpxk0gaUi1/iQTRPAMHs6KA3wxurKemXQrCLBbOfc4WZobeSuZ9ZG87CH5tj Ulrc5luNzWOtMlgc67X97IIyt2pWXcA= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-440-3gVjj_fBN7m5HlRVBM78Qw-1; Mon, 20 Apr 2020 06:18:07 -0400 X-MC-Unique: 3gVjj_fBN7m5HlRVBM78Qw-1 Received: by mail-ej1-f71.google.com with SMTP id a23so6056604ejv.14 for ; Mon, 20 Apr 2020 03:18:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=T2UNXSSQNTzaTL0ZYkt6lLhqTuHPAgm1mwieyLYBZa4=; b=CMMeQJSMCmk4D+iVOI7nFqgPAF3ncQ1fcWqYLM5cqXsuhjC3HejkA5s10cm6sfCSv4 8stcg5u7CFzQPQdaufFp3j3VVAaLhZTz9AT8oJ22wdS0a01tL9kQ8WSVN4rxaC9nzhoP l1L2C6gbgdWnAb9DQygURzbpvt96Cm1qegeZSEWgpwFKh0PJPKKQ97w9gPaIhLeYHHbB K9AbMsPBgu+jf0MKVaJtqrV5Y754Fb+1EZs6lwtiJ/KxA05NURn3MKNfCJAXvfbLal3g H4x1XX/86IYQNuiNabAWL1e0U8XVAyRic9dGQSeVpf6AAg5JhuLfuNOfTQjeCB1yB0jq u1fA== X-Gm-Message-State: AGi0PuYkiRj3ic8fG6zs8D+lCQgUxnzDv+0xUFLq0AUsP1H1G9YnrmNz LKyne0R/eKajSTi+r+HnBYUgUvInQTWq7IxZPXnF+ppizxIIQhs8F+eEC696TgJuH7XTjgK+4vj quf2ruvDMqyXgBg== X-Received: by 2002:a17:906:cec5:: with SMTP id si5mr15370136ejb.267.1587377825793; Mon, 20 Apr 2020 03:17:05 -0700 (PDT) X-Google-Smtp-Source: APiQypJZnX4Q4hIEPVx/YR/NOgY3suSj7q0fxE0mwEz0+H6UMnS7wh3dv2cmSF6F0Y+51rOEHwOXgQ== X-Received: by 2002:a17:906:cec5:: with SMTP id si5mr15370106ejb.267.1587377825517; Mon, 20 Apr 2020 03:17:05 -0700 (PDT) Return-Path: Received: from [192.168.1.39] (116.red-83-42-57.dynamicip.rima-tde.net. [83.42.57.116]) by smtp.gmail.com with ESMTPSA id q15sm41988edb.31.2020.04.20.03.17.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Apr 2020 03:17:05 -0700 (PDT) Subject: Re: [PATCH 0/6] OvmfPkg/ResetSystemLib: clean up, refactor, fix To: Laszlo Ersek , Ard Biesheuvel Cc: edk2-devel-groups-io , Anthony Perard , Jordan Justen , Julien Grall , Rebecca Cran References: <20200417153751.7110-1-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <6b833bb4-36a5-67d6-c908-2a2ffdab4f94@redhat.com> Date: Mon, 20 Apr 2020 12:17:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 4/20/20 11:48 AM, Laszlo Ersek wrote: > On 04/17/20 18:19, Philippe Mathieu-Daud=C3=A9 wrote: >> On 4/17/20 5:59 PM, Ard Biesheuvel wrote: >>> On 4/17/20 5:37 PM, Laszlo Ersek wrote: >>>> Ref:=C2=A0=C2=A0=C2=A0 https://bugzilla.tianocore.org/show_bug.cgi?id= =3D2675 >>>> Repo:=C2=A0=C2=A0 https://pagure.io/lersek/edk2.git >>>> Branch: rsl_cleanup >>>> >>>> Rebecca's >>>> >>>> =C2=A0=C2=A0 [PATCH 02/13] OvmfPkg: support powering off bhyve guests >>>> >>>> at >>>> >>>> =C2=A0=C2=A0 https://edk2.groups.io/g/devel/message/57450 >>>> =20 >>>> http://mid.mail-archive.com/e4e9b29189b83076e1d1a0b9c989938f5226cab6.1= 586991816.git.rebecca@bsdio.com >>>> >>>> >>>> made me realize OvmfPkg/ResetSystemLib should be refreshed. This will >>>> let us add a simple bhyve-specific instance (later), and also allows u= s >>>> to fix a long time dormant bug (now). >>>> >>>> Cc: Anthony Perard >>>> Cc: Ard Biesheuvel >>>> Cc: Jordan Justen >>>> Cc: Julien Grall >>>> Cc: Philippe Mathieu-Daud=C3=A9 >>>> Cc: Rebecca Cran >>>> >>>> Thanks, >>>> Laszlo >>>> >>>> Laszlo Ersek (6): >>>> =C2=A0=C2=A0 OvmfPkg/ResetSystemLib: wrap long lines >>>> =C2=A0=C2=A0 OvmfPkg/ResetSystemLib: clean up library dependencies >>>> =C2=A0=C2=A0 OvmfPkg/ResetSystemLib: improve coding style in ResetSys= tem() >>>> =C2=A0=C2=A0 OvmfPkg/ResetSystemLib: factor out ResetShutdown() >>>> =C2=A0=C2=A0 OvmfPkg/ResetSystemLib: rename to BaseResetSystemLib >>>> =C2=A0=C2=A0 OvmfPkg/ResetSystemLib: introduce the DxeResetSystemLib = instance >>>> >>> >>> For the series, >>> >>> Reviewed-by: Ard Biesheuvel >>> >>> One nit: putting a diff block inside the commit log [6/6] doesn't help >>> legibility a lot, and the issue of not being able to access memory >>> that is not mapped for runtime is so basic that it doesn't require >>> that level of detail to describe a reproducer and the Linux kernel log >>> output when the issue is triggered. >> >> Personally I find the kernel log relevant, it will help to understand th >> e patch when looking at it in >5years from now. >=20 > Is it acceptable to both of you (Phil and Ard) if I remove the third > note from the 6/6 commit message, but paste it into a new comment on > ? Certainly. Personal note: I usually try to find answers to my questions on the=20 mailing list archives, usually they are already answered (even often=20 with many details!). I noticed with other (smaller) projects that moved=20 to GitLab that 'googling' similarly is not very practical, eventually=20 after learning something that looks like a mix of SQL and JSON I could=20 find some information in failed merge request comments... Nothing as=20 easy as grepping my local MAILBOX (which, by the way, works offline=20 too). Having that in mind (that mailing list archives are a thing from=20 the previous century and are going to disappear) I prefer to keep all=20 the information in the commit message. There is always a trade off. I'm not sure the Tianocore Bugzilla will make sense once EDK2 move to a=20 git forge, it seems duplicating efforts. My 2 cents. > Thanks! > Laszlo >=20