From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7289121E8798A for ; Tue, 12 Sep 2017 03:12:01 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AAB0113AAE; Tue, 12 Sep 2017 10:14:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com AAB0113AAE Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-50.rdu2.redhat.com [10.10.120.50]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7497265E9E; Tue, 12 Sep 2017 10:14:56 +0000 (UTC) From: Laszlo Ersek To: edk2-devel-01 Cc: Ruiyu Ni , Eric Dong , Star Zeng , Ard Biesheuvel References: <20170910001304.8628-1-lersek@redhat.com> Message-ID: <6bc51f3f-8b97-3a24-1ccf-aeb838eedb6f@redhat.com> Date: Tue, 12 Sep 2017 12:14:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170910001304.8628-1-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 12 Sep 2017 10:14:57 +0000 (UTC) Subject: Re: [PATCH 0/5] MdeModulePkg: UDF fixes and cleanups X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Sep 2017 10:12:01 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 09/10/17 02:12, Laszlo Ersek wrote: > Repo: https://github.com/lersek/edk2.git > Branch: udf_fixes_cleanups > > Patches #2, #3 and #4 are needed (and enough) for me to build OVMF for > IA32 and X64 with clang-3.8, after the UDF introduction. > > Patches #1 and #5 are cleanups that I felt fit before patch #2 and after > patch #4, respectively. > > Cc: Ard Biesheuvel > Cc: Eric Dong > Cc: Paulo Alcantara > Cc: Ruiyu Ni > Cc: Star Zeng > > Thanks > Laszlo > > Laszlo Ersek (5): > MdeModulePkg/UdfDxe: ASSERT() valid ReadFileInfo Flags for INLINE_DATA > req > MdeModulePkg/UdfDxe: don't return unset Status if INLINE_DATA req > succeeds > MdeModulePkg/UdfDxe: replace zero-init of local variables with > ZeroMem() > MdeModulePkg/PartitionDxe: don't divide 64-bit values with C operators > MdeModulePkg/PartitionDxe: remove always false comparison > > MdeModulePkg/Universal/Disk/PartitionDxe/Udf.c | 9 +++++++-- > MdeModulePkg/Universal/Disk/UdfDxe/File.c | 6 ++++-- > MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c | 5 +++++ > 3 files changed, 16 insertions(+), 4 deletions(-) > Thanks all for the feedback, pushed as commit range c05cae55ebd8..b4e5807d2492. (I didn't change the sizeof / sizeof() stuff -- for one, I didn't want to touch the code on such an urgent push, relative to the posted and tested version.) Thanks Laszlo