From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 61A9FD80808 for ; Thu, 16 Nov 2023 23:42:50 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=DszWMJfSnoSdse45Ey1WFflIpAi7M/PlCFdnesy/cWU=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1700178168; v=1; b=HggzF0cmzZcfzUAiTiJFqx1NtCMplw9JasBhB8eXcmYNGugvbGtHRfv8yNGC6lAVPDOXUKOL Hy5DgJZzZdMlgnaBTrOTCSC6zi2Esz5a/ZsWRrHmI8SjWAZmGQ/tmGd98fGnCen93VWkjdTlbOm COLvGF1+gW6rhUYUX6jNPSQs= X-Received: by 127.0.0.2 with SMTP id 4w7SYY7687511xjpFYhO0OXe; Thu, 16 Nov 2023 15:42:48 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.873.1700178167691309558 for ; Thu, 16 Nov 2023 15:42:48 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10896"; a="370558985" X-IronPort-AV: E=Sophos;i="6.04,205,1695711600"; d="scan'208";a="370558985" X-Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2023 15:42:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10896"; a="715374417" X-IronPort-AV: E=Sophos;i="6.04,205,1695711600"; d="scan'208";a="715374417" X-Received: from scsrds0181.amr.corp.intel.com ([10.116.50.7]) by orsmga003.jf.intel.com with ESMTP; 16 Nov 2023 15:42:45 -0800 From: "Zhen Gong" To: devel@edk2.groups.io Cc: Zhen Gong , Nate DeSimone , Liming Gao Subject: [edk2-devel] [PATCH edk2-platforms 1/1] IpmiFeaturePkg/IpmiRedirFru: Switch to AfterConsole event for callback Date: Thu, 16 Nov 2023 15:42:22 -0800 Message-Id: <6bc749b44eeed932426c046838c0901d15181a64.1700177884.git.zhen.gong@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhen.gong@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: KAgvM72nyEs48qTlTAIfvTkTx7686176AA= Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=HggzF0cm; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none) Use AfterConsole event instead of ReadyToBoot for callback so the driver can update SMBIOS table before booting to setup menu. Cc: Nate DeSimone Cc: Liming Gao Change-Id: Ife697f4c78449b90f17ffa7b7bc5a6a5f77d9436 Signed-off-by: Zhen Gong --- .../IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.inf | 3 ++- .../IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.h | 1 - .../IpmiFeaturePkg/IpmiRedirFru/FruSmbios.c | 16 +++++++++------- 3 files changed, 11 insertions(+), 9 deletions(-) diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.inf b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.inf index 24fbc94128da..814f595b5abe 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.inf +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.inf @@ -25,6 +25,7 @@ [Packages] IpmiFeaturePkg/IpmiFeaturePkg.dec MdePkg/MdePkg.dec MdeModulePkg/MdeModulePkg.dec + MinPlatformPkg/MinPlatformPkg.dec [LibraryClasses] UefiDriverEntryPoint @@ -32,12 +33,12 @@ [LibraryClasses] UefiBootServicesTableLib BaseMemoryLib MemoryAllocationLib - UefiLib IpmiBaseLib [Guids] gEfiIpmiFormatFruGuid gEfiSystemTypeFruGuid + gBdsEventAfterConsoleReadyBeforeBootOptionGuid [Protocols] gEfiSmbiosProtocolGuid diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.h b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.h index 9fd0067973a6..b5ffe1ad0518 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.h +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.h @@ -12,7 +12,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include #include #include -#include #include #include diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/FruSmbios.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/FruSmbios.c index bd4b35ba5793..9c63fae42678 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/FruSmbios.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/FruSmbios.c @@ -454,15 +454,17 @@ GenerateFruSmbiosData ( mFruRedirProtocol = This; - Status = EfiCreateEventReadyToBootEx ( - TPL_CALLBACK, - GenerateFruSmbiosType123DataNotified, - NULL, - &Event - ); + Status = gBS->CreateEventEx ( + EVT_NOTIFY_SIGNAL, + TPL_CALLBACK, + GenerateFruSmbiosType123DataNotified, + NULL, + &gBdsEventAfterConsoleReadyBeforeBootOptionGuid, + &Event + ); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "GenerateFruSmbiosData(): EfiCreateEventReadyToBootEx failed with return value: %r\n", Status)); + DEBUG ((DEBUG_ERROR, "GenerateFruSmbiosData(): Create AfterConsole event failed with return value: %r\n", Status)); } return; -- 2.39.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111330): https://edk2.groups.io/g/devel/message/111330 Mute This Topic: https://groups.io/mt/102638229/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-