From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C03E721A07A82 for ; Tue, 20 Nov 2018 17:31:09 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Nov 2018 17:31:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,259,1539673200"; d="scan'208";a="282847943" Received: from shzintpr02.sh.intel.com (HELO [10.253.24.20]) ([10.239.4.160]) by fmsmga006.fm.intel.com with ESMTP; 20 Nov 2018 17:31:07 -0800 To: Leif Lindholm , Vijayenthiran Subramaniam Cc: edk2-devel@lists.01.org, Nariman Poushin , star.zeng@intel.com References: <20181120103102.17775-1-vijayenthiran.subramaniam@arm.com> <20181120131546.du4ywfipsrrsa4vf@bivouac.eciton.net> From: "Zeng, Star" Message-ID: <6bcf8f27-a229-e622-7869-37a2828ba51c@intel.com> Date: Wed, 21 Nov 2018 09:30:37 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181120131546.du4ywfipsrrsa4vf@bivouac.eciton.net> Subject: Re: [PATCH 1/1] Platform/ARM/SgiPkg: increase max variable size to 8KB X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Nov 2018 01:31:10 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 2018/11/20 21:15, Leif Lindholm wrote: > On Tue, Nov 20, 2018 at 04:01:02PM +0530, Vijayenthiran Subramaniam wrote: >> Commit dc37ca75 ("Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP with >> NetworkPkg drivers") switched to using iSCSI driver from the NetworkPkg >> package. This driver requires the platform to support a maximum variable >> size of atleast 4KB. >> >> So increase the maximum supported variable size to 8KB on the SGI >> platforms. Without this, the iSCSI driver fails to load. >> >> Cc: Ard Biesheuvel >> Cc: Leif Lindholm >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Vijayenthiran Subramaniam > > Looks good to me, but I'd like an R-b from Thomas/Nariman. > > On a separate note, MdeModulePkg maintainers - is this reason enough > to change the default of this Pcd? Yes, the PCD is for platform to customize based on usage, so reasonable. Thanks, Star > > / > Leif > >> --- >> Platform/ARM/SgiPkg/SgiPlatform.dsc | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc b/Platform/ARM/SgiPkg/SgiPlatform.dsc >> index 3f0ca9872e79..1c152fad2246 100644 >> --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc >> +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc >> @@ -102,6 +102,7 @@ >> >> [PcdsFixedAtBuild.common] >> gArmTokenSpaceGuid.PcdVFPEnabled|1 >> + gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000 >> >> # DRAM Block2 Base and Size >> gArmSgiTokenSpaceGuid.PcdDramBlock2Base|0x8080000000 >> -- >> 2.17.1 >>