Hi Himanshu,

Thank you for this patch.

I have a minor suggestion marked inline as [SAMI].

Otherwise this patch looks good to me.

With that fixed,

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 06/12/2023 10:11 am, Himanshu Sharma wrote:

Taking reference from Table 2-1 of the Arm Generic Interrupt Controller
Architecture Specification, Issue H, January 2022, add macros for the
SPI and extended SPI ranges with the purpose of reusability on including
the ArmPkg.

Signed-off-by: Himanshu Sharma <Himanshu.Sharma@arm.com>
---
 ArmPkg/Include/Library/ArmGicArchLib.h | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/ArmPkg/Include/Library/ArmGicArchLib.h b/ArmPkg/Include/Library/ArmGicArchLib.h
index 72ac17e13b5a..1b90b354f785 100644
--- a/ArmPkg/Include/Library/ArmGicArchLib.h
+++ b/ArmPkg/Include/Library/ArmGicArchLib.h
@@ -1,6 +1,7 @@
 /** @file

 *

 *  Copyright (c) 2015, Linaro Ltd. All rights reserved.

+*  Copyright (c) 2023, Arm Limited. All rights reserved.

 *

 *  SPDX-License-Identifier: BSD-2-Clause-Patent

 *

[SAMI] It may be useful to include a reference to the spec.

e.g.

  @par Reference(s):

- Arm Generic Interrupt Controller Architecture Specification,

Issue H, January 2022.

(https://developer.arm.com/documentation/ihi0069/)

[/SAMI]

@@ -23,4 +24,12 @@ ArmGicGetSupportedArchRevision (
   VOID

   );

 

+//

+// GIC SPI and extended SPI ranges

+//

+#define ARM_GIC_ARCH_SPI_MIN      32

+#define ARM_GIC_ARCH_SPI_MAX      1019

+#define ARM_GIC_ARCH_EXT_SPI_MIN  4096

+#define ARM_GIC_ARCH_EXT_SPI_MAX  5119

+

 #endif // ARM_GIC_ARCH_LIB_H_

_._,_._,_

Groups.io Links:

You receive all messages sent to this group.

_._,_._,_