From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id B27CCAC0C5B for ; Thu, 14 Dec 2023 09:47:54 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=pZf4oiPxz6+IRUJjsYPf3a9TYxSaTgIM37TvL4HBGjA=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Authentication-Results-Original:Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:NoDisclaimer:Original-Authentication-Results:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Language; s=20140610; t=1702547273; v=1; b=FbwiuacQ0g4deqzbTY+NG9rUMj8Hg9ONBnQLdNocegJMwBvS3r+yb4rDgH+aaoxWHgp9AJQP JvWw0LIu4mnAtmuTw5yIgsAiVPmP585bQr0GLCBnwXzYqD4qSkht/VFC68mCPH1c7AAzdUOWzat wxo5DEBrh3nGLNzmMD/gHS/g= X-Received: by 127.0.0.2 with SMTP id YedtYY7687511x67SNJY9WE2; Thu, 14 Dec 2023 01:47:53 -0800 X-Received: from EUR05-AM6-obe.outbound.protection.outlook.com (EUR05-AM6-obe.outbound.protection.outlook.com [40.107.22.50]) by mx.groups.io with SMTP id smtpd.web11.18546.1702547271585817692 for ; Thu, 14 Dec 2023 01:47:52 -0800 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=GKhzevWS13F7tACqL55X/hFIQ/lC24Dz9z2BO7xRAt84NTF+PsMABZbkeRNZNpvdEFeDC8Sa6V6zoW4rBVUjAUirZbC5EJ7+Wp+rlZtwRNJgEZU4bH6unhTjwEIvUO+Ta1b+HwOal/5oxEUXnAyjS6WCbtgQVtazKMQ0OfjiVhXvvrdpdZQMlMLVKCF4oGCSOlopbgiVH/EmmZWTUclWqCVwioNEW+BY4/mY1ezvuif8zXIgzzsUy+R5e2P+9I/8hL9SYodFsdO1feIr7Wv45fCA6zT0SBxf8OCW0upOTvCfOtKLpGl1c6vLii0R8Y2CBPyBNAht6Nv2DIGbMwf8aw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z9Zp/qJaczUgoCBjR5UCgkbLsYpFZQ3H8/fus2Pc7KE=; b=YDgd381e6gQKONXSIq03G/LhAbeM7/z6GxOKh+6Tp+7QNY8rR+jnHgjwMk5ugmpinWqkQlun41qTR4gf4t0kB5LkIXm6aVo4xJ0YBwwSz+CMo6bNo2qd9xpnz3/Uxv0gDK8xBRm0Bg8sE5k3KJvcrUpYvFjdxwovmQiWvcUHMTEe0BU9V4t1R2eCMJSuYSXzXaWkAQ3k9wL08fvm8Bnf6oZebn7SKYxWIKc6aWvH1S1FCvKKN3fkSZnvz2qdoo6Vh/eWYwpBUjBULCPkqXew1DXTLSp5afjTKbdW5t7Yr+Wr84CRs2+slPpejEJOs0+BcZqx5VvjAyyMVvaIvQ1T9w== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) X-Received: from AS8PR04CA0196.eurprd04.prod.outlook.com (2603:10a6:20b:2f3::21) by VI1PR08MB5536.eurprd08.prod.outlook.com (2603:10a6:803:13b::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.28; Thu, 14 Dec 2023 09:47:41 +0000 X-Received: from AMS0EPF000001A8.eurprd05.prod.outlook.com (2603:10a6:20b:2f3:cafe::a3) by AS8PR04CA0196.outlook.office365.com (2603:10a6:20b:2f3::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.28 via Frontend Transport; Thu, 14 Dec 2023 09:47:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AMS0EPF000001A8.mail.protection.outlook.com (10.167.16.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.26 via Frontend Transport; Thu, 14 Dec 2023 09:47:41 +0000 X-Received: ("Tessian outbound 20615a7e7970:v228"); Thu, 14 Dec 2023 09:47:41 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 5f171733f433278a X-CR-MTA-TID: 64aa7808 X-Received: from 96d895ee29a9.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 574E967D-2770-4940-8CE1-1C071EDF6FCD.1; Thu, 14 Dec 2023 09:47:29 +0000 X-Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 96d895ee29a9.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 14 Dec 2023 09:47:29 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FfcyruYsIhC0QJOt/6n/xr6L0wmNFXE8TOGxZ8pOT9TzDVGXCICxQbbSIKGrYYxvrxVG96xSaggPyXjt+jxO+P7x/AG/H3nJ0eWVPL90E4IrV17Y1QUcVo+6eciIG4aqZuzJjMCEyj3LP9I2zA1RB5a+zNEWYYe+ZcK+w8vUTDj4Ax+CrdyUDH4GWPKu1o3zaUBVBZ21PjVZ5MFVWqDzBFd7xGT0nO6uv8Q666GpHZ9ok5zRrgmQyIUoCB1A3gV65clhFPZXU/pXSaoKLat7CcSDraH85IJqSwGSoWj59bL8UKa4g/IG2g/DfnhgCP4/C1FuVRFjZy8lbH4R6QvfKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z9Zp/qJaczUgoCBjR5UCgkbLsYpFZQ3H8/fus2Pc7KE=; b=FY23TztISsJAsPDNyv3HRhzRCyVTvV9dT/Sy4LYXQPpitaK8D0+olHYjSwFF6eX/FRzSu3ZuYyaq01YkQib/vB2whj6cc62zBHXsBTzP+uOS7I5qzepZE7pnaRwUsb61zb+HjVViYQ+z3lkbYOrlKErn+ZQlmS3exZaov2NpulHIal6MxVgTgVZUbmkaKj/vgOAqF/N2dhJDpNoFxjr3qOBl2EDdbZUE6dGNBv3xtKfe/eQVEMnd3r5R+Jl+SybMOASOJ08Ndit48opWAdNG4idrb5DD6RR7kX+JDUR9GlEOMzcHqRVJxz1RD7s1AmpXzELazN7oduYcIgz/3BWtTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AS8PR08MB6038.eurprd08.prod.outlook.com (2603:10a6:20b:23f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.28; Thu, 14 Dec 2023 09:47:27 +0000 X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::f36e:3882:2fce:d775]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::f36e:3882:2fce:d775%4]) with mapi id 15.20.7091.028; Thu, 14 Dec 2023 09:47:27 +0000 Message-ID: <6bdea1d2-03ce-44aa-b895-14b8fc440a51@arm.com> Date: Thu, 14 Dec 2023 09:47:26 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [edk2][PATCH V1 1/2] ArmPkg/ArmGicArchLib: Add macros for SPI and extended SPI ranges To: Himanshu Sharma , devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , Pierre Gondois , "nd@arm.com" References: <20231206101146.1309296-1-Himanshu.Sharma@arm.com> <20231206101146.1309296-2-Himanshu.Sharma@arm.com> From: "Sami Mujawar" In-Reply-To: <20231206101146.1309296-2-Himanshu.Sharma@arm.com> X-ClientProxiedBy: LO4P123CA0190.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a4::15) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|AS8PR08MB6038:EE_|AMS0EPF000001A8:EE_|VI1PR08MB5536:EE_ X-MS-Office365-Filtering-Correlation-Id: 97637698-e660-4d07-fe3a-08dbfc89b73c x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: HkSL+yvOXkPJe5FFipxX6PdP7B7RCqdMmB8HZE5P42jhVShi6o5RvZv9bJeuCIglLbaP5VE7ZcgteIh1qTmABQK8is7Nf5vE051bz4AEoVRb/sq855enj9Agjc4+XIVDDrI1/BjMGZFXYiHQvjbMf+JHiR5aT/gJ4Sq82xP2PnRlMawbSxd/mtVTnc6wms5j3W/XbOld+1qU06qBmnZ4eoikCh9+f2wzKDeM9JYgQgOb8XjcICBGjg/tabMj09AzsvNk8T0xtTmbpjVlQ21fZz4NgoSxoeiGA/sK/ugFqURYvYyYNq/CIcB1UwYecx//1ahY2JJMblMSpnGTI1Igo1wa3FFkj8T+Z5rpU4QgXNQ5AWScRnKTRlWYX0Ci5pEvYYW/NlnFlSf0uHH13VcweU8xyG0wywjajS3SLSkvpElS9FLyfzb9WjbhCK/ncHpjHF+0RmKEKa6KknyBu0gONAhFC14HCS6ltrswoDsRrjRt1YZOagWrWrcqyuokIhWReMfRWcSi5PdtLNOL2a3aTKvlKd62GYp0D9n1nrCDBqJIHVrVvX2XkJgDQ74B4ViintmBq7OrjTFFKd0XapwsCo85mykEZkV13YwTPLQOQ4BCPL8D1uS6iY8gSWwOljKb5KXNMJk5Pi9RTt6mEayosA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(376002)(136003)(366004)(396003)(346002)(230922051799003)(451199024)(64100799003)(1800799012)(186009)(41300700001)(83380400001)(38100700002)(33964004)(5660300002)(44832011)(478600001)(6486002)(6512007)(2906002)(53546011)(54906003)(316002)(66476007)(66556008)(8676002)(66946007)(31686004)(4326008)(8936002)(166002)(86362001)(2616005)(26005)(6506007)(31696002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6038 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AMS0EPF000001A8.eurprd05.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a4ac3cf1-47ac-4534-b209-08dbfc89ae77 X-Microsoft-Antispam-Message-Info: qFa8NQ2RRN4XvKTJk2JU7fr7y4m1wmWaQojNg7YWQ2TOIPlS/SGvlmPWkHcFbTLTMoNSqi7/GF5l+7DZkeVavOAe0O1tmHp2iGxo/H/NX3s2P7xm1bESosv5lnZ7F1UFzVbnjSQ5A6u/fMujwz6kAcb29OefyOZYALB+CfwfbfuvLRG0ifGJfKFpYVfbCi6JGoVhTOTGr0xUfFHE9zLxqrv175/XZm+MBOhYuYkCI1z4UouUp7nrZ62bD7KOFH8RzH7a/AIrd24MvRBDR4OwKrBElBcKpwSeUSR0lEl/DpG17NpPFHTLJP89AfTv+9NAiLfqvB/NS1oNd2rF5+rBpcevqZu+lUBQVdIGHOk3Kk/T/koyk6B8DQvmMjtFvB272dwDVDnGkdMwJNM22w6iOkipGbAaFa5yqo7lQL5CKNj+luh1CfSLqF/AdLkbHKzl/I2eP4rINsX2RRIqTfdiKQcGGHmrMKohexgZP8hU4D6B0jJ4oAx22fQ3oQDOdKXgbjoX+kcTtfDHvWaJfcVDAdLhkgCganpxBVWV1PuxHrTcxZTZapMzeKqvOq0gP6Gw7KcJFcNtnJl8Z9OVyV//TOaovtROnel0hZ8whwFI8H6cwRp1fXkJoahMi+ZwaRoJvUMLN+ZHJzNrw0Yv3dvUgC3y+SMX7jFPB5Eqs8r5ikd9LEgnLYzQE7vFPCgPQHEodqcO3SNqp8fHQLtoSZAVS8h2fCf/nrXMbY4O2yDc07Drf3pbv9kqqf3PgdgNxASjlm1TWJkOK+zIGvgzcGtCbA== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2023 09:47:41.7379 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 97637698-e660-4d07-fe3a-08dbfc89b73c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AMS0EPF000001A8.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5536 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 2hQiAq4qmC6zk02hkLWoPpi0x7686176AA= Content-Type: multipart/alternative; boundary="------------502EO0g72aq5z0cBlcktfe83" Content-Language: en-GB X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=FbwiuacQ; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --------------502EO0g72aq5z0cBlcktfe83 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Himanshu, Thank you for this patch. I have a minor suggestion marked inline as [SAMI]. Otherwise this patch looks good to me. With that fixed, Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 06/12/2023 10:11 am, Himanshu Sharma wrote: > Taking reference from Table 2-1 of the Arm Generic Interrupt Controller > Architecture Specification, Issue H, January 2022, add macros for the > SPI and extended SPI ranges with the purpose of reusability on including > the ArmPkg. > > Signed-off-by: Himanshu Sharma > --- > ArmPkg/Include/Library/ArmGicArchLib.h | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/ArmPkg/Include/Library/ArmGicArchLib.h b/ArmPkg/Include/Library/ArmGicArchLib.h > index 72ac17e13b5a..1b90b354f785 100644 > --- a/ArmPkg/Include/Library/ArmGicArchLib.h > +++ b/ArmPkg/Include/Library/ArmGicArchLib.h > @@ -1,6 +1,7 @@ > /** @file > > * > > * Copyright (c) 2015, Linaro Ltd. All rights reserved. > > +* Copyright (c) 2023, Arm Limited. All rights reserved. > > * > > * SPDX-License-Identifier: BSD-2-Clause-Patent > > * [SAMI] It may be useful to include a reference to the spec. e.g. @parReference(s):      - Arm Generic Interrupt Controller Architecture Specification,       Issue H, January 2022.       (https://developer.arm.com/documentation/ihi0069/) [/SAMI] > @@ -23,4 +24,12 @@ ArmGicGetSupportedArchRevision ( > VOID > > ); > > > > +// > > +// GIC SPI and extended SPI ranges > > +// > > +#define ARM_GIC_ARCH_SPI_MIN 32 > > +#define ARM_GIC_ARCH_SPI_MAX 1019 > > +#define ARM_GIC_ARCH_EXT_SPI_MIN 4096 > > +#define ARM_GIC_ARCH_EXT_SPI_MAX 5119 > > + > > #endif // ARM_GIC_ARCH_LIB_H_ > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112517): https://edk2.groups.io/g/devel/message/112517 Mute This Topic: https://groups.io/mt/103010240/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- --------------502EO0g72aq5z0cBlcktfe83 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hi Himanshu,

Thank you for this patch.

I have a minor suggestion marked inline as [SAMI].

Otherwise this patch looks good to me.

With that fixed,

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 06/12/2023 10:11 am, Himanshu Sharma wrote:
Taking reference from Table 2-1 of the Arm Generic Interrupt Controller
Architecture Specification, Issue H, January 2022, add macros for the
SPI and extended SPI ranges with the purpose of reusability on including
the ArmPkg.

Signed-off-by: Himanshu Sharma <Himanshu.Sharma@arm.com>
---
 ArmPkg/Include/Library/ArmGicArchLib.h | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/ArmPkg/Include/Library/ArmGicArchLib.h b/ArmPkg/Include/Library/ArmGicArchLib.h
index 72ac17e13b5a..1b90b354f785 100644
--- a/ArmPkg/Include/Library/ArmGicArchLib.h
+++ b/ArmPkg/Include/Library/ArmGicArchLib.h
@@ -1,6 +1,7 @@
 /** @file

 *

 *  Copyright (c) 2015, Linaro Ltd. All rights reserved.

+*  Copyright (c) 2023, Arm Limited. All rights reserved.

 *

 *  SPDX-License-Identifier: BSD-2-Clause-Patent

 *
[SAMI] It may be useful to include a reference to the spec.

e.g.

  @par Reference(s):

     - Arm Generic Interrupt Controller Architecture Specification,

      Issue H, January 2022.

      (https://developer.arm.com/documentation/ihi0069/)

[/SAMI]

@@ -23,4 +24,12 @@ ArmGicGetSupportedArchRevision (
   VOID

   );

 

+//

+// GIC SPI and extended SPI ranges

+//

+#define ARM_GIC_ARCH_SPI_MIN      32

+#define ARM_GIC_ARCH_SPI_MAX      1019

+#define ARM_GIC_ARCH_EXT_SPI_MIN  4096

+#define ARM_GIC_ARCH_EXT_SPI_MAX  5119

+

 #endif // ARM_GIC_ARCH_LIB_H_
_._,_._,_
Groups.io Links:

You receive all messages sent to this group.

View/Reply Online (#112517) | | Mute This Topic | New Topic
Your Subscription | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--------------502EO0g72aq5z0cBlcktfe83--