From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8068B940067 for ; Mon, 22 Jul 2024 00:11:00 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Y9sKUYdlfPEyaYLFGLICoppY+V2P7DwPJ+4DIYA7/Fs=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1721607060; v=1; b=winNVVmESy3KKi0xkuIlGY/O2lXXndtzWW5fDSEIjxvuMMjRQMs09ItPLeXoKgvkxQ+qoofA y+ZJp20mqTKpXLPc6rnzBBSps8BsyCRYbUQeVigjtJQQjCceUjGM4YKY0lfk14chtdndqc3vLRL D/OX0LXC8fnw/PcjQcFl6fAwHVSOTcSlv6N3b5cuPOtLcaJEuJPvMKcQyL/v5Wylz2BfP4IOaVv Ogtr3CfmUdOAA4CKVVNxvKRso+WpDE/D2ENXTWZN482H7PBEOZLwoPIUkKglUgOdtC5eNR2DBMT d1T1YlGV8Sct8O8XzGNEXu5Dud0RU6ZkXTmjDzdI5rPuw== X-Received: by 127.0.0.2 with SMTP id eESHYY7687511xga1NO8nk12; Sun, 21 Jul 2024 17:10:58 -0700 X-Received: from NAM04-MW2-obe.outbound.protection.outlook.com (NAM04-MW2-obe.outbound.protection.outlook.com [40.107.101.126]) by mx.groups.io with SMTP id smtpd.web10.7865.1721607053039996153 for ; Sun, 21 Jul 2024 17:10:53 -0700 X-Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by PH7PR01MB7869.prod.exchangelabs.com (2603:10b6:510:1dc::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.29; Mon, 22 Jul 2024 00:10:49 +0000 X-Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::fc79:e629:93aa:8b8f]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::fc79:e629:93aa:8b8f%3]) with mapi id 15.20.7784.017; Mon, 22 Jul 2024 00:10:49 +0000 Message-ID: <6bdf8471-d390-4581-b08e-5d1df81bddca@os.amperecomputing.com> Date: Mon, 22 Jul 2024 07:10:29 +0700 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH edk2-platforms 3/4] Platform/Ampere: Switch to generic ResetRuntime DXE driver To: Ard Biesheuvel , devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , Oliver Smith-Denny , Rebecca Cran , Chuong Tran , Peng Xie , Ling Jia , Yiqi Shu References: <20240721145155.324900-1-ardb+git@google.com> <20240721145155.324900-4-ardb+git@google.com> From: "Nhi Pham via groups.io" In-Reply-To: <20240721145155.324900-4-ardb+git@google.com> X-ClientProxiedBy: SJ0PR03CA0124.namprd03.prod.outlook.com (2603:10b6:a03:33c::9) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB7287:EE_|PH7PR01MB7869:EE_ X-MS-Office365-Filtering-Correlation-Id: 6a146631-80b3-4340-490a-08dca9e2bde5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: =?utf-8?B?bzFXeUl1WjMzQURBUDF6b1YxKzI1WUVYc2kzUGwyWUFlWXZYS2toaTdaSWRt?= =?utf-8?B?alk4eWduTjZybXpCeU81cjFOVHZIdTBISGFQam9Bdy9QYmphTkVSYTFNS0Jv?= =?utf-8?B?YnNLYU1yN1ZndktHMGdVKzBOOVFzVmhlTnpGTVZ0Y3dFZTMwZk0vd205c1lU?= =?utf-8?B?MmY2WHZoZVVBRjRZVGlMQ0l0bVFIbkxXUE1icUdEdFRONVJpODNJY3NIcEds?= =?utf-8?B?TmtRTUN4OXhjVjdrS2tCTHhYNWwvL05SRWhSY3ozRzJhamRmTERDQy9qVlRH?= =?utf-8?B?MS9aVFRrWEdFYzNxMjhLZUNzZnRDanpYZ3I4SnlwREVZaHVHT1dtbzA2c0Fa?= =?utf-8?B?ZFJlN211S1RhK056V2tYRXdReUdjSDI5NitXSlVRb1phUnhDN2ZJNVBvaDBv?= =?utf-8?B?YVZCTEdoeWhWUllQSHRsWjVBcnFoV1RyVSt6TGtUdDVqVzl4d253L0t6UjRN?= =?utf-8?B?Q3Fmcjg1MjRHWHM5QUdINzMrUGpyM2t1a1F4MHAvV2orLzNDaVlkZXZQZ0Vn?= =?utf-8?B?RUhNUjl6bVBkdVVPbFljaUlWMVlsK1U0dUlnUFM1QjY2dVZxQmRwZjEvNVY3?= =?utf-8?B?LzVkWW9rWENuWit0UlBLQ0owL29JK1pWTW9YNmQzcWdoNHVkczJJbkRZaXFF?= =?utf-8?B?MFBkK2UyWkRndXVpZ28ySGtqeUNJU1ZGQmJaMDhWZ2ZFTmZlVVJSemlvK0Nk?= =?utf-8?B?L3NCYTdjRkFtY3VUcnlMQ3BQcHVxc3ZvL29TalNuOVViTU80Mm41dWVuVGxF?= =?utf-8?B?dG9rdHFCdk0xampCWHE4eXVCbWVrVW4vcDJhMENQY1dwWkFoQjM4blRaQzBw?= =?utf-8?B?UkZpTWdEd25sS3NkRHpNWFl2VFBwNlV6SUIvNkJVMkFHSzV3K2N1bFYveThT?= =?utf-8?B?RnlDa1g0WFdFSk9Bb085RzNybEVSOHpuTVFPaVpwRzIrYktFWTBWYVRkajJD?= =?utf-8?B?ZWVaVmN1KzQ3R054Rk96clBVT0JGSVpHMmw4SGZaS2tLWEtxWG05VnFOeERY?= =?utf-8?B?SWtQNnNWdFRBY2FoWHJjNW9tc0EvQjB5eUZqWFBMRmlyeGhDamdOWGRjbTZX?= =?utf-8?B?Z1F6S3JtZmhKWHFPbTZFcmtjVWNubnc2Qy80cEZQM2NSTXA1L3dsSzkxN1Rv?= =?utf-8?B?WVJOOEYyM3Ztb01nZ2xkWEwwanhuN0hGSWdTWjhpVmdLdnJCVytBSG5UT1lU?= =?utf-8?B?TklXNEVTcFZ5OUdTT3lWSVJob3ppUlpmODFwL3k1S00zYnVublgrb0JEdlZj?= =?utf-8?B?czBlWlVOUTF2VHhNTGpBZVJTR3A4OGlzWUdqSCtqaG1Vd0YzYmN0czV4WVBy?= =?utf-8?B?RXRHZllWTGpjUk95b0hOWUdyQVNvQjZ6Sk9vUEFjUzJiYnViNzNrSDE0WTho?= =?utf-8?B?a0dIUE1DR1hQZFNKdHZRd015R2JBM0FqTFFqNHhRYU1qd0ZSdzBhK29MTUJm?= =?utf-8?B?ZmVlV0dsaFVWUVA0N2NaNUpKcmU0ekRyVHVlQTFtVEY4dXhINVFjY2plYUlx?= =?utf-8?B?a2NQVEhOZitEQ3U5dm1SRG1qcTN0clQ3VUtkUmRWZXVEanJVSW9uRDBiNk43?= =?utf-8?B?R0VWWWJIMC9lRHZZa29oWis5SG1aWkE1VTNuUHJHQmlTUHd6YUgxWFAxazZl?= =?utf-8?B?T3VYcWMxVUdaZkdEdXdsNURMcjdNV1hEWWtKUjdsTGhqZmRmZ3lzaXVkNmU0?= =?utf-8?B?elN0YTV2b3lrdjJhaEo3dWZNQXJURU96eEpJWktCR1F0YS9FN2wyaDJkaFIv?= =?utf-8?B?WWtBSWVJQ0VZVWRLbURETms2UGdrQVB2TjUvdXMvZEhITWZOTlZZOVc1d3Np?= =?utf-8?B?aEpScGNlQlFFOXBxUEFKQT09?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QWgyWkdRdjg3L1Y0OTVOTzBzOXBiMENBQ2lJdXhZM3YvK0w2VDY5K29TRFN6?= =?utf-8?B?ME5DcHdwSmd0dVNIWFR0cUlqUnhhV2p3c1NMUkh6bGpnbnNBT1ZKcDl0bm4w?= =?utf-8?B?MktTRmpaT1UydDN2WkwwVkc5R0ZteW91dlUxdzdGeEZDZEpHaklXZ0I4dG5h?= =?utf-8?B?MDVIMHFGemFOS0ZFNGV0QXc4amo5SjJPMGE2d1NWT1hPQlY5NEJIZjRibWZM?= =?utf-8?B?RjNVa0ZSVjYrTkd0dEVhaFFsSlZEUXNPcmFhWFY5SEhlS1A1dit6cmI2Wmpn?= =?utf-8?B?TkFlWGFaZFZVbGhndGxITDAxNHl2Y3o3K3NlYSs0U1AxdDZzWUtoUkVzOGJX?= =?utf-8?B?ckJFc1R3dUM2bDBlWVk5d0lSZUFCbEFxek1JckFKK1hoOTB1UWdqRmxkSWk3?= =?utf-8?B?bjV5cnA2SC92dnRzQVlYR2hmRzVqR2txVjNHc210RXZwcElZbUFyZFVRY3hK?= =?utf-8?B?OW5IcXYvdTVlazBhQjZWZ0hSQk80WTRsdFFBSmxzNGpKQ2FWWEhuZmM2N1JR?= =?utf-8?B?WDF4UVI1VmNuZE5lQVc0WnVtSk9LSGlYbGlxeFlWRVRRblB3ZUZORFdKYzdQ?= =?utf-8?B?aWlieVE4ZVRrOHpCbG5XVXM4NUIyNS9tb0NkUG50RGo3VG9adlNBWmlad1lS?= =?utf-8?B?aEk2eElxb2JXWVExRFEzZkFnR2wyZUJjMXFJNWwyNXZsdkJDY1FkcW9YZFFK?= =?utf-8?B?T2Yxd2JMUmF1alJYYm9jWG85N2VxOVk5VDdjYjd1RWVuWXBrV0JqUmdnai8y?= =?utf-8?B?V0tSQVY2WlN1Q013cGNhcTFOc3c5M3djTWwzVGUwSEp6ZDNJOGhnMkpOQmtz?= =?utf-8?B?cStyamJjSXFRYU40cU9kd1ZDNmdCdHdxLzMrVE1DNllpQlhiQkpUTUFHaGs4?= =?utf-8?B?WjVsTGtwWUpHMGJ0VWFGMWMwKzA2MUsxMUkwVzYxM3k1SFU3MzhoSXMwRUxp?= =?utf-8?B?ZGN6RmQ5THFEN0I4UGJCbXh3OGhPaC9iNWtsNHIwM0dLRWhrSXNuQm5qWUVz?= =?utf-8?B?REdVeWlEVEs1NVdFbkdLVGlvK0t6TnVjSUhKMU5XOWNLSmUrcm5INDdNcTV5?= =?utf-8?B?RzZ2MzBzeUhENlVtN09hbUtSTHlUZm51cEhkMlpWdU9iTnAzUkNBbksvS08y?= =?utf-8?B?TjZ4eGNmTWlGR3FYR0JvUDY0b0R5VGhUekIrTXBEWmEvanVSdXVVN0ZVVzJC?= =?utf-8?B?aDk1ZEhUdlFWL3VzMDQ0WlNaenBKemRFa09EQW5xRzl4RVZpYXVPaXFYRDJl?= =?utf-8?B?UWFSZXZ3WXlQQkliVWliaHpiay9DTEVCMHdFZTZLaGVKQnhGcnVuSXBlMG5l?= =?utf-8?B?QWptUCswR3JqRHRUT2hMZiticUR5SU4yQ2Nya1ArMU5GTWZPeWo4UmpHK25P?= =?utf-8?B?d0F4RFQ5VVdoU2hpS2ozQWJXbVVVcXAvTzNJM1dxMm91Skp5emtnMVBLMWtl?= =?utf-8?B?WElWK2tYYTQrb3lLVmI0T002OTIzaS9CWThESHJoZ1l6MjYrd25QcjB0cXJm?= =?utf-8?B?SHFTUG9TdzVvV3dSUGk2TnlwZ3c4MUxtYStkdzNlNTRvd01TaG5Fd2tPZGJE?= =?utf-8?B?N25KWWJmeU5STkpyM3NnWEhHcmVPc0RWejM3Y2xMdWVOYzRjUzEvejRtZ2tU?= =?utf-8?B?RnFqSUdsK3dGa01uM2R5d3JDUW56WXlOZFFEOHpZYnJvLzlyZjRUQ1ZxZ0l5?= =?utf-8?B?U2pHdVR1dzBZODl4Y3QzdU9ZandDRkxmZ09EaVd1WFl2cnVkTmIrSExlaG5S?= =?utf-8?B?SHRMNGRnY1FwZmFVMjd0cDltT3hvangrcCtReWhaVWY3SXVzSUdGRlZPTk5H?= =?utf-8?B?UDNYdHpVRDhGdWdLbzJhWmE0NDZ4NVNZMGhidSsxaUx4d0RvTzBqVzRmdDB2?= =?utf-8?B?SW1GTEU5ZzI2d1Y3cngvOWNvOUJMdHlEQ1lzcnlPaUxZalpqSExPMWgxbnY4?= =?utf-8?B?a0RDTjVFWUhaRTd0WFQ2TUsreDZ1eVY5MjZuaDFwZkRvRGdqdXZRZjZkc3ZM?= =?utf-8?B?eUk3UzE0T2gxUk9iTDE0TEtrS2orUERXYmU2SEFvdFRRZXg4bmNoM2x3bVhF?= =?utf-8?B?T2dOVjJMVG10RlFFV0RxMjZPakpaNlBkR01qVUdRYVF1bU1NNVhKZU1Ya2Q5?= =?utf-8?B?eUNmbUxzck05cVBIUFpJMWhjQW1FZVNlZ3RNYkdOVUJqQVFuaFdjNWxuM3E4?= =?utf-8?Q?XWXm0hyrc/B5oezgjcpKKyA=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6a146631-80b3-4340-490a-08dca9e2bde5 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2024 00:10:49.4834 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pjAZ4FbbYnZ0tBlR+NiKkwU+M6c4Qdf/l3Qy2K7a8KVXSFPmdvpXjkJU4ET2Hhl6YoOMjJy2uuC2NY3nc/LiXYjcoKsgumOQnIG4KjkIG3U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR01MB7869 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Sun, 21 Jul 2024 17:10:53 -0700 Resent-From: nhi@os.amperecomputing.com Reply-To: devel@edk2.groups.io,nhi@os.amperecomputing.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 6a8g11Db16rXqfXzzwRK4qNRx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=winNVVmE; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Thanks a lot for the patch. Reviewed-by: Nhi Pham Tested-by: Nhi Pham On 7/21/2024 9:51 PM, Ard Biesheuvel wrote: > From: Ard Biesheuvel >=20 > The reset runtime DXE driver is deprecated and will be removed soon. It > is superseded by a generic implementation in MdeModulePkg, which is > shared between all architectures, and implements the notification > protocols that the EFI spec describes. So move the Ampere Jade platform > to this implementation the of ResetSystem EFI runtime service. >=20 > Signed-off-by: Ard Biesheuvel > --- > Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 3 +-- > Platform/Ampere/JadePkg/Jade.fdf | 2 +- > 2 files changed, 2 insertions(+), 3 deletions(-) >=20 > diff --git a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc b/Silic= on/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc > index 1f705c68579a..fb170d436d00 100644 > --- a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc > +++ b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc > @@ -259,7 +259,6 @@ [LibraryClasses.common.DXE_RUNTIME_DRIVER] > !endif > VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolic= yLibRuntimeDxe.inf > =20 > - EfiResetSystemLib|ArmPkg/Library/ArmPsciResetSystemLib/ArmPsciResetSys= temLib.inf > ArmSmcLib|ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf > NVParamLib|Silicon/Ampere/AmpereAltraPkg/Library/NVParamLib/RuntimeNVP= aramLib.inf > AmpereCpuLib|Silicon/Ampere/AmpereAltraPkg/Library/AmpereCpuLib/Runtim= eAmpereCpuLib.inf > @@ -588,7 +587,7 @@ [Components.common] > !endif > MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf > MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterRunt= imeDxe.inf > - EmbeddedPkg/ResetRuntimeDxe/ResetRuntimeDxe.inf > + MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystemRuntimeDxe.inf > EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf > EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf > ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf > diff --git a/Platform/Ampere/JadePkg/Jade.fdf b/Platform/Ampere/JadePkg/J= ade.fdf > index 7795f0e11115..127e4401f69b 100644 > --- a/Platform/Ampere/JadePkg/Jade.fdf > +++ b/Platform/Ampere/JadePkg/Jade.fdf > @@ -222,7 +222,7 @@ [FV.FvMain] > INF SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootCo= nfigDxe.inf > !endif > INF MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounter= RuntimeDxe.inf > - INF EmbeddedPkg/ResetRuntimeDxe/ResetRuntimeDxe.inf > + INF MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystemRuntimeDxe= .inf > INF EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf > INF EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf > INF MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120001): https://edk2.groups.io/g/devel/message/120001 Mute This Topic: https://groups.io/mt/107476835/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-