Re: CorebootPayloadPkg: redirect UEFI Shell to serial

[Laszlo Ersek <lersek@redhat.com>]

On 07/15/17 15:00, Piotr Król wrote:

> 2. There are 2 minor typos like gUEfi instead of gUefi and entrhy
> instead of entry, does it make sense to send patches for that ? In
> various places I saw more typos like that.

Typo corrections are welcome.

> 4. I had to move some PCDs to PcdsFixedAtBuild section.

Why?

> This seems to
> makes difference for PcdSet64S. After that I'm getting error from that
> function. Where I can read about difference between normal PCD and
> FixedAtBuild

As their name says, fixed-at-build PCDs can't be set at runtime.
- The .dec file declares the possible storage types for a given PCD that
any platform can assign to the PCD. The .dec file also sets a default value.
- in the platform .dsc file, the platform can omit the PCD completely.
In this case modules built into the platform will get the default value
from the .dec, and they won't be able to set the PCD.
- the platform .dsc can also spell out the PCD. This determines the
actual storage the platform assigns to the PCD (such as dynamic,
dynamic-ex, dynamic-hii, fixed-at-build) and also lets the platform set
its own default for the PCD. Modules built into the platform will see
the following values for the PCD:
  - if the PCD is fixed-at-build, then they'll get the value set in the
    DSC. The PCD cannot be set by modules.
  - if the PCD is dynamic or dynamic-ex, then the initial value is the
    one set in the DSC. Modules can overwrite the PCD, and later "get"s
    will return that value.
  - if the PCD is dynamic-hii, then it is backed by a non-volatile UEFI
    variable.

... This is quite a bit of hand-waving, but should be good enough for
now. The way fixed-at-build PCDs seem to work for you is by design; I'd
rather try to understand why you had to change a dynamic PCD into a
fixed one.

The rest of your questions should be directly addressed to the
maintainers of those packages / modules (see Maintainers.txt).

Thanks
Laszlo