From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1E6FC21CE7481 for ; Tue, 25 Jul 2017 02:14:36 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6C5977DCC4; Tue, 25 Jul 2017 09:16:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 6C5977DCC4 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=lersek@redhat.com Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-22.phx2.redhat.com [10.3.116.22]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7DF5D18A20; Tue, 25 Jul 2017 09:16:35 +0000 (UTC) To: =?UTF-8?Q?Piotr_Kr=c3=b3l?= , edk2-devel@lists.01.org References: <721bf59b-166b-7a67-a1e7-b3e30d2487d3@3mdeb.com> <5f50924b-c781-2715-2447-a7a94d571efb@3mdeb.com> <6c6655ec-a01d-c2ee-ed38-453e707dd3ac@redhat.com> <4d713a2b-1526-0476-d765-f591fe8cfaf2@3mdeb.com> From: Laszlo Ersek Message-ID: <6be56212-9e83-7485-076f-e26e71838adf@redhat.com> Date: Tue, 25 Jul 2017 11:16:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <4d713a2b-1526-0476-d765-f591fe8cfaf2@3mdeb.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 25 Jul 2017 09:16:36 +0000 (UTC) Subject: Re: CorebootPayloadPkg: redirect UEFI Shell to serial X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Jul 2017 09:14:36 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 07/15/17 15:00, Piotr Król wrote: > 2. There are 2 minor typos like gUEfi instead of gUefi and entrhy > instead of entry, does it make sense to send patches for that ? In > various places I saw more typos like that. Typo corrections are welcome. > 4. I had to move some PCDs to PcdsFixedAtBuild section. Why? > This seems to > makes difference for PcdSet64S. After that I'm getting error from that > function. Where I can read about difference between normal PCD and > FixedAtBuild As their name says, fixed-at-build PCDs can't be set at runtime. - The .dec file declares the possible storage types for a given PCD that any platform can assign to the PCD. The .dec file also sets a default value. - in the platform .dsc file, the platform can omit the PCD completely. In this case modules built into the platform will get the default value from the .dec, and they won't be able to set the PCD. - the platform .dsc can also spell out the PCD. This determines the actual storage the platform assigns to the PCD (such as dynamic, dynamic-ex, dynamic-hii, fixed-at-build) and also lets the platform set its own default for the PCD. Modules built into the platform will see the following values for the PCD: - if the PCD is fixed-at-build, then they'll get the value set in the DSC. The PCD cannot be set by modules. - if the PCD is dynamic or dynamic-ex, then the initial value is the one set in the DSC. Modules can overwrite the PCD, and later "get"s will return that value. - if the PCD is dynamic-hii, then it is backed by a non-volatile UEFI variable. ... This is quite a bit of hand-waving, but should be good enough for now. The way fixed-at-build PCDs seem to work for you is by design; I'd rather try to understand why you had to change a dynamic PCD into a fixed one. The rest of your questions should be directly addressed to the maintainers of those packages / modules (see Maintainers.txt). Thanks Laszlo