From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: devel@edk2.groups.io, nathaniel.l.desimone@intel.com
Cc: Chasel Chiu <chasel.chiu@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Eric Dong <eric.dong@intel.com>,
Michael Kubacki <michael.kubacki@microsoft.com>,
Isaac Oram <isaac.w.oram@intel.com>
Subject: Re: [edk2-devel] [edk2-platforms] [PATCH v1] MinPlatformPkg: Add missing macro for LargeVariableLib
Date: Thu, 15 Apr 2021 20:07:04 -0700 [thread overview]
Message-ID: <6bf53643-7118-815b-7b76-a94b0b1c064a@linux.microsoft.com> (raw)
In-Reply-To: <20210416024717.717-1-nathaniel.l.desimone@intel.com>
Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>
On 4/15/2021 7:47 PM, Nate DeSimone wrote:
> With all the refactoring done during code review, I misplaced
> the MAX_VARIABLE_NAME_PAD_SIZE macro. This patch adds it back.
>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> ---
> .../Library/BaseLargeVariableLib/LargeVariableCommon.h | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Platform/Intel/MinPlatformPkg/Library/BaseLargeVariableLib/LargeVariableCommon.h b/Platform/Intel/MinPlatformPkg/Library/BaseLargeVariableLib/LargeVariableCommon.h
> index b6554764b7..d6db9f6c66 100644
> --- a/Platform/Intel/MinPlatformPkg/Library/BaseLargeVariableLib/LargeVariableCommon.h
> +++ b/Platform/Intel/MinPlatformPkg/Library/BaseLargeVariableLib/LargeVariableCommon.h
> @@ -44,4 +44,11 @@
> //
> #define MAX_VARIABLE_SPLIT_DIGITS 6
>
> +//
> +// On some architectures (Ex. Itanium) there a requirement to
> +// maintain DWORD alignment of the variable data. Hence the
> +// maximum possible padding size is 3.
> +//
> +#define MAX_VARIABLE_NAME_PAD_SIZE 3
> +
> #endif // _LARGE_VARIABLE_COMMON_H_
>
next prev parent reply other threads:[~2021-04-16 3:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 2:47 [edk2-platforms] [PATCH v1] MinPlatformPkg: Add missing macro for LargeVariableLib Nate DeSimone
2021-04-16 3:07 ` Michael Kubacki [this message]
[not found] <167636B28070B26A.12361@groups.io>
2021-05-13 21:26 ` [edk2-devel] " Nate DeSimone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bf53643-7118-815b-7b76-a94b0b1c064a@linux.microsoft.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox