From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mx.groups.io with SMTP id smtpd.web10.4109.1618542424511104057
 for <devel@edk2.groups.io>;
 Thu, 15 Apr 2021 20:07:04 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linux.microsoft.com header.s=default header.b=inCiM1hl;
 spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com)
Received: from [10.124.238.202] (unknown [167.220.2.74])
	by linux.microsoft.com (Postfix) with ESMTPSA id DC6B320B8002;
	Thu, 15 Apr 2021 20:07:03 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com DC6B320B8002
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
	s=default; t=1618542424;
	bh=sPsHXZNDzQujOI/h9CsWB0+oBm+i5YAHTK7eNqzbavk=;
	h=Subject:To:Cc:References:From:Date:In-Reply-To:From;
	b=inCiM1hlgESY8LmDu6HHKCpjpS/feXtadJsQZkesnMwEIL8fdfbfEv/kXybhNPXmX
	 gkf25YlbGCZCyhEivWTKQhsAIenHvnp3aszPkspav13npMHcLhfi7HAXCa18JkC9Tm
	 R338H/shQMvPk5wsaKm1ZYKph3h3ig+LQXTJ8Lm8=
Subject: Re: [edk2-devel] [edk2-platforms] [PATCH v1] MinPlatformPkg: Add missing macro for LargeVariableLib
To: devel@edk2.groups.io, nathaniel.l.desimone@intel.com
Cc: Chasel Chiu <chasel.chiu@intel.com>, Liming Gao
 <gaoliming@byosoft.com.cn>, Eric Dong <eric.dong@intel.com>,
 Michael Kubacki <michael.kubacki@microsoft.com>,
 Isaac Oram <isaac.w.oram@intel.com>
References: <20210416024717.717-1-nathaniel.l.desimone@intel.com>
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
Message-ID: <6bf53643-7118-815b-7b76-a94b0b1c064a@linux.microsoft.com>
Date: Thu, 15 Apr 2021 20:07:04 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.9.1
MIME-Version: 1.0
In-Reply-To: <20210416024717.717-1-nathaniel.l.desimone@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 4/15/2021 7:47 PM, Nate DeSimone wrote:
> With all the refactoring done during code review, I misplaced
> the MAX_VARIABLE_NAME_PAD_SIZE macro. This patch adds it back.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> ---
>   .../Library/BaseLargeVariableLib/LargeVariableCommon.h     | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/Platform/Intel/MinPlatformPkg/Library/BaseLargeVariableLib/LargeVariableCommon.h b/Platform/Intel/MinPlatformPkg/Library/BaseLargeVariableLib/LargeVariableCommon.h
> index b6554764b7..d6db9f6c66 100644
> --- a/Platform/Intel/MinPlatformPkg/Library/BaseLargeVariableLib/LargeVariableCommon.h
> +++ b/Platform/Intel/MinPlatformPkg/Library/BaseLargeVariableLib/LargeVariableCommon.h
> @@ -44,4 +44,11 @@
>   //
>   #define MAX_VARIABLE_SPLIT_DIGITS   6
>   
> +//
> +// On some architectures (Ex. Itanium) there a requirement to
> +// maintain DWORD alignment of the variable data. Hence the
> +// maximum possible padding size is 3.
> +//
> +#define MAX_VARIABLE_NAME_PAD_SIZE  3
> +
>   #endif  // _LARGE_VARIABLE_COMMON_H_
>