From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 16 Apr 2019 05:54:05 -0700 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DDA6B319936B; Tue, 16 Apr 2019 12:53:53 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-171.rdu2.redhat.com [10.10.120.171]) by smtp.corp.redhat.com (Postfix) with ESMTP id 496541001E89; Tue, 16 Apr 2019 12:53:49 +0000 (UTC) Subject: Re: [edk2-CCodingStandardsSpecification Patch] Change preferred license of EDK II to BSD+Patent To: Michael D Kinney , devel@edk2.groups.io Cc: Andrew Fish , Leif Lindholm References: <20190415205722.20752-1-michael.d.kinney@intel.com> From: "Laszlo Ersek" Message-ID: <6c0c2b3d-2284-ac7d-d6ce-d929a5f2aa38@redhat.com> Date: Tue, 16 Apr 2019 14:53:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190415205722.20752-1-michael.d.kinney@intel.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Tue, 16 Apr 2019 12:54:03 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 04/15/19 22:57, Michael D Kinney wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1656 >=20 > Change the EDK II C Coding Standards Specification to state that > the preferred license of the EDK II is the BSD+Patent License and > that file headers should use SPDX license identifiers. >=20 > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Michael Kinney > --- > 5_source_files/52_spacing.md | 23 +++++------------------ > 5_source_files/53_include_files.md | 10 +--------- > 5_source_files/54_code_file_structure.md | 10 +--------- > appendix_a_common_examples.md | 9 +-------- > 4 files changed, 8 insertions(+), 44 deletions(-) >=20 > diff --git a/5_source_files/52_spacing.md b/5_source_files/52_spacing.m= d > index ddeabf7..012a192 100644 > --- a/5_source_files/52_spacing.md > +++ b/5_source_files/52_spacing.md > @@ -279,15 +279,7 @@ the preferred indentation, but two tabs (four spac= es) is also acceptable. > information for a person viewing the file for the first time. > =20 > Copyright (C) --20XX, Acme Corporation. All rights reserved.
> - This program and the accompanying materials > - are licensed and made available under the terms and conditions of > - the BSD License which accompanies this distribution. The full > - text of the license may be found at > - http://opensource.org/licenses/bsd-license. > - > - THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > - BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > - EXPRESS OR IMPLIED. > + SPDX-License-Identifier: BSD-2-Clause-Patent > =20 > @par Revision Reference: > - PI Version 1.0 > @@ -364,17 +356,12 @@ the location and content of the file. The correct= license will be determined by > the project leader at the time the file is created. In most cases, the= license > will be the same as for other files in the module or package. > =20 > -The majority of the files in EDK II contain the following "BSD" licens= e. > +The preferred license for EDK II is the "BSD+Patent" license. The lic= ense for > +a file is provided in the file header using an SPDX identifier. The f= ollowing > +shows the SPDX identifier for the "BSD+Patent" license. > =20 > ``` > -This program and the accompanying materials are licensed and made > -available under the terms and conditions of the BSD License that > -accompanies this distribution. The full text of the license may be > -found at http://opensource.org/licenses/bsd-license. > - > -THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > -WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR > -IMPLIED. > +SPDX-License-Identifier: BSD-2-Clause-Patent > ``` > =20 > The license will follow the copyright notice without an intervening bl= ank line. All of the above looks good, but this context line ("The license will follow the copyright notice without an intervening blank line.") catches my eye. I don't think we conform to that requirement (nor that we did before the conversion to SPDIX/BSD+Patent). Should we drop this line? Perhaps in a separate patch? Anyway, for this patch: Reviewed-by: Laszlo Ersek Thanks Laszlo > diff --git a/5_source_files/53_include_files.md b/5_source_files/53_inc= lude_files.md > index 890e1c7..a859b76 100644 > --- a/5_source_files/53_include_files.md > +++ b/5_source_files/53_include_files.md > @@ -151,15 +151,7 @@ Not all types of declarations are present in every= file. > you should probably also explain your rationale. > =20 > Copyright (c) 20XX, Acme Corporation. All rights reserved.
> - This program and the accompanying materials > - are licensed and made available under the terms and conditions of > - the BSD License which accompanies this distribution. The full > - text of the license may be found at > - http://opensource.org/licenses/bsd-license. > - > - THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > - BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > - EXPRESS OR IMPLIED. > + SPDX-License-Identifier: BSD-2-Clause-Patent > =20 > @par Specification Reference: > - UEFI 2.3, Chapter 9, Device Path Protocol > diff --git a/5_source_files/54_code_file_structure.md b/5_source_files/= 54_code_file_structure.md > index 8cc9f4f..caaeab9 100644 > --- a/5_source_files/54_code_file_structure.md > +++ b/5_source_files/54_code_file_structure.md > @@ -45,15 +45,7 @@ these are C files with an extension of "`.c`". > you should probably also explain your rationale. > =20 > Copyright (c) 20XX, Acme Corporation. All rights reserved.
> - This program and the accompanying materials > - are licensed and made available under the terms and conditions of > - the BSD License which accompanies this distribution. The full > - text of the license may be found at > - http://opensource.org/licenses/bsd-license.php > - > - THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > - BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > - EXPRESS OR IMPLIED. > + SPDX-License-Identifier: BSD-2-Clause-Patent > =20 > @par Specification Reference: > - UEFI 2.3, Chapter 9, Device Path Protocol > diff --git a/appendix_a_common_examples.md b/appendix_a_common_examples= .md > index 1f247f3..d7b1a89 100644 > --- a/appendix_a_common_examples.md > +++ b/appendix_a_common_examples.md > @@ -40,14 +40,7 @@ > Detailed description of file=E2=80=99s purpose. > =20 > Copyright (c) 2006 - 2014, Acme Corporation. All rights reserved. > - This program and the accompanying materials > - are licensed and made available under the terms and conditions > - of the BSD License which accompanies this distribution. The full > - text of the license may be found at > - http://opensource.org/licenses/bsd-license.php > - > - THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS= , > - WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR= IMPLIED. > + SPDX-License-Identifier: BSD-2-Clause-Patent > =20 > @par Specification Reference: > - UEFI 2.3, Chapter 9, Device Path Protocol >=20