From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7E88721A070B8 for ; Wed, 3 Apr 2019 05:13:30 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 08158307D90E; Wed, 3 Apr 2019 12:13:30 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-127.rdu2.redhat.com [10.10.120.127]) by smtp.corp.redhat.com (Postfix) with ESMTP id E67C0608D5; Wed, 3 Apr 2019 12:13:28 +0000 (UTC) From: Laszlo Ersek To: Hao Wu , edk2-devel@lists.01.org Cc: Jordan Justen , David Woodhouse References: <20190403070036.1404-1-hao.a.wu@intel.com> Message-ID: <6c270da7-dd3e-9f6d-f4f0-dcad06fa73a4@redhat.com> Date: Wed, 3 Apr 2019 14:13:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Wed, 03 Apr 2019 12:13:30 +0000 (UTC) Subject: Re: [RFC PATCH v1 0/8] Duplicate 8259/8254 components in OvmfPkg X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Apr 2019 12:13:30 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 04/03/19 14:10, Laszlo Ersek wrote: > On 04/03/19 09:00, Hao Wu wrote: >> This series is also available at: >> https://github.com/hwu25/edk2/tree/ovmf_8259_8254_rfcv1 >> >> >> As a sub-task to remove the IntelFrameworkPkg (BZ-1604), >> >> 8259InterruptControllerDxe driver (PcAtChipsetPkg) >> Legacy8259 protocol (IntelFrameworkPkg) >> 8254TimerDxe driver (PcAtChipsetPkg) >> >> will be removed in the near future. Meanwhile, OVMF will still require >> those components (due to CSM support & HPET emulation stability concern). >> >> Thus, the series will copy the below 8259/8254 components: >> >> A. 8259InterruptControllerDxe driver (PcAtChipsetPkg) >> B. Two 8259 related PCDs (PcAtChipsetPkg) >> C. Legacy8259 protocol (IntelFrameworkPkg) >> D. 8254TimerDxe driver (PcAtChipsetPkg) >> >> in the OvmfPkg to address the above-mentioned issue. >> >> >> Tests done for the proposed series: >> >> A. OvmfPkg build pass for VS2015 & GCC5 tool chains; >> B. Boot to Shell with commands: >> qemu-system-x86_64.exe -pflash \OVMF.fd -debugcon file:boot.log -global isa-debugcon.iobase=0x402 >> qemu-system-x86_64.exe -machine q35 -pflash \OVMF.fd -debugcon file:boot.log -global isa-debugcon.iobase=0x402 >> C. 'stall X' command under Shell to verify the timer is working properly. >> >> >> (Please note that there will be a subsequent patch to remove the 8259/8254 >> components after platforms dropping the dependencies on them.) >> >> Cc: Jordan Justen >> Cc: Laszlo Ersek >> Cc: Ard Biesheuvel >> Cc: David Woodhouse >> Cc: Ray Ni >> >> >> Hao Wu (8): >> OvmfPkg: Copy 8259InterruptControllerDxe driver from PcAtChipsetPkg >> OvmfPkg: Copy Legacy8259 protocol definitions from IntelFrameworkPkg >> OvmfPkg/OvmfPkg.dec: Add 8259-related PCDs in OVMF DEC file >> OvmfPkg/8259InterruptControllerDxe: Update to make it build for OVMF >> OvmfPkg/AcpiPlatformDxe: Consume the 8259 PCD defined in OvmfPkg >> OvmfPkg: Copy 8254TimerDxe driver from PcAtChipsetPkg >> OvmfPkg/8254TimerDxe: Update to make it build for OVMF >> OvmfPkg: Update DSC/FDF files to consume 8259/8254 drivers in OvmfPkg > > While I'm reviewing the patches individually, let me make some general > comments: > > - please don't push the series before April 9th (i.e., before the end of > the file addition/removal freeze due to > ) > > - if/when you push the series, please make sure that *all* files added > (copied) under OvmfPkg get the new license block format, i.e. the SPDX > license identifier only. ... in fact, at that time, the license blocks under the *source* packages (PcAtChipsetPkg and IntelFrameworkPkg) will have been updated, so you will have to redo the copying steps anyway (and you can verify those on your end: "git show --find-copies-harder" should show now modifications as part of the copy operations). Thanks Laszlo