From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5DD0C82009 for ; Fri, 3 Feb 2017 00:13:32 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx16.intmail.prod.int.phx2.redhat.com [10.5.11.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CF0904DAF8; Fri, 3 Feb 2017 08:13:32 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-37.phx2.redhat.com [10.3.116.37]) by smtp.corp.redhat.com (Postfix) with ESMTP id 950C1275003; Fri, 3 Feb 2017 08:13:31 +0000 (UTC) To: "Gao, Liming" , "Ni, Ruiyu" , "edk2-devel@lists.01.org" References: <20170126060927.352436-1-ruiyu.ni@intel.com> <20170126060927.352436-2-ruiyu.ni@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14D6D6239@shsmsx102.ccr.corp.intel.com> Cc: "Fan, Jeff" From: Laszlo Ersek Message-ID: <6c292d21-9327-33cd-62ff-5f5f63cd371d@redhat.com> Date: Fri, 3 Feb 2017 09:13:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14D6D6239@shsmsx102.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.74 on 10.5.11.28 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Fri, 03 Feb 2017 08:13:32 +0000 (UTC) Subject: Re: [PATCH 1/5] MdePkg/Pci22.h: Deprecate out-of-Spec IncompatiblePciDevice macros X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Feb 2017 08:13:32 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 02/03/17 04:38, Gao, Liming wrote: > Ray: > How about wrap them by macro DISABLE_NEW_DEPRECATED_INTERFACES to avoid them be used any more? OvmfPkg uses some of these macros, and also defines DISABLE_NEW_DEPRECATED_INTERFACES. So if the above suggestion is followed, then a conversion patch for OvmfPkg becomes necessary as first step, to the new values. Thanks Laszlo > > Thanks > Liming >> -----Original Message----- >> From: Ni, Ruiyu >> Sent: Thursday, January 26, 2017 2:09 PM >> To: edk2-devel@lists.01.org >> Cc: Gao, Liming ; Fan, Jeff >> Subject: [PATCH 1/5] MdePkg/Pci22.h: Deprecate out-of-Spec >> IncompatiblePciDevice macros >> >> DEVICE_ID_NOCARE is defined as 0xFFFF but Spec says (UINT64) -1 >> should be used to match any VendorId/DeviceId/RevisionId/ >> SubsystemVendorId/SubsystemDeviceId. >> >> PCI_BAR_OLD_ALIGN/PCI_BAR_EVEN_ALIGN/PCI_BAR_SQUAD_ALIGN/ >> PCI_BAR_DQUAD_ALIGN are defined but Spec doesn't have such >> definitions. >> >> PCI_BAR_ALL is defined as 0xFF but Spec says (UINT64) -1 should be >> used to match all BARs. >> >> All of the above macros are marked as deprecated. >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Ruiyu Ni >> Cc: Liming Gao >> Cc: Jeff Fan >> --- >> MdePkg/Include/IndustryStandard/Pci22.h | 16 ++++++++++------ >> 1 file changed, 10 insertions(+), 6 deletions(-) >> >> diff --git a/MdePkg/Include/IndustryStandard/Pci22.h >> b/MdePkg/Include/IndustryStandard/Pci22.h >> index 4cf8389..8f87b04 100644 >> --- a/MdePkg/Include/IndustryStandard/Pci22.h >> +++ b/MdePkg/Include/IndustryStandard/Pci22.h >> @@ -780,14 +780,18 @@ typedef struct { >> /// >> } EFI_PCI_CAPABILITY_HOTPLUG; >> >> -#define DEVICE_ID_NOCARE 0xFFFF >> +/// >> +/// Below macros (till PCI_BAR_ALL) were used by >> EfiIncompatiblePciDeviceSupport Protocol. >> +/// Some of them don't match Spec or are not defined in Spec. Those are >> marked as deprecated. >> +/// >> +#define DEVICE_ID_NOCARE 0xFFFF ///< Deprecated. Value doesn't >> match Spec. >> >> #define PCI_ACPI_UNUSED 0 >> #define PCI_BAR_NOCHANGE 0 >> -#define PCI_BAR_OLD_ALIGN 0xFFFFFFFFFFFFFFFFULL >> -#define PCI_BAR_EVEN_ALIGN 0xFFFFFFFFFFFFFFFEULL >> -#define PCI_BAR_SQUAD_ALIGN 0xFFFFFFFFFFFFFFFDULL >> -#define PCI_BAR_DQUAD_ALIGN 0xFFFFFFFFFFFFFFFCULL >> +#define PCI_BAR_OLD_ALIGN 0xFFFFFFFFFFFFFFFFULL ///< Deprecated. >> Value isn't defined in Spec. >> +#define PCI_BAR_EVEN_ALIGN 0xFFFFFFFFFFFFFFFEULL ///< Deprecated. >> Value isn't defined in Spec. >> +#define PCI_BAR_SQUAD_ALIGN 0xFFFFFFFFFFFFFFFDULL ///< Deprecated. >> Value isn't defined in Spec. >> +#define PCI_BAR_DQUAD_ALIGN 0xFFFFFFFFFFFFFFFCULL ///< Deprecated. >> Value isn't defined in Spec. >> >> #define PCI_BAR_IDX0 0x00 >> #define PCI_BAR_IDX1 0x01 >> @@ -795,7 +799,7 @@ typedef struct { >> #define PCI_BAR_IDX3 0x03 >> #define PCI_BAR_IDX4 0x04 >> #define PCI_BAR_IDX5 0x05 >> -#define PCI_BAR_ALL 0xFF >> +#define PCI_BAR_ALL 0xFF ///< Deprecated. Value doesn't match Spec. >> >> /// >> /// EFI PCI Option ROM definitions >> -- >> 2.9.0.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel >