From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: devel@edk2.groups.io, michael.d.kinney@intel.com
Subject: Re: [edk2-devel] [PATCH v1 1/1] .github/dependabot.yml: Enable dependabot
Date: Fri, 11 Nov 2022 14:10:28 -0500 [thread overview]
Message-ID: <6c2a5423-f40f-7bb1-b540-6f0a7519128d@linux.microsoft.com> (raw)
In-Reply-To: <CO1PR11MB4929C5027174DDEC3BDFD66AD2009@CO1PR11MB4929.namprd11.prod.outlook.com>
I think that process is reasonable and we can discuss further in the
upcoming Tools & CI meeting.
For now, I will leave the v1 patch on the mailing list and keep those
other commits up for reference.
Thanks,
Michael
On 11/11/2022 1:44 PM, Michael D Kinney wrote:
> Hi Michael,
>
> Thanks for the quick investigation.I have reviewed some of the PRs
> generated in your fork by dependabot.The detailed information it
> collects and adds to the PR is really good.
>
> I do notice that some dependencies (such as cmocka) are picking up the
> wrong content.I think this is an issue with the cmocka mirror that needs
> to be fixed.We need to review all the dependencies in edk2 repo and make
> sure all those dependencies are compatible with dependabot before
> activating it.
>
> Given that any developer can submit a PR to run EDK II CI, perhaps we do
> not need to treat dependabot any different.Just keep its default labels
> and do not add a do-not-merge label or special comments from mergify.
>
> Instead, we can depend on EDK II Maintainers to periodically monitor
> dependabot PRs and if there is one edk2 should pick up, the EDK II
> Maintainer that owns the package with the dependency can pull the
> dependebot PR into their fork and update the commit message with
> Signed-off-by and Cc tags for EDK II review and resubmit the PR and send
> email patch reviews.If you think this process is reasonable, then we can
> update the EDK II Development Process for this case for Maintainers.
>
> I think this means your V1 is closer to what we need.
>
> I recommend you bring this topic along with Maintainer process options
> and know edk2 dependabot compatibility issues to the TianoCore Tools/CI
> meeting.
>
> Thanks,
>
> Mike
>
> *From:*devel@edk2.groups.io <devel@edk2.groups.io> *On Behalf Of
> *Michael Kubacki
> *Sent:* Friday, November 11, 2022 7:30 AM
> *To:* Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io
> *Subject:* Re: [edk2-devel] [PATCH v1 1/1] .github/dependabot.yml:
> Enable dependabot
>
> Hi Mike,
>
> It looks like the ability to open draft PRs is not possible at the moment:
> Configure dependabot to create draft PRs · Issue #1291 ·
> dependabot/dependabot-core · GitHub
> <https://github.com/dependabot/dependabot-core/issues/1291>
>
> I could not find an ability for dependabot to leave that comment. Though
> I intentionally tried to keep it very similar in the mergify config file
> to the merge conflict comment action to reduce complexity.
>
> Thanks for the feedback. Please let me know, if we can proceed with v2
> based on these changes.
>
> Regards,
> Michael
>
>
next prev parent reply other threads:[~2022-11-11 19:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 13:46 [PATCH v1 1/1] .github/dependabot.yml: Enable dependabot Michael Kubacki
2022-11-10 16:44 ` [edk2-devel] " Michael D Kinney
2022-11-10 19:52 ` Michael Kubacki
2022-11-10 20:16 ` Michael D Kinney
2022-11-11 15:30 ` Michael Kubacki
2022-11-11 18:44 ` Michael D Kinney
2022-11-11 19:10 ` Michael Kubacki [this message]
2022-11-15 0:47 ` Sean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c2a5423-f40f-7bb1-b540-6f0a7519128d@linux.microsoft.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox