From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail04.groups.io (mail04.groups.io [45.79.224.9]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3D04FAC09DF for ; Mon, 15 Apr 2024 08:21:52 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=gJ0eI0X0HC4DlTPRJDFbzlOIAMfRt5WN9/Ki5j+yebw=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Language; s=20240206; t=1713169311; v=1; b=U6aB33DmhPmVvpM2mHAlqIm8yA8uzZsPMtHFhnnAo+AAIfKfW4wFazu9G/xT/v6H+ZCsPVTo jqUmpUbb4ZVlxIcVEVbyJwHjq+uHOvNkYH4BdkVFcD4uM06R4O/qOcaHqD7CLhh6ApnVwipQWH5 wvuEaox4om/buEHY8nwN8swvsy5j89GhIeL8mw7PlV9v6F53Kc8ZPDXVLucurWDTfkyOwXyjxg7 zhSxPD6gunICz9MksdfI8SJkf3Q64M2e+NFkePyq+IWXkCr2M29AqfPgp7xkQE8EDQvEq9RvbZS vxmQp+QmT3xE3UQ4TD/+/PJLuc8hzEENsySWXK9ofzE2Q== X-Received: by 127.0.0.2 with SMTP id xBBQYY7687511xDFSbHksrJh; Mon, 15 Apr 2024 01:21:51 -0700 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.61]) by mx.groups.io with SMTP id smtpd.web10.16023.1713169310713541395 for ; Mon, 15 Apr 2024 01:21:51 -0700 X-Received: from IA1PR12MB6458.namprd12.prod.outlook.com (2603:10b6:208:3aa::22) by MW4PR12MB6975.namprd12.prod.outlook.com (2603:10b6:303:20a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.50; Mon, 15 Apr 2024 08:21:46 +0000 X-Received: from IA1PR12MB6458.namprd12.prod.outlook.com ([fe80::1a52:ef3a:cf04:e56d]) by IA1PR12MB6458.namprd12.prod.outlook.com ([fe80::1a52:ef3a:cf04:e56d%3]) with mapi id 15.20.7452.049; Mon, 15 Apr 2024 08:21:46 +0000 Message-ID: <6c305037-3dea-4486-913c-eb0ebc69b763@amd.com> Date: Mon, 15 Apr 2024 13:51:38 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH RESEND V4 1/6] MdePkg/Include: Update definitions of SPI related header files To: abner.chang@amd.com, devel@edk2.groups.io Cc: Michael D Kinney , Liming Gao , Zhiguang Liu , Abdul Lateef Attar , Brit Chesley References: <20240404091052.794-1-abner.chang@amd.com> <20240404091052.794-2-abner.chang@amd.com> From: "Abdul Lateef Attar via groups.io" In-Reply-To: <20240404091052.794-2-abner.chang@amd.com> X-ClientProxiedBy: BMXPR01CA0093.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:54::33) To IA1PR12MB6458.namprd12.prod.outlook.com (2603:10b6:208:3aa::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR12MB6458:EE_|MW4PR12MB6975:EE_ X-MS-Office365-Filtering-Correlation-Id: ba9e0e6c-a806-41eb-fd61-08dc5d25173c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: kfjU4qlVRmtr7srvXMyDTLFrIn9lYM+FYTbMvWp79Zx4FYxDDzgXSbSxhtUaa9obtn2ABn8NK4UoZP1H5NZXqnGe9sdc2oJpyWCgNWWij1uNiJSjMMOTxGumP7uNDDiICnw7vFTht/aOafjSVmfmBRehJsMM0XJtpl2MMB762oqx9CRTBxDEFl3Krpl9C8zSvV2dHA40OfEgI31p+S/UDZRMu/cavJ0Hrzfn39C0zQGKFWO3hTNWUlV+pkMC+cRIDDgP2BrrM9vQgnSGpK5wpBUCGfDwdzwjDuVcMO07QGF1Xh0dyh5InlcohU3TeNNqfKO5Pb6kmBkSv6o+NnD42HCM74Lnw2IdUCMhbys/KptV/VxblstpAtybyqSYGkPPPava66quvi5ZFkrIKptMtFOgYrw3TmD7sH8z/hLBq6F7yG6cN0RPw3Caq7bizzxP5BbVxxFkte59GAI8jJBiwwuEG/rac0Lh9GKartFR0akEamFSBA9c/hwDOYkU4XDKLPXEzInfYoDkxi8C9Dsi4AXif6NHYdLf/JT6c9oWCs1X8u32adAbZTiLSr6T8iiBKjlUvTCkDB/qKT/nQ/QZtLAO8o53ghQLwgXatJ69eTIrOngOojUoh2pwmJNmRYWdzkXY3+7DbU5EhYVAtKXSvxyH/vabfLnZiNLrZwfxlC8= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?anM0TEZPenIxVGpqamtEb2VPSEEzOHlNODFzSzZNdkJsL2gwTEZGQ0pJSjdI?= =?utf-8?B?QTRmQlFSWEFsTWpzZ1dBTEttakcyUU1TS0ljQjcyZ3h3ekxzUTFCcHNLMEJJ?= =?utf-8?B?NjU5VWRaNEx1NGFqcnUzMkdURGYrYS9qWkE2Qm9BaTBlRU5UdmdHK25RVVlk?= =?utf-8?B?d0M2TXBKNVhrMG1GdWZXWVVxTmFBZ25qemd0ZGJlSU9UNS9aRHFVRTZZUEND?= =?utf-8?B?Z2FLNHpxeXR3VC93UlAwL2pZQy9KS0M1N1VIWXVpZk9LK3c4bnl4WDhDbVVh?= =?utf-8?B?UlRDUWltVlNESFRhQXRIbzhTYmVseDZMKzBYOGdYQy9YNWdxd3FpalhoeWxG?= =?utf-8?B?ai9qWW9BV29XVHhuRlJJN0VQS0RmRkJsVXZ5OUNHMWhNaHZmWXBnY2pWekN1?= =?utf-8?B?aFNheThidWNYdjdEbmg4WVZNWm4vcW5GekFIb3VZQnUwWTlMOU9nV2dDQ01G?= =?utf-8?B?dk43R0EzdWtxR2pxK1lnSmo4OFdlTTh5T3FDZ0lNRFFLbGNmY3F2U21DN1dP?= =?utf-8?B?ditCVGFLS0ttZGpuUG9MVURyaWU3Vm02eWtEcHNaMUYrbmhieWZ2bmg5SnYw?= =?utf-8?B?ZkNLWnpRQVZoYXpSbm85bUQ4bFNtVHU0RUFXa3lWak1aZ0JKRFRYZzJqSWh2?= =?utf-8?B?T1lrWjJaeDB3VXl4aThVWDcrckZUSnMrdjc2NlMyY29Zd1NVVml1bUwxUWQ5?= =?utf-8?B?NjNsVnNMalNHNXVlUkNEMXQwbTlQcDBQV2ZzaFJpeW5TbnptQzM4NHBVMVZX?= =?utf-8?B?bE1wT09mTXU5QkdoN1JTRGxnZS94cjdXdzRsS0tPWXdwUkhCUUd4NVV5eTZu?= =?utf-8?B?bzZSYTJ2Y0xxdndMNUx1c2lqbVQ0Ry9IZitWMUsrYWFjNC85OXNkb2RYK1VX?= =?utf-8?B?WmtNYTlHL0pOWEN1NXJVeXltK2MyaVU3aW5MOEx5REJ6czhtUTlBWUpFMFE1?= =?utf-8?B?Vk1PdHFNalBaaWl5d0pwZSs4aU5KRUhrRkhmSWRpUFJXcGRiYkVqK3dSejAz?= =?utf-8?B?WW9POHZ3dkN6aGFLRTYzVGxUYlE0Yi85cU1vUERPVmJuWWNHMWpqd0p2T0I3?= =?utf-8?B?MldkWGhGSHRSOWh1M3QzaFFFUlZiUk5jQmF6NGpHejZDUnh2S0FITmJJRDla?= =?utf-8?B?TXU4VU9Va054RnFuTEZaTVFtQ09LYmFSMmVES2tPL1VaSlAzL0J2NGhJMFV4?= =?utf-8?B?aTUraERaaHBWYkhlWllncHFxcVppbHN5MFlEVmJoWFBiRjlGZjBOTFNiWUtS?= =?utf-8?B?WGt6YW40NGw0M00zS0xRN0hFOEwvaTA1dVRyMXFaS2FKUGJlelBvSzdQWXBO?= =?utf-8?B?MncwcWQ5L0NPMUUyeEZMMklId29xWGsyWG9EYXNTVnBURktBRjE5alpqaWVk?= =?utf-8?B?MHBCS0hJM1JhRm5YMm9aUHc5K2VLWHYxaFl4TXJLSXFWR1I2T2tVSnE3bDJZ?= =?utf-8?B?eVNtN1NtVkxzU3ZXU3ZHL2E1eWg4V2ZodkZYTFpaeWU5TStRWWQ0bnFuaVNW?= =?utf-8?B?VkRpSEQrM2RtUml0eDJKRm55dEgwMk9iRWFRam9RME5EZGpZdTlod2ZzUS9z?= =?utf-8?B?Q3FtU0U2ZW5wWDBMNW5kOTAya1BZY1QxcjA5NTZDVDFIbHhHOXdvNks2ZDJD?= =?utf-8?B?V1dBTTBvZkFkTmVXcWp5Q0tWek1qZjZHRE5LR0RWM3FFTFBKZDNkSURBRUZn?= =?utf-8?B?TWVzMW5RRFowMDZxZW1XK1lTVjB2dXdjK2x0eklWSXRrdEtQSGRmVmpBNzVp?= =?utf-8?B?NzBaaWFwRzBLeHpibHl4bHYzRlN5cGtmdDVTeXg3SU9vZERwendRYjgwVWY0?= =?utf-8?B?WkU0VDA0cDVFRlVGcWZPVllxYlN5YTBuZktVc2JJMHI3YnF4UGtMbjJmSVND?= =?utf-8?B?RWQveTdSSXhWeVcwdmJ4V2NYMlQyOUdQZHYrTWdSeklUaFI2cThRMXpFR1Ix?= =?utf-8?B?STBQdTBLRGVWRVlWUmlzVjQ5OUlxdEF1aWU5elhGK3BoRW1RNmF4a0lFU3dX?= =?utf-8?B?NVdVUEZiOTJNTnJTS3VjY2ltQ1JIcHU4Q1lrL2JvTUpkZWU1R2E4cUs0VUFq?= =?utf-8?B?T2ZLUHN5UGFTZkl0aFJwYS9Xdlc2eWE0R1RVR3FtamV2QlVzd0Jqd1JKcE1R?= =?utf-8?Q?QmzB+a3M614ueE6+JmpYNgdya?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: ba9e0e6c-a806-41eb-fd61-08dc5d25173c X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6458.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2024 08:21:46.8053 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZBz4eI9UoXFLfaSVKluyHJ5EWIJTfBqPeUd8FAi6h40FibtkPuyBiSL4p9s5o2DEPcu9Tputxfx9AS9MpXEhLQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6975 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 15 Apr 2024 01:21:51 -0700 Resent-From: AbdulLateef.Attar@amd.com Reply-To: devel@edk2.groups.io,AbdulLateef.Attar@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Q5HbDF0lYhHS15Edx3cHmXRbx7686176AA= Content-Type: multipart/alternative; boundary="------------HHAEvFJMXyTTtRmWaI4DezIf" Content-Language: en-US X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=U6aB33Dm; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.9 as permitted sender) smtp.mailfrom=bounce@groups.io --------------HHAEvFJMXyTTtRmWaI4DezIf Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Reviewed-by: Abdul Lateef Attar On 04-04-2024 14:40, abner.chang@amd.com wrote: > From: abnchang > > BZ#: 4471 > Update definitions according to PI spec 1.8 errata A > > Signed-off-by: Abner Chang > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Abdul Lateef Attar > Cc: Brit Chesley > --- > MdePkg/Include/Protocol/SpiConfiguration.h | 10 +++++++++- > MdePkg/Include/Protocol/SpiHc.h | 16 +++++++++++++++- > MdePkg/Include/Protocol/SpiIo.h | 12 +++++++++++- > 3 files changed, 35 insertions(+), 3 deletions(-) > > diff --git a/MdePkg/Include/Protocol/SpiConfiguration.h b/MdePkg/Include/= Protocol/SpiConfiguration.h > index 3f8fb9ff62c..120b54bbad8 100644 > --- a/MdePkg/Include/Protocol/SpiConfiguration.h > +++ b/MdePkg/Include/Protocol/SpiConfiguration.h > @@ -2,10 +2,11 @@ > This file defines the SPI Configuration Protocol. > =20 > Copyright (c) 2017, Intel Corporation. All rights reserved.
> + Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved. > SPDX-License-Identifier: BSD-2-Clause-Patent > =20 > @par Revision Reference: > - This Protocol was introduced in UEFI PI Specification 1.6. > + This Protocol was introduced in UEFI PI Specification 1.8 A. > =20 > **/ > =20 > @@ -168,6 +169,13 @@ typedef struct _EFI_SPI_BUS { > VOID *ClockParameter; > } EFI_SPI_BUS; > =20 > +/// > +/// Definitions of SPI Part Attributes. > +/// > +#define SPI_PART_SUPPORTS_2_BIT_DATA_BUS_WIDTH BIT0 > +#define SPI_PART_SUPPORTS_4_B1T_DATA_BUS_WIDTH BIT1 > +#define SPI_PART_SUPPORTS_8_B1T_DATA_BUS_WIDTH BIT2 > + > /// > /// The EFI_SPI_PERIPHERAL data structure describes how a specific bloc= k of > /// logic which is connected to the SPI bus. This data structure also s= elects > diff --git a/MdePkg/Include/Protocol/SpiHc.h b/MdePkg/Include/Protocol/Sp= iHc.h > index 30128dd5c4d..354de721606 100644 > --- a/MdePkg/Include/Protocol/SpiHc.h > +++ b/MdePkg/Include/Protocol/SpiHc.h > @@ -2,10 +2,11 @@ > This file defines the SPI Host Controller Protocol. > =20 > Copyright (c) 2017, Intel Corporation. All rights reserved.
> + Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved. > SPDX-License-Identifier: BSD-2-Clause-Patent > =20 > @par Revision Reference: > - This Protocol was introduced in UEFI PI Specification 1.6. > + This Protocol was introduced in UEFI PI Specification 1.8 A. > =20 > **/ > =20 > @@ -121,6 +122,19 @@ typedef EFI_STATUS > IN EFI_SPI_BUS_TRANSACTION *BusTransaction > ); > =20 > +/// > +/// Definitions of SPI Host Controller Attributes. > +/// > +#define HC_SUPPORTS_WRITE_ONLY_OPERATIONS BIT0 > +#define HC_SUPPORTS_READ_ONLY_OPERATIONS BIT1 > +#define HC_SUPPORTS_WRITE_THEN_READ_OPERATIONS BIT2 > +#define HC_TX_FRAME_IN_MOST_SIGNIFICANT_BITS BIT3 > +#define HC_RX_FRAME_IN_MOST_SIGNIFICANT_BITS BIT4 > +#define HC_SUPPORTS_2_BIT_DATA_BUS_WIDTH BIT5 > +#define HC_SUPPORTS_4_BIT_DATA_BUS_WIDTH BIT6 > +#define HC_SUPPORTS_8_BIT_DATA_BUS_WIDTH BIT7 > +#define HC_TRANSFER_SIZE_INCLUDES_OPCODE BIT8 > +#define HC_TRANSFER_SIZE_INCLUDES_ADDRESS BIT9 > /// > /// Support a SPI data transaction between the SPI controller and a SPI= chip. > /// > diff --git a/MdePkg/Include/Protocol/SpiIo.h b/MdePkg/Include/Protocol/Sp= iIo.h > index b4fc5e03b88..2c95a375a20 100644 > --- a/MdePkg/Include/Protocol/SpiIo.h > +++ b/MdePkg/Include/Protocol/SpiIo.h > @@ -2,10 +2,11 @@ > This file defines the SPI I/O Protocol. > =20 > Copyright (c) 2017, Intel Corporation. All rights reserved.
> + Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved. > SPDX-License-Identifier: BSD-2-Clause-Patent > =20 > @par Revision Reference: > - This Protocol was introduced in UEFI PI Specification 1.6. > + This Protocol was introduced in UEFI PI Specification 1.8 A. > =20 > **/ > =20 > @@ -223,6 +224,15 @@ typedef struct _EFI_SPI_BUS_TRANSACTION { > UINT8 *ReadBuffer; > } EFI_SPI_BUS_TRANSACTION; > =20 > +/// > +/// Definitions of SPI I/O Attributes. > +/// > +#define SPI_IO_SUPPORTS_2_BIT_DATA_BUS_WIDTH BIT0 > +#define SPI_IO_SUPPORTS_4_BIT_DATA_BUS_WIDTH BIT1 > +#define SPI_IO_SUPPORTS_8_BIT_DATA_BUS_WIDTH BIT2 > +#define SPI_IO_TRANSFER_SIZE_INCLUDES_OPCODE BIT3 > +#define SPI_IO_TRANSFER_SIZE_INCLUDES_ADDRESS BIT4 > + > /// > /// Support managed SPI data transactions between the SPI controller an= d a SPI > /// chip. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117769): https://edk2.groups.io/g/devel/message/117769 Mute This Topic: https://groups.io/mt/105325625/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --------------HHAEvFJMXyTTtRmWaI4DezIf Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Reviewed-by: Abdul Lateef Atta= r <a= bdattar@amd.com>

On 04-04-2024 14:40, abner.chang@amd.com wrote:
From: abnchang <abnchang@amd.com&g=
t;

BZ#: 4471
Update definitions according to PI spec 1.8 errata A

Signed-off-by: Abner Chang <abner.chang@amd.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Cc: Abdul Lateef Attar <abdattar@amd.com>
Cc: Brit Chesley <brit.chesley@amd.com>
---
 MdePkg/Include/Protocol/SpiConfiguration.h | 10 +++++++++-
 MdePkg/Include/Protocol/SpiHc.h            | 16 +++++++++++++++-
 MdePkg/Include/Protocol/SpiIo.h            | 12 +++++++++++-
 3 files changed, 35 insertions(+), 3 deletions(-)

diff --git a/MdePkg/Include/Protocol/SpiConfiguration.h b/MdePkg/Include/Pr=
otocol/SpiConfiguration.h
index 3f8fb9ff62c..120b54bbad8 100644
--- a/MdePkg/Include/Protocol/SpiConfiguration.h
+++ b/MdePkg/Include/Protocol/SpiConfiguration.h
@@ -2,10 +2,11 @@
   This file defines the SPI Configuration Protocol.
=20
   Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
+  Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.
   SPDX-License-Identifier: BSD-2-Clause-Patent
=20
   @par Revision Reference:
-    This Protocol was introduced in UEFI PI Specification 1.6.
+    This Protocol was introduced in UEFI PI Specification 1.8 A.
=20
 **/
=20
@@ -168,6 +169,13 @@ typedef struct _EFI_SPI_BUS {
   VOID    *ClockParameter;
 } EFI_SPI_BUS;
=20
+///
+/// Definitions of SPI Part Attributes.
+///
+#define SPI_PART_SUPPORTS_2_BIT_DATA_BUS_WIDTH  BIT0
+#define SPI_PART_SUPPORTS_4_B1T_DATA_BUS_WIDTH  BIT1
+#define SPI_PART_SUPPORTS_8_B1T_DATA_BUS_WIDTH  BIT2
+
 ///
 /// The EFI_SPI_PERIPHERAL data structure describes how a specific block o=
f
 /// logic which is connected to the SPI bus. This data structure also sele=
cts
diff --git a/MdePkg/Include/Protocol/SpiHc.h b/MdePkg/Include/Protocol/SpiH=
c.h
index 30128dd5c4d..354de721606 100644
--- a/MdePkg/Include/Protocol/SpiHc.h
+++ b/MdePkg/Include/Protocol/SpiHc.h
@@ -2,10 +2,11 @@
   This file defines the SPI Host Controller Protocol.
=20
   Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
+  Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.
   SPDX-License-Identifier: BSD-2-Clause-Patent
=20
   @par Revision Reference:
-    This Protocol was introduced in UEFI PI Specification 1.6.
+    This Protocol was introduced in UEFI PI Specification 1.8 A.
=20
 **/
=20
@@ -121,6 +122,19 @@ typedef EFI_STATUS
   IN EFI_SPI_BUS_TRANSACTION    *BusTransaction
   );
=20
+///
+/// Definitions of SPI Host Controller Attributes.
+///
+#define HC_SUPPORTS_WRITE_ONLY_OPERATIONS       BIT0
+#define HC_SUPPORTS_READ_ONLY_OPERATIONS        BIT1
+#define HC_SUPPORTS_WRITE_THEN_READ_OPERATIONS  BIT2
+#define HC_TX_FRAME_IN_MOST_SIGNIFICANT_BITS    BIT3
+#define HC_RX_FRAME_IN_MOST_SIGNIFICANT_BITS    BIT4
+#define HC_SUPPORTS_2_BIT_DATA_BUS_WIDTH        BIT5
+#define HC_SUPPORTS_4_BIT_DATA_BUS_WIDTH        BIT6
+#define HC_SUPPORTS_8_BIT_DATA_BUS_WIDTH        BIT7
+#define HC_TRANSFER_SIZE_INCLUDES_OPCODE        BIT8
+#define HC_TRANSFER_SIZE_INCLUDES_ADDRESS       BIT9
 ///
 /// Support a SPI data transaction between the SPI controller and a SPI ch=
ip.
 ///
diff --git a/MdePkg/Include/Protocol/SpiIo.h b/MdePkg/Include/Protocol/SpiI=
o.h
index b4fc5e03b88..2c95a375a20 100644
--- a/MdePkg/Include/Protocol/SpiIo.h
+++ b/MdePkg/Include/Protocol/SpiIo.h
@@ -2,10 +2,11 @@
   This file defines the SPI I/O Protocol.
=20
   Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
+  Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.
   SPDX-License-Identifier: BSD-2-Clause-Patent
=20
   @par Revision Reference:
-    This Protocol was introduced in UEFI PI Specification 1.6.
+    This Protocol was introduced in UEFI PI Specification 1.8 A.
=20
 **/
=20
@@ -223,6 +224,15 @@ typedef struct _EFI_SPI_BUS_TRANSACTION {
   UINT8                       *ReadBuffer;
 } EFI_SPI_BUS_TRANSACTION;
=20
+///
+/// Definitions of SPI I/O Attributes.
+///
+#define SPI_IO_SUPPORTS_2_BIT_DATA_BUS_WIDTH   BIT0
+#define SPI_IO_SUPPORTS_4_BIT_DATA_BUS_WIDTH   BIT1
+#define SPI_IO_SUPPORTS_8_BIT_DATA_BUS_WIDTH   BIT2
+#define SPI_IO_TRANSFER_SIZE_INCLUDES_OPCODE   BIT3
+#define SPI_IO_TRANSFER_SIZE_INCLUDES_ADDRESS  BIT4
+
 ///
 /// Support managed SPI data transactions between the SPI controller and a=
 SPI
 /// chip.
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#117769) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--------------HHAEvFJMXyTTtRmWaI4DezIf--