Re: Patch List for 202002 stable tag

["Gao, Zhichao" <zhichao.gao@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 10843 bytes --]

Already add my comments in the BZ link. I agree it is a bug fix.

Thanks,
Zhichao

From: Gao, Liming <liming.gao@intel.com>
Sent: Thursday, February 20, 2020 9:17 AM
To: vit9696 <vit9696@protonmail.com>
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Laszlo Ersek <lersek@redhat.com>; Guptha, Soumya K <soumya.k.guptha@intel.com>; leif@nuviainc.com; afish@apple.com; devel@edk2.groups.io; Marvin Häuser <marvin.haeuser@outlook.com>; Ni, Ray <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>
Subject: RE: Patch List for 202002 stable tag

Vitaly:
  I add my comments.

Zhichao and Ray:
   Can you give your opinion for BZ https://bugzilla.tianocore.org/show_bug.cgi?id=2510? Is it a bug fix or feature enhancement?

Thanks
Liming
From: vit9696 <vit9696@protonmail.com<mailto:vit9696@protonmail.com>>
Sent: Thursday, February 20, 2020 2:09 AM
To: Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>
Cc: Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Laszlo Ersek <lersek@redhat.com<mailto:lersek@redhat.com>>; Guptha, Soumya K <soumya.k.guptha@intel.com<mailto:soumya.k.guptha@intel.com>>; leif@nuviainc.com<mailto:leif@nuviainc.com>; afish@apple.com<mailto:afish@apple.com>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Marvin Häuser <marvin.haeuser@outlook.com<mailto:marvin.haeuser@outlook.com>>
Subject: Re: Patch List for 202002 stable tag

Liming,

Thanks for pinging me about this!

With the PCD[1][2] I fully agree. The fact that it did not manage to land is mainly due to a sudden discussion that arose after complete silence for almost half a year, which was sort of unexpected. I will use this message as a suggestion to include this change as one of the primary goals for 202005 and kindly ask others to help to agree on the actual implementation. This bug strongly concerns us and we believe the fact that it does not (yet) cause issues to everyone is mainly coincidence.

[Liming] You can also present the topic in Tiano Design meeting to collect the feedback. Ni, Ray is the meeting host. You can send the topic to him.

With the Shell patch, the fact that I cannot enter upper case letters or use hotkeys in the editor sounds like a bug to me. The way the actual commit message is written reflects the change of the internal logic in the codebase (it adds support of specific behaviour handling on the target). In my opinion, it should not necessarily include the word «Fix» to be qualified as a bugfix, this is what bugzilla is for.

[Liming] If this fix is the bug, I agree it follows the process to catch this stable tag. I include ShellPkg maintainers (Ray Ni and Zhichao Gao) to give the opinion for the bug or not.

I am personally ok with deferring it to a next stable tag, but if the reasoning for this is «Feature planning freeze» dates, they do not strictly apply due to the reasons I stated above. So far the patch received only one review comment, which in fact was due to a minor misinterpretation. We also did some fairly extensive testing on our side before the submission (that’s why it actually took us a few more days). Unless the team has a lot of important work for the release, we can postpone the merge, otherwise I think it should be safe to merge this.

Best wishes,
Vitaly

[1] https://bugzilla.tianocore.org/show_bug.cgi?id=2054
[2] https://edk2.groups.io/g/devel/topic/69401948


19 февр. 2020 г., в 18:39, Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>> написал(а):


Mike and Laszlo:
 Thanks for your comments.

Vitaly:
 You request below two patches to catch 202002 stable tag. I agree with Mike and Laszlo comments. They are not ready to catch this stable tag. The first one is under discussion. The second one is like the enhancement or feature instead of the bug fix. It is submitted after Feb 7th Feature Planning Freeze. So, I suggest to defer them to next stable tag 202005.

https://edk2.groups.io/g/devel/topic/patch_v3_0_1_add_pcd_to/69401948 [PATCH v3 0/1] Add PCD to disable safe string constraint assertions (solution under discussion)
https://edk2.groups.io/g/devel/message/54122 [PATCH 1/1] ShellPkg: Add support for input with separately reported modifiers (under review, is this a feature or bug in the discussion)

Thanks
Liming
-----Original Message-----
From: Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>
Sent: Wednesday, February 19, 2020 4:43 AM
To: Laszlo Ersek <lersek@redhat.com<mailto:lersek@redhat.com>>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Guptha, Soumya K <soumya.k.guptha@intel.com<mailto:soumya.k.guptha@intel.com>>;
leif@nuviainc.com<mailto:leif@nuviainc.com>; afish@apple.com<mailto:afish@apple.com>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>
Cc: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Subject: RE: Patch List for 202002 stable tag

Hi Laszlo,

I agree with your assessments.

One comment below.

Mike

-----Original Message-----
From: Laszlo Ersek <lersek@redhat.com<mailto:lersek@redhat.com>>
Sent: Tuesday, February 18, 2020 12:04 PM
To: Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Guptha, Soumya
K <soumya.k.guptha@intel.com<mailto:soumya.k.guptha@intel.com>>; Kinney, Michael D
<michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; leif@nuviainc.com<mailto:leif@nuviainc.com>;
afish@apple.com<mailto:afish@apple.com>
Cc: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Subject: Re: Patch List for 202002 stable tag

On 02/18/20 15:08, Gao, Liming wrote:
Hi Stewards and all:
 I collect current patch lists in devel mail list.
Those patch
 contributors request to add them for 201902 stable
tag. Because we
 have enter into Soft Feature Freeze, I want to
collect your feedback
 for them. If any patches are missing, please reply
this mail to add
 them.

Feature List (under review):

According to
<https://github.com/tianocore/tianocore.github.io/wiki/
SoftFeatureFreeze<https://github.com/tianocore/tianocore.github.io/wiki/%0bSoftFeatureFreeze>>,
features can be merged during the SFF if their review
completed before
the SFF.

The SFF date is 2020-02-14 00:00:00 UTC-8, per
<https://github.com/tianocore/tianocore.github.io/wiki/
EDK-II-Release-Planning<https://github.com/tianocore/tianocore.github.io/wiki/%0bEDK-II-Release-Planning>>.
For me (in CET = UTC+1), that makes the deadline 2020-
02-14 09:00:00
CET.


https://edk2.groups.io/g/devel/topic/patch_v3_0_1_add_p
cd_to/69401948
[PATCH v3 0/1] Add PCD to disable safe string
constraint assertions
(solution under discussion)

Posted on 2020-01-03. Review doesn't appear complete.
Technically
speaking, it has missed edk2-stable202002.

There were two large gaps in the review process, namely
between these
messages:

- https://edk2.groups.io/g/devel/message/53026 [2020-
01-08]
- https://edk2.groups.io/g/devel/message/53485 [2020-
01-27]
- https://edk2.groups.io/g/devel/message/54133 [2020-
02-10]

If review seems stuck, it's advisable to ping once per
week, or a bit
more frequently. Two weeks ore more between pings is
way too long.

https://edk2.groups.io/g/devel/message/54122 [PATCH
1/1] ShellPkg: Add
support for input with separately reported modifiers
(under review, is
this a feature or bug in the disucssion)

The subject starts with "Add support for...", so it's a
new feature, or
at least a feature-enablement.

Posted on 2020-02-10. Has not been reviewed yet,
AFAICT. Same situation
as above. (Missed edk2-stable202002, technically
speaking.)

Note: I don't have a personal preference either way.
I'm just pointing
out what the SFF definition formally dictates, in my
interpretation.

If we want to extend the freeze dates, I won't object.

Bug List (reviewed):
https://edk2.groups.io/g/devel/message/54416 [PATCH
v2 00/10] Fix
false negative issue in
DxeImageVerificationHandler(CVE-2019-14575)

Clearly a bug fix; it could go in even during the HFF
<https://github.com/tianocore/tianocore.github.io/wiki/
HardFeatureFreeze<https://github.com/tianocore/tianocore.github.io/wiki/%0bHardFeatureFreeze>>.

https://edk2.groups.io/g/devel/message/54523 [PATCH
v1][edk2-stable202002] MdeModulePkg/SdMmcPciHcDxe:
Fix double PciIo
Unmap in TRB creation (CVE-2019-14587)

Ditto.

https://edk2.groups.io/g/devel/message/54510 [PATCH
v6 0/2]
Enhancement and Fixes to BaseHashApiLib

Hm. I feel like I need some convincing that patch#1 --
"CryptoPkg/BaseHashApiLib: Align BaseHashApiLib with
TPM 2.0
Implementation" -- is *also* a bugfix (like patch#2).

That question matters because the reviews:

- https://edk2.groups.io/g/devel/message/54513
- https://edk2.groups.io/g/devel/message/54567

were not posted before the SFF.

... I guess it's OK.

The description of the bug does not emphasis that
this really is a bug fix.  There were additional
review comments from the CryptoPkg reviewers after
the initial review/commit of this feature.  These
changes address that feedback.  The alignment with
TPM 2.0 is to use an existing set of defines for
the hash algorithms instead of define yet another
set of defines.  Details in this thread:

https://edk2.groups.io/g/devel/topic/70960524#53733



https://edk2.groups.io/g/devel/message/53703 [PATCH
V2] UefiCpuPkg
RegisterCpuFeaturesLib: Match data type and format
specifier

Even if this were a feature, it could go in; the review
was posted in
time:
- https://edk2.groups.io/g/devel/message/53803

In fact I don't understand why it hasn't been merged
for more than a
week now!

https://edk2.groups.io/g/devel/message/53577 [PATCH
v1 1/1] ShellPkg:
acpiview: Remove duplicate ACPI structure size
definitions

Approved in time, regardless of bugfix vs. feature.
Should go in.

https://edk2.groups.io/g/devel/message/54192 [PATCH
v2 1/1] ShellPkg:
acpiview: Validate ACPI table 'Length' field

The review was posted past the SFF, but I agree this
looks like a
bugfix, so should be OK. (Supplying missing input
sanitization is
arguably a fix.)


Bug List (under review)
https://edk2.groups.io/g/devel/message/54361 [PATCH
1/1]
NetworkPkg/ArpDxe: Recycle invalid ARP packets(CVE-
2019-14559)
https://edk2.groups.io/g/devel/message/54569 [PATCH
v3]
NetworkPkg/Ip4Dxe: Check the received package length
(CVE-2019-14559)

CVE fixes can clearly go in during the HFF too.

https://edk2.groups.io/g/devel/message/54448 [PATCH
v1 1/1] ShellPkg:
acpiview: Prevent infinite loop if structure length
is 0

Similar to "ShellPkg: acpiview: Validate ACPI table
'Length' field";
should be OK.


Just my opinion, of course.

Thanks
Laszlo



[-- Attachment #2: Type: text/html, Size: 23821 bytes --]