From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.100]) by mx.groups.io with SMTP id smtpd.web11.13709.1682573898848965359 for ; Wed, 26 Apr 2023 22:38:19 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="no key for verify" header.i=@amperemail.onmicrosoft.com header.s=selector1-amperemail-onmicrosoft-com header.b=v2JSSxNQ; spf=pass (domain: os.amperecomputing.com, ip: 40.107.236.100, mailfrom: nhi@os.amperecomputing.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hkeZu4wC9eWMAgOfivSNtc57KeXD3ojF6xRPioKMMbrKZHb1pSYYJirJ+7VgsGZYlh1xtfPOucNSWOSr/2+r3iKJSlfz6EKDVI/eXgFTATOsZqxp/gFdKXp7RNL3+Cf14hoswqxAh+dkOxGCQLysDd/a9WHS285Bgrpl5VosJBswjzHXVMRFTo6wr40rNlyjccCFEE1NXAOTUZsMKKApc/cLcWHi50YQtV4/Z+XjChfTq9xmdHW2cdkDlIBHJPL5BFjmC7FzGQoLPD60OqjMiSRNhxuaSnEv9pxwiZI60GuE3D7L59ghFlqQcdeUKxc0tSUl99eur6oxnS+oUl549Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3B7iTeEqxqVMiUBLBz+HKNNxjOCrw1M+j2cD5dVdBS0=; b=L/xakrfNKuORz43GBULi8gN0AaiXT+10gnlDZztQv0liuVx+KhXyj8/DE7e8VVDr/6OvSdxq3NWGyvT+r+5SdeSioJuA6dKhD+YgIL4bYA4ijq4MBIQaNk8Zx6GByfYn2tDYR40nMd+9UOtPnbF4JfmvkFJY4oOSX+9A4KWhJ4ZRSl4xR6s6YT5ilf1AI7NSOCIxj1vCUMDGyW7rG3SmRtW5pIP+Xm1cbs0tCZbTypPcMIvukTRzT24KyfcpKWtei9gJtTsDBeogXLF8rH2j9iC1WoKa8QzZ3pe8No1Rsee2EkvPv3ERRV/sCXBD2VBk9xAeYlTmWoVj8Xfg3WJF7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=amperemail.onmicrosoft.com; dkim=pass header.d=amperemail.onmicrosoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amperemail.onmicrosoft.com; s=selector1-amperemail-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3B7iTeEqxqVMiUBLBz+HKNNxjOCrw1M+j2cD5dVdBS0=; b=v2JSSxNQ+tNkE/VD3PiMLJDgfB60eaA1+cuAAo84dwHQXdBaedCJFQQTu8bgoHnnq+uMUbKCmOvMHWAkTPLJO0rDuQjYV4GJ3IG1tzr6YxqySx1YWlwkNHVlQ/9UBqJP7HoaErQA+gu+hLvl2vhJ7tZpcNgoga4mfYHFtxcpEGI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amperemail.onmicrosoft.com; Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by DM5PR0101MB2970.prod.exchangelabs.com (2603:10b6:4:2d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.20; Thu, 27 Apr 2023 05:38:12 +0000 Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::4904:fc7d:35e6:f99]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::4904:fc7d:35e6:f99%3]) with mapi id 15.20.6340.022; Thu, 27 Apr 2023 05:38:12 +0000 Message-ID: <6cdc4e11-bda6-976d-e18a-45c734fef2b2@amperemail.onmicrosoft.com> Date: Thu, 27 Apr 2023 12:38:01 +0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [edk2-devel] [PATCH 1/1] SecurityPkg/DxeImageVerificationLib: Add AUTH_SIG_NOT_FOUND Action To: "Xu, Min M" , "devel@edk2.groups.io" , "nhi@os.amperecomputing.com" , "Yao, Jiewen" , "Wang, Jian J" , gaoliming@byosoft.com.cn Cc: "patches@amperecomputing.com" References: <20230412092149.138221-1-nhi@os.amperecomputing.com> From: "Nhi Pham" In-Reply-To: X-ClientProxiedBy: SI1PR02CA0059.apcprd02.prod.outlook.com (2603:1096:4:1f5::19) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) Return-Path: nhi@os.amperecomputing.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB7287:EE_|DM5PR0101MB2970:EE_ X-MS-Office365-Filtering-Correlation-Id: 84af0cfe-adc9-401a-b1c9-08db46e196ff X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gR0UN4viVkQhMjXH+7cUiT16aAXjMNZUziKGGoLOQYqQIAG9lN3kCq6mPzchwtXDndzoJ2nxTbR0oj+F6BYpqKlHNEOHORbsEo59Wuky5SSJ/QioIIK0DKsB3vNACmQDL7Q/nhwxCLghbvzZ5PBIZNcw724qk+GnnCFbJFrv3lF8DzpHpgvrjvbNHXKqSrpfEOAVrhVM8bY0iJ12JQV+uZnBC2Q/QNhf+8Yni9vHMsPbqxBoH9uyeKisQFcKdwfHIEGw5ZFL+cMvdauOtNBX41huWb+5WFC1UeQGn833U1ENlaAqOZ048fMhnih8AijjTXUgG1jiHG3uXDAHDnr9utCtmZQVMNqDYuuyVlH9jyp0Wg/OeJ248AXEfhJOb225GVfZsYUC+DPiNlrmSAjWDJXedTMAZriouxrYzSoWr87K/oKgXOciF8BlCdre0vJDlbe9NLBOPuaRHJJcQ0DP9jFizlUI/OeSKsMv6NIz9RCPL/5XKzKlrg4WDNtufalRE1ywEZCTFIy9rLJk/hwW20SDKqSypIZJqnHgqOao0cFV2EduwWxrvSA0xYw48bRtvKD9OwFkyV7aaol/Q5YjuCT65tblcXNjx2mA746UphU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR01MB7287.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(366004)(346002)(136003)(39850400004)(396003)(451199021)(6506007)(53546011)(6512007)(186003)(26005)(42882007)(966005)(66556008)(66476007)(15650500001)(4326008)(107886003)(5660300002)(41300700001)(316002)(66946007)(6666004)(6486002)(31686004)(83380400001)(2616005)(31696002)(83170400001)(110136005)(8676002)(2906002)(8936002)(478600001)(38100700002)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZkYwZEp0eDlGc0pZZkcyK3hsRklKZFVpMndTTzJ1OVIzVkZtcXgzRFhxRWdx?= =?utf-8?B?SnhMY05jcDd3OWJCaXhRU3pMeXNoQmpJVXkza2I0M1lrQldBMVBpWmg5cG5T?= =?utf-8?B?aFhIckZaTWdPeDBrMXR5WjFNWllWTlhiNjI3YmNGN0JMVkowQ2xYekxjcTY3?= =?utf-8?B?RHpNdmJuamlvMmJkSVg1RlBjZW9DYnliMVBHdElCVjh5R09HV2RBNGxEVFFs?= =?utf-8?B?MytOcWkrYW56QkdYaGRaUkdxdXFFOWtxZ0tPeGhLcGlRNDBjOUZ0YWxSOTFL?= =?utf-8?B?Z24zMFYvSjg4WTU2ZTZJL3RPZ0Z5bVRLK2UzMko4ZHRZb2N5dlVHdzN6YmlZ?= =?utf-8?B?SS84MjRYV3R3ZmQ1R2JvcHNhRkhqK3lwUzM0a2p3SUNyb3g0cENDMWxCcmV4?= =?utf-8?B?cFgzSUc1bDNLZFNvRUFQOVZMTFNscGVjVC9ZSFlwcXFZSDZjTm01alFTdlVy?= =?utf-8?B?K0c5ak93aGsxSDdDQU9jb3l1NngxNFpPVUp2dm9BdDUzRUl3MHEraURoUVIw?= =?utf-8?B?ZjY2aE5VMW83WExtMllHdEpKYVlZTXQzTjJQSm5SbFRlRmQyRUd2U1pNem4r?= =?utf-8?B?ODk1ckJLd3RORlZMU2xaZ1I3YzJidzNJbHVuajRTS1NSYStvaCtVZS9sYVMv?= =?utf-8?B?TG5WVGtUcFFIK1hGSkhjMlA1RDhkSVZjV2dUVVpQR1BPbTIrUjFqVE1PVjh5?= =?utf-8?B?OWhKM2FTMWNlN3VLUTBsR2k3Y0NKa2pPcmJpT0RodHlmRXF2K21VMjgxV3I2?= =?utf-8?B?cTVCdEZWV0ppZ3VwWEFUdzBlSG1uUWRqOXZPUFV6ckJndUpuTjFtUFJhNmpi?= =?utf-8?B?YTU2TldyMzhwbHduYkdIYTRnREJrNStGTnpDcTRPOEh0cm9aY1NRSjlZQzRX?= =?utf-8?B?MHE5UlRXeDlqQS9iU0UrdDJER0JBejZVeUhpK1hRZzlqYU5zTWx3UDRDVlJ5?= =?utf-8?B?WkpMdWtUc3crZHlQdUJJQWZJeWxOaDRScCsyMW4zeWdYWXJSSkVkQlZQUURq?= =?utf-8?B?bkVPV281SFJkcThzbXdrQWhiUG94UWNPVjNPdXVLNkhWcVdtUVFiQ1hnSE00?= =?utf-8?B?K2d5KzduUlJXOGN3SzBaQlQwM2dyNjBNYW44WkdhdEp5QzJHdHB4TVVTeE40?= =?utf-8?B?SHg3RHZZejB2YXdwT0dHY3hvcS92K1Fhcm9JYitHQnJmSnV1OTd6SG5ZNG1q?= =?utf-8?B?UHBJYVFhdmpyRzY1T1BMTTF6eVcxTlo5cEc2N2RSaXhBR24vNGdtTmlvV00y?= =?utf-8?B?K2VJcXNvRjBSR29JNmtmVkhsalc3L2dKNmxrRzNCVVpYVTdDTHNlQXM1VW1S?= =?utf-8?B?RVBFQi9vWG0zaXl5RDA0VS9JRlF4YXBnRXF1cmMvdjlQZ2lzVmp1UUh2OC9D?= =?utf-8?B?alVtSFVPUUxVKzVuaTR2TStIYi9zNmpCWWNLaGMvdTZYaW9RR3hWVDFRb1Js?= =?utf-8?B?Q2xBQmpXcExvTzJKbCtWM0xpcWdnc0IzRU1vRkNuZWMyK0ZrY2ROR2tqSW4w?= =?utf-8?B?NXFkNVF1RldHdDNhUEVEMjBFRmt6V3o2UGM4dmFVOVFOeU1VWmg2RHovc0Vz?= =?utf-8?B?Nm45eUwyZFRtUGtXM1ZOTHpQNHVFb0xNWUhzNVBtcUdibGY0VlliSDVVQUFx?= =?utf-8?B?VUNsd1VDYzdqTTQ0eWhJUzlhR0Nib01kN1hIcUduSDIwTGU4a3RFc1h2b0ov?= =?utf-8?B?K1krYmlJN3EzeGkvN0N3cU13d0lkT09PME9VVTgzUUY0VlhoTVk5eEpCbnpi?= =?utf-8?B?eGVmNXZDaW5iYnVqcUlpVzdnN0ZtOGFSa3Z6ZVY5anF2QW1wSlhtSHVraUF4?= =?utf-8?B?TVV2UTdsRXlPeTY2OWFrMHBWQTdIQm5HbkpGZzM2UTVTL1UrcHd5K0d2dU1o?= =?utf-8?B?azhCS2MyVHRDRWJ0NGl3YVBPVkFqNnkwZGJhVDc1YThpS3g3RXRFQW1yVUdE?= =?utf-8?B?NG9lZ0pKeWtXVHpzRVQvb0x5OXU4YTRKUG96cnB6TTBSa1dnZzdCbCs1bTNh?= =?utf-8?B?REVobW5VWkpIWmlvNVY4cDJ6THlLWFRjMDNCYjN5MCt6NW5QS2xaY24zcjg2?= =?utf-8?B?U2xNb2JleDl6WWFFamd0cGJCSVpiQmZDSFNGR3hZWUNhVnE0RXZwck1RaTBT?= =?utf-8?B?QjhRMHZJbW1MTmYrMGdMekFxSkgwUUxDejQ1bmJEKzJhK0cvWTFmNG1CQkJC?= =?utf-8?Q?fi+Dt6JF6i8BRXJuG+jYp3o=3D?= X-OriginatorOrg: amperemail.onmicrosoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 84af0cfe-adc9-401a-b1c9-08db46e196ff X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2023 05:38:12.4507 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Iz7ICkehxWQRB80r1Mz1744sw8wDYBfXtn1AKuskyDkNAqyhp1PMKrEMn9Ro7GV/Ggk4eNiqd2sezOiX7z2FVCkYdLzUxJrdw2KyrQ/ho5U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR0101MB2970 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Thanks Min. Could you help merge this patch to edk2? Regards, Nhi On 4/26/2023 2:54 PM, Xu, Min M wrote: > It's good to me. > Reviewed-by: Min Xu > > Thanks > >> -----Original Message----- >> From: Nhi Pham >> Sent: Thursday, April 20, 2023 11:49 AM >> To: Xu, Min M ; devel@edk2.groups.io; >> nhi@os.amperecomputing.com; Yao, Jiewen ; Wang, >> Jian J >> Cc: patches@amperecomputing.com >> Subject: Re: [edk2-devel] [PATCH 1/1] SecurityPkg/DxeImageVerificationLib: >> Add AUTH_SIG_NOT_FOUND Action >> >> Hi Min, >> >> This SEI test passes: >> >> SecureBoot - TestImage2.bin in Image Execution Info Table with >> SIG_NOT_FOUND. -- PASS >> 00C3C2F2-39D5-4D35-B7E7-587CA0F3CB75 >> SctPkg/TestCase/UEFI/EFI/RuntimeServices/SecureBoot/BlackBoxTest/ImageLoa >> dingBBTest.c:1103:Status >> - Success >> >> The test image binary is different to the one in the commit message due to some >> bug fixes in the SEI test suite. The right test case to catch this bug is 00C3C2F2- >> 39D5-4D35-B7E7-587CA0F3CB75 >> >> You can check the test code at >> https://github.com/ARM-software/bbr-acs/blob/main/bbsr/sct- >> tests/SecureBoot/BlackBoxTest/ImageLoadingBBTest.c >> >> Thanks, >> >> Nhi >> >> On 4/19/2023 6:20 AM, Xu, Min M wrote: >>> On Friday, April 14, 2023 1:18 PM, Nhi Pham wrote: >>>> Hi, >>>> >>>> Ping for reviewing. >>>> >>>> Let me know if I need anything for this patch. >>> Do you test the change and what's the test result? Can you provide the >> validation result? >>> Thanks >>> Min