From: "Laszlo Ersek" <lersek@redhat.com>
To: Bret Barkelew <Bret.Barkelew@microsoft.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"liming.gao" <liming.gao@intel.com>,
"announce@edk2.groups.io" <announce@edk2.groups.io>
Cc: Leif Lindholm <leif@nuviainc.com>,
"afish@apple.com" <afish@apple.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: Hard Feature Freeze starts now for edk2-stable202005
Date: Mon, 25 May 2020 19:46:33 +0200 [thread overview]
Message-ID: <6cdfa14b-b45f-1c19-0dc3-653ef06c40c4@redhat.com> (raw)
In-Reply-To: <CY4PR21MB0743F7D4F86167A9D4140B9BEFB40@CY4PR21MB0743.namprd21.prod.outlook.com>
Hi Bret,
On 05/22/20 17:11, Bret Barkelew wrote:
> We’d like to ask that this patch be considered for the stable tag:
> [PATCH v1 1/1] UnitTestFrameworkPkg/UnitTestResultReportLib: Use AsciiStrnCpyS()
> https://bugzilla.tianocore.org/show_bug.cgi?id=2721
>
> The patch was reviewed prior to the hard freeze date, and is a small change that affects new(ish) code that is not heavily utilized yet.
does the original issue (reported in TianoCore#2721) persist with
TianoCore#2054 fixed?
My understanding (from TianoCore#2721) is that the original
AsciiStrCpyS() call is not buggy, it just triggers a (per spec) error
condition in AsciiStrCpyS(). Previously, that would indeed trip an
ASSERT(), but AIUI that issue has been resolved generally with
TianoCore#2054.
If the AsciiStrCpyS() call remains an issue with the ASSERT() removed,
then replacing the call with AsciiStrnCpyS() still seems like a bugfix
to me, not a "feature", so I think the patch is eligible for merging
during the HFF.
Mike, can you please merge the patch (if it's still needed)?
Thanks
Laszlo
>
> - Bret
>
> From: Liming Gao via groups.io<mailto:liming.gao=intel.com@groups.io>
> Sent: Friday, May 22, 2020 1:01 AM
> To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; announce@edk2.groups.io<mailto:announce@edk2.groups.io>
> Cc: Laszlo Ersek<mailto:lersek@redhat.com>; Leif Lindholm<mailto:leif@nuviainc.com>; afish@apple.com<mailto:afish@apple.com>; Kinney, Michael D<mailto:michael.d.kinney@intel.com>
> Subject: [EXTERNAL] [edk2-devel] Hard Feature Freeze starts now for edk2-stable202005
>
> Hi, all
> Today, we enter into Hard Feature Freeze phase until edk2-stable202005 tag is created at 2020-05-29. In this phase, there is no feature to be pushed. The critical bug fix is still allowed.
>
> If the patch is sent after Hard Feature Freeze, and plans to catch this stable tag, please add edk2-stable202005 key words in the patch title and BZ, and also cc to Tianocore Stewards, then Stewards can give the comments.
>
> Below is edk2-stable202005 tag planning.
> Date (00:00:00 UTC-8) Description
> 2020-03-04 Beginning of development
> 2020-05-08 Feature Planning Freeze
> 2020-05-15 Soft Feature Freeze
> 2020-05-22 Hard Feature Freeze
> 2020-05-29 Release
>
> Thanks
> Liming
>
>
>
>
next prev parent reply other threads:[~2020-05-25 17:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 8:01 Hard Feature Freeze starts now for edk2-stable202005 Liming Gao
2020-05-22 15:11 ` Bret Barkelew
2020-05-25 17:46 ` Laszlo Ersek [this message]
2020-05-26 22:11 ` [EXTERNAL] " Bret Barkelew
2020-05-27 2:21 ` Liming Gao
2020-05-27 2:25 ` [edk2-devel] " Bret Barkelew
2020-05-27 13:08 ` Laszlo Ersek
[not found] <16114AE26AF23A6C.23490@groups.io>
2020-05-29 3:00 ` Liming Gao
2020-05-29 3:06 ` Michael D Kinney
2020-05-29 11:59 ` Laszlo Ersek
2020-05-29 11:58 ` Laszlo Ersek
2020-05-30 16:25 ` Liming Gao
2020-05-30 17:16 ` Bret Barkelew
2020-06-01 14:28 ` Liming Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cdfa14b-b45f-1c19-0dc3-653ef06c40c4@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox