From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web11.15675.1611081594645340138 for ; Tue, 19 Jan 2021 10:39:54 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=hI+927Bx; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611081593; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5k8h70D4fQB1ffxSWaBfSZ1A/me/GvrhzAYjCWSa11g=; b=hI+927BxE64eeK2BPqXK1zI9UaMmdGiL8vKFPz62OYozFofpttqTIEQkRxcNpyE2if1oIf ZQ4S/aTBto6RCykuXaAXhWU2jBMAgUNGpNfgGXm/LdQlvrqdMZKYOhP5Ml9Xw6ioQWTlop OF4b+3sNCIjaPg2/ycQ7e7ewWp5KHHo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-313-0p2g5vxYOSCQ7haRqm0Hwg-1; Tue, 19 Jan 2021 13:39:43 -0500 X-MC-Unique: 0p2g5vxYOSCQ7haRqm0Hwg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8051C800D53; Tue, 19 Jan 2021 18:39:39 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-176.ams2.redhat.com [10.36.114.176]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9327E9CA0; Tue, 19 Jan 2021 18:39:35 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v2 00/10] multiple packages: shell usability improvements From: "Laszlo Ersek" To: devel@edk2.groups.io Cc: Andrew Fish , Anthony Perard , Ard Biesheuvel , Benjamin You , Guo Dong , Jordan Justen , Julien Grall , Leif Lindholm , Maurice Ma , Peter Grehan , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Ray Ni , Rebecca Cran , Sami Mujawar , Zhichao Gao Reply-To: devel@edk2.groups.io, lersek@redhat.com References: <20210113085453.10168-1-lersek@redhat.com> Message-ID: <6d0e646a-0232-8095-012c-f418933c5624@redhat.com> Date: Tue, 19 Jan 2021 19:39:34 +0100 MIME-Version: 1.0 In-Reply-To: <20210113085453.10168-1-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 01/13/21 09:54, Laszlo Ersek wrote: > Repo: https://pagure.io/lersek/edk2.git > Branch: shell_usability_improvements_v2 > > Changes in v2: > > - no code changes in any of the v1 patches, > > - pick up v1 feedback tags from Ard and Zhichao, > > - add two new patches, for resolving OrderedCollectionLib in EmulatorPkg > and UefiPayloadPkg. Merged as commit range e68c2a22caae..6e5586863148, via . Thanks for the reviews; especially thanks to Phil for reviewing the whole series! Laszlo > > Additionally, I have posted the following pre-requisite series, for > edk2-platforms: > > [edk2-devel] [edk2-platforms PATCH 0/3] > add OrderedCollectionLib class resolution > > https://www.redhat.com/archives/edk2-devel-archive/2021-January/msg00694.html > https://edk2.groups.io/g/devel/message/70210 > Message-Id: <20210113082843.9095-1-lersek@redhat.com> > > The v1 posting was at: > > https://edk2.groups.io/g/devel/message/69590 > https://www.redhat.com/archives/edk2-devel-archive/2021-January/msg00070.html > Message-Id: <20210104154235.31785-1-lersek@redhat.com> > > v1 blurb: > > This series addresses various usability shortcomings that I've recently > run into, while working with large directory trees on FAT and/or > virtio-fs in the UEFI shell. > > * add file buffering to the COMP command > https://bugzilla.tianocore.org/show_bug.cgi?id=3123 > > * ArmVirtPkg, OvmfPkg: set PcdShellFileOperationSize to 0x20000 > https://bugzilla.tianocore.org/show_bug.cgi?id=3125 > > * Shell: pathname / filename sorting > https://bugzilla.tianocore.org/show_bug.cgi?id=3151 > > * ArmVirtPkg, OvmfPkg: disable list length checks in NOOPT and DEBUG > builds > https://bugzilla.tianocore.org/show_bug.cgi?id=3152 > > Beyond testing the series locally, I've also heavily subjected it to > local CI runs, including ECC (relevant for ShellPkg). > > Cc: Andrew Fish > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Benjamin You > Cc: Guo Dong > Cc: Jordan Justen > Cc: Julien Grall > Cc: Leif Lindholm > Cc: Maurice Ma > Cc: Peter Grehan > Cc: Philippe Mathieu-Daudé > Cc: Ray Ni > Cc: Rebecca Cran > Cc: Sami Mujawar > Cc: Zhichao Gao > > Thanks > Laszlo > > Laszlo Ersek (10): > ShellPkg/Comp: add file buffering > OvmfPkg: raise PcdShellFileOperationSize to 128KB > ArmVirtPkg: raise PcdShellFileOperationSize to 128KB > EmulatorPkg: add OrderedCollectionLib class resolution > UefiPayloadPkg: add OrderedCollectionLib class resolution > ShellPkg/ShellCommandLib: add ShellSortFileList() > ShellPkg/Ls: sort output by FileName in non-SFO mode > ShellPkg/ShellProtocol: sort files by FullName in > RemoveDupInFileList() > OvmfPkg: disable list length checks in NOOPT and DEBUG builds > ArmVirtPkg: disable list length checks in NOOPT and DEBUG builds > > ArmVirtPkg/ArmVirt.dsc.inc | 2 +- > ArmVirtPkg/ArmVirtQemu.dsc | 1 + > ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 + > EmulatorPkg/EmulatorPkg.dsc | 1 + > OvmfPkg/AmdSev/AmdSevX64.dsc | 1 + > OvmfPkg/Bhyve/BhyveX64.dsc | 1 + > OvmfPkg/OvmfPkgIa32.dsc | 3 + > OvmfPkg/OvmfPkgIa32X64.dsc | 3 + > OvmfPkg/OvmfPkgX64.dsc | 3 + > OvmfPkg/OvmfXen.dsc | 1 + > ShellPkg/Application/Shell/ShellProtocol.c | 16 + > ShellPkg/Include/Library/ShellCommandLib.h | 81 +++++ > ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c | 312 ++++++++++++++++++++ > ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.h | 19 ++ > ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf | 1 + > ShellPkg/Library/UefiShellDebug1CommandsLib/Comp.c | 127 +++++++- > ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf | 1 + > ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c | 14 + > ShellPkg/ShellPkg.dsc | 1 + > UefiPayloadPkg/UefiPayloadPkg.dsc | 1 + > 20 files changed, 586 insertions(+), 4 deletions(-) > > > base-commit: ebfe2d3eb5ac7fd92d74011edb31303a181920c7 >