From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from userp2130.oracle.com (userp2130.oracle.com [156.151.31.86]) by mx.groups.io with SMTP id smtpd.web11.9036.1585064147026159394 for ; Tue, 24 Mar 2020 08:35:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=MM5COLoO; spf=pass (domain: oracle.com, ip: 156.151.31.86, mailfrom: liran.alon@oracle.com) Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02OFN9nv019212; Tue, 24 Mar 2020 15:35:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=YAa/30RiO2/k9clfOOpttAdBhVYJKh/X6kZjPPS5x5I=; b=MM5COLoODU/BaF37ynrUZT5z6GPUnhNPw8x7tQLdMvWBi/bqj6OWuYHim9xLeYzoDknn EvMjrw631x4CIP34ilIMKMM/s+nFAIxpsh7pPHaBHHaFHaeQblGYEXORArCoO6ANogQ3 /OPVXjAR29XQo8d/9E0XoHN8N19wArZncHWytOFBqiFF57FjGZfwv6SbCZ/si5pvXg9G Mu6GkZdcL16nOobt3OGhWB2PNuS60TE1KzmabDgjPgjrPPJwkm0p/4VyDiTai/qTWy09 ZSf1TZgJm0ZcfGeTuyZOvEK0YmrXOumRzFwY5YMn0cVUIywjL0b+NFpdnUkpiPR8OhIA Dg== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2130.oracle.com with ESMTP id 2ywabr51w6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 24 Mar 2020 15:35:45 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02OFMD9P150149; Tue, 24 Mar 2020 15:35:45 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3030.oracle.com with ESMTP id 2yxw4pgtbc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 24 Mar 2020 15:35:45 +0000 Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 02OFZhuU001892; Tue, 24 Mar 2020 15:35:44 GMT Received: from Lirans-MacBook-Pro.local (/213.57.127.2) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 24 Mar 2020 08:35:43 -0700 Subject: Re: [edk2-devel] [PATCH 09/17] OvmfPkg/PvScsiDxe: Backup/Restore PCI attributes on Init/UnInit To: Laszlo Ersek , devel@edk2.groups.io Cc: nikita.leshchenko@oracle.com, aaron.young@oracle.com, jordan.l.justen@intel.com, ard.biesheuvel@linaro.org References: <20200316150113.104630-1-liran.alon@oracle.com> <20200316150113.104630-10-liran.alon@oracle.com> <97fa0b88-b64e-7c1d-5210-7f56aa16df34@redhat.com> From: "Liran Alon" Message-ID: <6d12f888-6614-244a-8204-895100b6d6f6@oracle.com> Date: Tue, 24 Mar 2020 17:35:40 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <97fa0b88-b64e-7c1d-5210-7f56aa16df34@redhat.com> X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9569 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0 spamscore=0 mlxlogscore=999 adultscore=0 phishscore=0 mlxscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003240085 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9569 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 phishscore=0 priorityscore=1501 clxscore=1015 adultscore=0 mlxscore=0 mlxlogscore=999 bulkscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003240085 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US On 24/03/2020 17:14, Laszlo Ersek wrote: > On 03/16/20 16:01, Liran Alon wrote: > I'm going to stop reviewing this iteration now; please rework the rest > of the series for v2 with this resource management pattern. > > Thanks! > Laszlo Thanks for the very detailed review! I have read all your comments and understood them. I am working on creating a v2 patch-series with all these fixed. As the Init/UnInit logic is the only place in which this resource management pattern is done, and as patch-series is split to small well-defined quite independent patches, can I request that you will complete review of all v1 patches? I will understand if you are too busy for this, but it will allow me to take into account all your aggregated comments on v1 to hopefully create a perfect v2 patch-series. As I've tried taking into account all the comments you gave on Nikita's series. Thanks! -Liran