public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Rebecca Cran" <rebecca@bsdio.com>
To: devel@edk2.groups.io, quic_llindhol@quicinc.com,
	"rebecca@bsdio.com" <rebecca@bsdio.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Sami Mujawar <sami.mujawar@arm.com>
Subject: Re: [edk2-devel] SMBIOS BIOS ROM Size
Date: Thu, 30 May 2024 05:58:24 -0600	[thread overview]
Message-ID: <6d21aff5-6972-44cb-9e0a-9c43ea52d196@bsdio.com> (raw)
In-Reply-To: <45c7db99-9b36-43c1-aceb-50705fe350dc@quicinc.com>

On 5/30/2024 4:06 AM, Leif Lindholm via groups.io wrote:
> While reviewing https://github.com/tianocore/edk2/pull/5702, I found 
> myself wondering "shouldn't this (doesn't apply to UEFI-based systems) 
> be the case for the size field also?".
>
> But the SMBIOS spec is quite clear that the size field refers to the 
> size of the physical device the BIOS is stored on.
>
> Currently, this field is hardwired to PcdFdSize in the smbios helper 
> library. But that would only be accurate for platforms that use the 
> edk2 build system to generate the final flashable image to a fixed size.
>
> This isn't really true for SbsaQemu, and I don't think it is for Mt. 
> Jade. And those are the only two upstream platforms using this 
> SmbiosMiscDxe.
>
> Do we need to solve this by adding another function for OemMiscLib?

I still need to update ArmVirtPkg to use it, but I have this commit 
waiting to be submitted:


commit e6d4d2a8cf995a7f4f60e7f55ff2ab494308f939
Author: Rebecca Cran <rebecca@bsdio.com>
Date:   Wed May 15 09:10:54 2024 -0600

     ArmPkg: Add new function OemGetPhysicalBiosSize to OemMiscLib

     The FD size often isn't the same as the physical size of the SPI-NOR
     EEPROM it gets written to, but is instead combined with other files and
     data to create the final image. Add a function `OemGetPhysicalBiosSize`
     which allows platforms to provide the actual size of the EEPROM for
     SMBIOS.

-- 
Rebecca Cran



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119392): https://edk2.groups.io/g/devel/message/119392
Mute This Topic: https://groups.io/mt/106385738/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2024-05-30 11:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-30 10:06 [edk2-devel] SMBIOS BIOS ROM Size Leif Lindholm
2024-05-30 11:58 ` Rebecca Cran [this message]
2024-05-30 16:10   ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6d21aff5-6972-44cb-9e0a-9c43ea52d196@bsdio.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox