From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 26D2C941773 for ; Thu, 30 May 2024 11:58:29 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=SB4sHqCcAv7pMgDvDjfBFTlshoHExhCpW9SRyDBA2tc=; c=relaxed/simple; d=groups.io; h=Feedback-ID:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1717070309; v=1; b=pHnwyN3PFZSMIVanOhfaUvkDBU7DMlhIxsSDFIkNtzI00O+GWpNXCBfrhuvMZp4/o0c9I1d1 6TGfiU9btpptJ9U2TLUC+vOVdkiyA618n4EZerTgNBwGlmVVJt36kRAlVFDPboOBHu5l8hClIRd mEdf2V3mG/8/17lG7ITuoXpIuyiVHdXjDzZ5zD7Orv0yQNu0Mj0Cjp+5YLl2CPGe3I8HqXkcwX5 NMgO7wddnKecNuP7dKHasQhVPz3n2xhGvnR7OHA3e9CyTXwlXXU5h6kfu5kzY3fTgUK2zADfkX+ 1yUGTBahOHWS5tdUenFRNtbMyEkJ7xOtxiyBNJUo9evJg== X-Received: by 127.0.0.2 with SMTP id 6tHGYY7687511xz2s2bReiGk; Thu, 30 May 2024 04:58:28 -0700 X-Received: from fhigh4-smtp.messagingengine.com (fhigh4-smtp.messagingengine.com [103.168.172.155]) by mx.groups.io with SMTP id smtpd.web10.6405.1717070307850579422 for ; Thu, 30 May 2024 04:58:28 -0700 X-Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 323E41140238; Thu, 30 May 2024 07:58:27 -0400 (EDT) X-Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Thu, 30 May 2024 07:58:27 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdekgedggeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtvdejnecuhfhrohhmpeftvggs vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg htthgvrhhnpeekieeffedvvedtleeiveeutdfhtdffgfevgfekleetgeejheelveehffeg leelvdenucffohhmrghinhepghhithhhuhgsrdgtohhmnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomheprhgvsggvtggtrgessghsughiohdrtgho mh X-ME-Proxy: Feedback-ID: i5b994698:Fastmail X-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 30 May 2024 07:58:26 -0400 (EDT) Message-ID: <6d21aff5-6972-44cb-9e0a-9c43ea52d196@bsdio.com> Date: Thu, 30 May 2024 05:58:24 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] SMBIOS BIOS ROM Size To: devel@edk2.groups.io, quic_llindhol@quicinc.com, "rebecca@bsdio.com" Cc: Ard Biesheuvel , Sami Mujawar References: <45c7db99-9b36-43c1-aceb-50705fe350dc@quicinc.com> From: "Rebecca Cran" In-Reply-To: <45c7db99-9b36-43c1-aceb-50705fe350dc@quicinc.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 30 May 2024 04:58:28 -0700 Resent-From: rebecca@bsdio.com Reply-To: devel@edk2.groups.io,rebecca@bsdio.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Y7I1yB5DFJqKH1lxN5PNCy40x7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=pHnwyN3P; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On 5/30/2024 4:06 AM, Leif Lindholm via groups.io wrote: > While reviewing https://github.com/tianocore/edk2/pull/5702, I found > myself wondering "shouldn't this (doesn't apply to UEFI-based systems) > be the case for the size field also?". > > But the SMBIOS spec is quite clear that the size field refers to the > size of the physical device the BIOS is stored on. > > Currently, this field is hardwired to PcdFdSize in the smbios helper > library. But that would only be accurate for platforms that use the > edk2 build system to generate the final flashable image to a fixed size. > > This isn't really true for SbsaQemu, and I don't think it is for Mt. > Jade. And those are the only two upstream platforms using this > SmbiosMiscDxe. > > Do we need to solve this by adding another function for OemMiscLib? I still need to update ArmVirtPkg to use it, but I have this commit waiting to be submitted: commit e6d4d2a8cf995a7f4f60e7f55ff2ab494308f939 Author: Rebecca Cran Date:   Wed May 15 09:10:54 2024 -0600     ArmPkg: Add new function OemGetPhysicalBiosSize to OemMiscLib     The FD size often isn't the same as the physical size of the SPI-NOR     EEPROM it gets written to, but is instead combined with other files and     data to create the final image. Add a function `OemGetPhysicalBiosSize`     which allows platforms to provide the actual size of the EEPROM for     SMBIOS. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119392): https://edk2.groups.io/g/devel/message/119392 Mute This Topic: https://groups.io/mt/106385738/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-