From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 1E4C5780091 for ; Mon, 8 Jan 2024 03:24:07 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=6/Lcol1C2/cv36b8kiFmALYIFryMd3oI0TXMpBshOrc=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:From:To:Cc:Reply-To:References:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1704684246; v=1; b=p7Od5u8Wq/JTsuRxmys1g/wsxrveogpwwY1p6OqPcLfWHZZiH1ewdXmKmpLYgJCn4aHXFkkJ QYyx3oZTNtJ2JxthhOhAviRKUPM65oR4bmB2K+17ssaB98TVhg9CN2QaDGJoD3/EkjjOgbHrD3Q tn7ui8FsZ6wjoj8n7tUkhUxQ= X-Received: by 127.0.0.2 with SMTP id kfZSYY7687511xWjjfE8DSPz; Sun, 07 Jan 2024 19:24:06 -0800 X-Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by mx.groups.io with SMTP id smtpd.web10.32128.1704684245257603852 for ; Sun, 07 Jan 2024 19:24:06 -0800 X-Received: from loongson.cn (unknown [10.40.24.149]) by gateway (Coremail) with SMTP id _____8CxbevRaptlCAUDAA--.9827S3; Mon, 08 Jan 2024 11:24:01 +0800 (CST) X-Received: from [10.40.24.149] (unknown [10.40.24.149]) by localhost.localdomain (Coremail) with SMTP id AQAAf8Axqt3RaptlWuYGAA--.18164S3; Mon, 08 Jan 2024 11:24:01 +0800 (CST) Message-ID: <6d358308-aaae-4396-9c32-776d8ba7476f@loongson.cn> Date: Mon, 8 Jan 2024 11:24:00 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v6 22/36] ArmVirtPkg: Move the FdtSerialPortAddressLib to OvmfPkg From: "Chao Li" To: devel@edk2.groups.io, Ard Biesheuvel , Leif Lindholm , Sami Mujawar , Gerd Hoffmann Cc: Laszlo Ersek Reply-To: devel@edk2.groups.io,lichao@loongson.cn References: <20240105094118.2279380-1-lichao@loongson.cn> <17A76A543E440C35.16812@groups.io> In-Reply-To: <17A76A543E440C35.16812@groups.io> X-CM-TRANSID: AQAAf8Axqt3RaptlWuYGAA--.18164S3 X-CM-SenderInfo: xolfxt3r6o00pqjv00gofq/1tbiAQAKCGWbSakDbgACsy X-Coremail-Antispam: 1Uk129KBj93XoWxuryfJFW8CryfXFWUGF4xXwc_yoW5Kw1fpF 1qyr4UJrW8Za1ft390va4rWFs0gas0vFZ093y5Aw1aywnxtr1avrn0ywn8Xr45ZF1fJryk Wrs09a1qvF4kJ3gCm3ZEXasCq-sJn29KB7ZKAUJUUUU8529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3UbIjqfuFe4nvWSU5nxnvy29KBjDU0xBIdaVrnRJUUUyEb4IE77IF4wAF F20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r 1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAF wI0_Ar0_tr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Cr0_Gr1UM28EF7xvwVC2z280aV AFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gr1j6F4UJwAS0I0E0xvYzxvE 52x082IY62kv0487Mc804VCY07AIYIkI8VC2zVCFFI0UMcIj6xIIjxv20xvE14v26r126r 1DMcIj6I8E87Iv67AKxVW8JVWxJwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41l 7480Y4vEI4kI2Ix0rVAqx4xJMxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r 4UMI8I3I0E5I8CrVAFwI0_JrI_JrWlx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF 67AKxVWUAVWUtwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1I6r4UMIIF0xvE2I x0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2 z280aVAFwI0_Gr0_Cr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnU UI43ZEXa7IU1dgA7UUUUU== Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: LJZTh278mqcRwZWd5k9jYzRax7686176AA= Content-Type: multipart/alternative; boundary="------------Z7FJUlizZAEdyy2rSxUPEofF" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=p7Od5u8W; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --------------Z7FJUlizZAEdyy2rSxUPEofF Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Ard, Leif, Sami, Gred, Can you please help to review this patch? Thanks, Chao On 2024/1/5 17:44, Chao Li wrote: > Move the FdtSerialPortAddressLib to Ovmfpkg so that other ARCH can > easily use it. > > Build-tested only (with "ArmVirtQemu.dsc"). > > BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4584 > > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Sami Mujawar > Cc: Gerd Hoffmann > Cc: Jiewen Yao > Cc: Laszlo Ersek > Signed-off-by: Chao Li > --- > ArmVirtPkg/ArmVirt.dsc.inc | 2 +- > .../Include/Library/FdtSerialPortAddressLib.h | 0 > .../Library/FdtSerialPortAddressLib/FdtSerialPortAddressLib.c | 0 > .../Library/FdtSerialPortAddressLib/FdtSerialPortAddressLib.inf | 2 +- > 4 files changed, 2 insertions(+), 2 deletions(-) > rename {ArmVirtPkg =3D> OvmfPkg}/Include/Library/FdtSerialPortAddressLi= b.h (100%) > rename {ArmVirtPkg =3D> OvmfPkg}/Library/FdtSerialPortAddressLib/FdtSer= ialPortAddressLib.c (100%) > rename {ArmVirtPkg =3D> OvmfPkg}/Library/FdtSerialPortAddressLib/FdtSer= ialPortAddressLib.inf (90%) > > diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc > index 9b23ef97ec..2bc6a29eb1 100644 > --- a/ArmVirtPkg/ArmVirt.dsc.inc > +++ b/ArmVirtPkg/ArmVirt.dsc.inc > @@ -122,7 +122,7 @@ > # ARM PL011 UART Driver > PL011UartLib|ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf > SerialPortLib|ArmVirtPkg/Library/FdtPL011SerialPortLib/FdtPL011Serial= PortLib.inf > - FdtSerialPortAddressLib|ArmVirtPkg/Library/FdtSerialPortAddressLib/Fdt= SerialPortAddressLib.inf > + FdtSerialPortAddressLib|OvmfPkg/Library/FdtSerialPortAddressLib/FdtSer= ialPortAddressLib.inf > =20 > PeCoffExtraActionLib|ArmPkg/Library/DebugPeCoffExtraActionLib/DebugPe= CoffExtraActionLib.inf > #PeCoffExtraActionLib|MdePkg/Library/BasePeCoffExtraActionLibNull/Bas= ePeCoffExtraActionLibNull.inf > diff --git a/ArmVirtPkg/Include/Library/FdtSerialPortAddressLib.h b/OvmfP= kg/Include/Library/FdtSerialPortAddressLib.h > similarity index 100% > rename from ArmVirtPkg/Include/Library/FdtSerialPortAddressLib.h > rename to OvmfPkg/Include/Library/FdtSerialPortAddressLib.h > diff --git a/ArmVirtPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddr= essLib.c b/OvmfPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddressLib.= c > similarity index 100% > rename from ArmVirtPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddre= ssLib.c > rename to OvmfPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddressLib= .c > diff --git a/ArmVirtPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddr= essLib.inf b/OvmfPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddressLi= b.inf > similarity index 90% > rename from ArmVirtPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddre= ssLib.inf > rename to OvmfPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddressLib= .inf > index ae6d0d374b..e27742e9fa 100644 > --- a/ArmVirtPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddressLib.= inf > +++ b/OvmfPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddressLib.inf > @@ -18,9 +18,9 @@ > FdtSerialPortAddressLib.c > =20 > [Packages] > - ArmVirtPkg/ArmVirtPkg.dec > EmbeddedPkg/EmbeddedPkg.dec > MdePkg/MdePkg.dec > + OvmfPkg/OvmfPkg.dec > =20 > [LibraryClasses] > BaseLib -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113346): https://edk2.groups.io/g/devel/message/113346 Mute This Topic: https://groups.io/mt/103591207/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --------------Z7FJUlizZAEdyy2rSxUPEofF Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Hi Ard, Leif, Sami, Gred,

Can you please help to review this patch?


=
Thanks,
Chao
On 2024/1/5 17:44, Chao Li wrote:
Move the FdtSerialPortAddressL=
ib to Ovmfpkg so that other ARCH can
easily use it.

Build-tested only (with "ArmVirtQemu.dsc").

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=
=3D4584

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Chao Li <lichao@loongson.cn>
---
 ArmVirtPkg/ArmVirt.dsc.inc                                      | 2 +-
 .../Include/Library/FdtSerialPortAddressLib.h                   | 0
 .../Library/FdtSerialPortAddressLib/FdtSerialPortAddressLib.c   | 0
 .../Library/FdtSerialPortAddressLib/FdtSerialPortAddressLib.inf | 2 +-
 4 files changed, 2 insertions(+), 2 deletions(-)
 rename {ArmVirtPkg =3D> OvmfPkg}/Include/Library/FdtSerialPortAddressLi=
b.h (100%)
 rename {ArmVirtPkg =3D> OvmfPkg}/Library/FdtSerialPortAddressLib/FdtSer=
ialPortAddressLib.c (100%)
 rename {ArmVirtPkg =3D> OvmfPkg}/Library/FdtSerialPortAddressLib/FdtSer=
ialPortAddressLib.inf (90%)

diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
index 9b23ef97ec..2bc6a29eb1 100644
--- a/ArmVirtPkg/ArmVirt.dsc.inc
+++ b/ArmVirtPkg/ArmVirt.dsc.inc
@@ -122,7 +122,7 @@
   # ARM PL011 UART Driver
   PL011UartLib|ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf
   SerialPortLib|ArmVirtPkg/Library/FdtPL011SerialPortLib/FdtPL011SerialPor=
tLib.inf
-  FdtSerialPortAddressLib|ArmVirtPkg/Library/FdtSerialPortAddressLib/FdtSe=
rialPortAddressLib.inf
+  FdtSerialPortAddressLib|OvmfPkg/Library/FdtSerialPortAddressLib/FdtSeria=
lPortAddressLib.inf
=20
   PeCoffExtraActionLib|ArmPkg/Library/DebugPeCoffExtraActionLib/DebugPeCof=
fExtraActionLib.inf
   #PeCoffExtraActionLib|MdePkg/Library/BasePeCoffExtraActionLibNull/BasePe=
CoffExtraActionLibNull.inf
diff --git a/ArmVirtPkg/Include/Library/FdtSerialPortAddressLib.h b/OvmfPkg=
/Include/Library/FdtSerialPortAddressLib.h
similarity index 100%
rename from ArmVirtPkg/Include/Library/FdtSerialPortAddressLib.h
rename to OvmfPkg/Include/Library/FdtSerialPortAddressLib.h
diff --git a/ArmVirtPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddres=
sLib.c b/OvmfPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddressLib.c
similarity index 100%
rename from ArmVirtPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddress=
Lib.c
rename to OvmfPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddressLib.c
diff --git a/ArmVirtPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddres=
sLib.inf b/OvmfPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddressLib.=
inf
similarity index 90%
rename from ArmVirtPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddress=
Lib.inf
rename to OvmfPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddressLib.i=
nf
index ae6d0d374b..e27742e9fa 100644
--- a/ArmVirtPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddressLib.in=
f
+++ b/OvmfPkg/Library/FdtSerialPortAddressLib/FdtSerialPortAddressLib.inf
@@ -18,9 +18,9 @@
   FdtSerialPortAddressLib.c
=20
 [Packages]
-  ArmVirtPkg/ArmVirtPkg.dec
   EmbeddedPkg/EmbeddedPkg.dec
   MdePkg/MdePkg.dec
+  OvmfPkg/OvmfPkg.dec
=20
 [LibraryClasses]
   BaseLib
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#113346) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--------------Z7FJUlizZAEdyy2rSxUPEofF--