public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* Re: [edk2-devel] ASL build tools - EDKII trim tool questions
@ 2019-04-09  1:05 Liming Gao
  2019-04-09  9:10 ` Laszlo Ersek
  0 siblings, 1 reply; 9+ messages in thread
From: Liming Gao @ 2019-04-09  1:05 UTC (permalink / raw)
  To: Schmauss, Erik, devel@edk2.groups.io, felixp@ami.com; +Cc: Moore, Robert

[-- Attachment #1: Type: text/plain, Size: 5028 bytes --]

The full preprocessor means to support C style syntax in ASL code, such as #include “xxx.h” or #define ASL_MACRO 10. Do you want to support it?

Thanks
Liming
From: Schmauss, Erik
Sent: Tuesday, April 9, 2019 12:45 AM
To: Gao, Liming <liming.gao@intel.com>; devel@edk2.groups.io; felixp@ami.com
Cc: Moore, Robert <robert.moore@intel.com>
Subject: RE: [edk2-devel] ASL build tools - EDKII trim tool questions

That wasn’t my exact thought but that could work as well..

The idea is to implement full preprocessor support in iASL so that we wouldn’t need to use trim and iASL for ASL pre-processing/compilation and just use iASL.

Along the way, we might be able to support what you mentioned as well.

From: Gao, Liming
Sent: Monday, April 8, 2019 9:23 AM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Schmauss, Erik <erik.schmauss@intel.com<mailto:erik.schmauss@intel.com>>; felixp@ami.com<mailto:felixp@ami.com>
Subject: RE: [edk2-devel] ASL build tools - EDKII trim tool questions

Do you mean that iASL compiler will support the preprocessor line style in the preprocessed ASL file, such as #line 50 "d:\allpkg\edk2\TestPkg\TestAsl\Test.asi"? If so, iASL compiler can report the accurate error line number in original source file.

Thanks
Liming
From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> [mailto:devel@edk2.groups.io] On Behalf Of Schmauss, Erik
Sent: Friday, April 5, 2019 7:44 AM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; felixp@ami.com<mailto:felixp@ami.com>
Subject: Re: [edk2-devel] ASL build tools - EDKII trim tool questions

Hi Felix,

Thanks for the info!

I am not a firmware developer by any means. However, it seems difficult to develop code in an environment where compiler error line numbers do not match the actual source… I’ve heard several people complain about this and I would like to help alleviate these pain-points if possible (and practical).

Hypothetically, if iASL had support for a preprocessor that produced the exact same ASL/AML output as the current toolchain, would there be interest in switching build system over to solely use edkii?

From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> [mailto:devel@edk2.groups.io] On Behalf Of Felix Polyudov
Sent: Thursday, April 4, 2019 3:11 PM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Schmauss, Erik <erik.schmauss@intel.com<mailto:erik.schmauss@intel.com>>
Subject: Re: [edk2-devel] ASL build tools - EDKII trim tool questions

Eric,

One of the reasons the trim tool is used is to support usage of C macros in ASL files
(ASL files may include C header files and are processed by a C preprocessor).
This is edk2 way of reusing the same constant definition across source files in different formats.

From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> [mailto:devel@edk2.groups.io] On Behalf Of erik.schmauss@intel.com<mailto:erik.schmauss@intel.com>
Sent: Thursday, April 04, 2019 3:08 PM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Subject: [edk2-devel] ASL build tools - EDKII trim tool questions


Hello,

I work on the ACPICA project (iASL, acpidump, acpiexec, and etc). I’ve been looking at the EDKII repository and tools that relate to ACPI and ASL.

In particular, I’ve been looking at the trim tool https://github.com/tianocore/edk2/blob/master/BaseTools/Source/Python/Trim/Trim.py

According to the source code, the “--asl-file” option replaces #include and Include (a.k.a. the “ASL include”) with actual contents of the file.

I would prefer everyone to use iASL compiler to do this instead. The problem with trim is that it makes iASL compiler errors more difficult to understand because the original file has been preprocessed by trim and the line numbers from iASL remarks/warnings/errors do not make sense to the programmer... The iASL compiler handles ASL include statements as well as preprocessor #include statements. When compiling these files with include statements/directives, iASL displays the correct line number and file name of the included file. Therefore, I think it would be beneficial to developers to use only iASL rather than trim "--asl-files" and iASL to work on ASL files.

I've been talking to some people internally about this trim tool but I would like to ask this community if anyone has thoughts/opinions on deprecating trim's ASL option.

Thanks,

Erik


P Please consider the environment before printing this email

The information contained in this message may be confidential and proprietary to American Megatrends, Inc. This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.


[-- Attachment #2: Type: text/html, Size: 16090 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread
* ASL build tools - EDKII trim tool questions
@ 2019-04-04 19:08 erik.schmauss
  2019-04-04 22:10 ` [edk2-devel] " Felix Polyudov
  0 siblings, 1 reply; 9+ messages in thread
From: erik.schmauss @ 2019-04-04 19:08 UTC (permalink / raw)
  To: devel

[-- Attachment #1: Type: text/plain, Size: 1319 bytes --]

Hello,

I work on the ACPICA project (iASL, acpidump, acpiexec, and etc). I’ve been looking at the EDKII repository and tools that relate to ACPI and ASL.

In particular, I’ve been looking at the trim tool https://github.com/tianocore/edk2/blob/master/BaseTools/Source/Python/Trim/Trim.py

According to the source code, the “--asl-file” option replaces #include and Include (a.k.a. the “ASL include”) with actual contents of the file.

I would prefer everyone to use iASL compiler to do this instead. The problem with trim is that it makes iASL compiler errors more difficult to understand because the original file has been preprocessed by trim and the line numbers from iASL remarks/warnings/errors do not make sense to the programmer... The iASL compiler handles ASL include statements as well as preprocessor #include statements. When compiling these files with include statements/directives, iASL displays the correct line number and file name of the included file. Therefore, I think it would be beneficial to developers to use only iASL rather than trim "--asl-files" and iASL to work on ASL files.

I've been talking to some people internally about this trim tool but I would like to ask this community if anyone has thoughts/opinions on deprecating trim's ASL option.

Thanks,

Erik

[-- Attachment #2: Type: text/html, Size: 1668 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-04-12 18:49 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-09  1:05 [edk2-devel] ASL build tools - EDKII trim tool questions Liming Gao
2019-04-09  9:10 ` Laszlo Ersek
2019-04-11 23:10   ` Schmauss, Erik
2019-04-12 18:03     ` Felix Polyudov
2019-04-12 18:49       ` Schmauss, Erik
  -- strict thread matches above, loose matches on Subject: below --
2019-04-04 19:08 erik.schmauss
2019-04-04 22:10 ` [edk2-devel] " Felix Polyudov
2019-04-04 23:44   ` erik.schmauss
2019-04-08 16:23     ` Liming Gao
2019-04-08 16:45       ` Schmauss, Erik

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox