From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3C52C74003E for ; Wed, 15 Nov 2023 11:53:35 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=xyoGEfoYaZ0AAUCoWOT471Tkt5Ky74ObC18c/EueS9o=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1700049213; v=1; b=daooWYRRtXf8cInMvC6FqonyWX3WFw7MNs4i03/Qy8JbybOuJIkAb4tOGMgycFTQ5lFWhXRi YJbfTL4dakd+2uBT429zpYyJQokI5zqca20HDPm9N1J16KhQFrc32Eak9UiE/W8ZiJs3YRitOAC EhXPS/5C3jR1uE/kGvIBF+gA= X-Received: by 127.0.0.2 with SMTP id KP6IYY7687511xbCCmEAlqIg; Wed, 15 Nov 2023 03:53:33 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.11222.1700049213234453448 for ; Wed, 15 Nov 2023 03:53:33 -0800 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-689-q0qYdGxXOh2jnJlyvwIHOw-1; Wed, 15 Nov 2023 06:53:27 -0500 X-MC-Unique: q0qYdGxXOh2jnJlyvwIHOw-1 X-Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E492F3C0009E; Wed, 15 Nov 2023 11:53:26 +0000 (UTC) X-Received: from [10.39.192.211] (unknown [10.39.192.211]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 938F9492BFD; Wed, 15 Nov 2023 11:53:25 +0000 (UTC) Message-ID: <6ddd17ec-a71f-bbf6-4d42-3b896509d638@redhat.com> Date: Wed, 15 Nov 2023 12:53:24 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v1 3/3] OvmfPkg: Format with Uncrustify 73.0.8 To: devel@edk2.groups.io, mikuback@linux.microsoft.com Cc: Ard Biesheuvel , =?UTF-8?Q?Corvin_K=c3=b6hne?= , Gerd Hoffmann , Jiewen Yao , Rebecca Cran References: <20231114202227.1765-1-mikuback@linux.microsoft.com> <20231114202227.1765-4-mikuback@linux.microsoft.com> From: "Laszlo Ersek" In-Reply-To: <20231114202227.1765-4-mikuback@linux.microsoft.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: bG0Ar6gRNIjSWjc4NzIfZF5px7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=daooWYRR; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 11/14/23 21:22, Michael Kubacki wrote: > From: Michael Kubacki > > Cc: Ard Biesheuvel > Cc: Corvin Köhne > Cc: Gerd Hoffmann > Cc: Jiewen Yao > Cc: Rebecca Cran > Signed-off-by: Michael Kubacki > --- > OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.c | 4 ++-- > OvmfPkg/IncompatiblePciDeviceSupportDxe/IncompatiblePciDeviceSupport.c | 24 ++++++++++---------- > OvmfPkg/PlatformPei/MemTypeInfo.c | 2 +- > OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbInfo.c | 6 ++--- > 4 files changed, 18 insertions(+), 18 deletions(-) > > diff --git a/OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.c b/OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.c > index 4fc715dc3681..c07e38966e36 100644 > --- a/OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.c > +++ b/OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.c > @@ -658,8 +658,8 @@ InitializeFvAndVariableStoreHeaders ( > > // UINT32 Size; > ( > - FixedPcdGet32 (PcdFlashNvStorageVariableSize) - > - OFFSET_OF (FVB_FV_HDR_AND_VARS_TEMPLATE, VarHdr) > + FixedPcdGet32 (PcdFlashNvStorageVariableSize) - > + OFFSET_OF (FVB_FV_HDR_AND_VARS_TEMPLATE, VarHdr) > ), > > // UINT8 Format; > diff --git a/OvmfPkg/IncompatiblePciDeviceSupportDxe/IncompatiblePciDeviceSupport.c b/OvmfPkg/IncompatiblePciDeviceSupportDxe/IncompatiblePciDeviceSupport.c > index 3092a174bc51..0b3888194444 100644 > --- a/OvmfPkg/IncompatiblePciDeviceSupportDxe/IncompatiblePciDeviceSupport.c > +++ b/OvmfPkg/IncompatiblePciDeviceSupportDxe/IncompatiblePciDeviceSupport.c > @@ -49,12 +49,12 @@ STATIC EFI_INCOMPATIBLE_PCI_DEVICE_SUPPORT_PROTOCOL > STATIC CONST EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR mMmio64Configuration = { > ACPI_ADDRESS_SPACE_DESCRIPTOR, // Desc > (UINT16)( // Len > - sizeof (EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR) - > - OFFSET_OF ( > - EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR, > - ResType > - ) > - ), > + sizeof (EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR) - > + OFFSET_OF ( > + EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR, > + ResType > + ) > + ), > ACPI_ADDRESS_SPACE_TYPE_MEM, // ResType > 0, // GenFlag > 0, // SpecificFlag > @@ -83,12 +83,12 @@ STATIC CONST EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR mMmio64Configuration = { > STATIC CONST EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR mOptionRomConfiguration = { > ACPI_ADDRESS_SPACE_DESCRIPTOR, // Desc > (UINT16)( // Len > - sizeof (EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR) - > - OFFSET_OF ( > - EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR, > - ResType > - ) > - ), > + sizeof (EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR) - > + OFFSET_OF ( > + EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR, > + ResType > + ) > + ), > ACPI_ADDRESS_SPACE_TYPE_MEM, // ResType > 0, // GenFlag > 0, // Disable option roms SpecificFlag > diff --git a/OvmfPkg/PlatformPei/MemTypeInfo.c b/OvmfPkg/PlatformPei/MemTypeInfo.c > index ea049b21cfc0..dfb1bc37a93d 100644 > --- a/OvmfPkg/PlatformPei/MemTypeInfo.c > +++ b/OvmfPkg/PlatformPei/MemTypeInfo.c > @@ -196,7 +196,7 @@ OnReadOnlyVariable2Available ( > // > STATIC CONST EFI_PEI_NOTIFY_DESCRIPTOR mReadOnlyVariable2Notify = { > (EFI_PEI_PPI_DESCRIPTOR_NOTIFY_DISPATCH | > - EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST), // Flags > + EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST), // Flags > &gEfiPeiReadOnlyVariable2PpiGuid, // Guid > OnReadOnlyVariable2Available // Notify > }; > diff --git a/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbInfo.c b/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbInfo.c > index ea5ce837119a..e38f03cae046 100644 > --- a/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbInfo.c > +++ b/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbInfo.c > @@ -75,9 +75,9 @@ EFI_FVB_MEDIA_INFO mPlatformFvbMediaInfo[] = { > { > { > (FixedPcdGet32 (PcdFlashNvStorageVariableSize) + > - FixedPcdGet32 (PcdFlashNvStorageFtwWorkingSize) + > - FixedPcdGet32 (PcdFlashNvStorageFtwSpareSize) + > - FixedPcdGet32 (PcdOvmfFlashNvStorageEventLogSize)) / > + FixedPcdGet32 (PcdFlashNvStorageFtwWorkingSize) + > + FixedPcdGet32 (PcdFlashNvStorageFtwSpareSize) + > + FixedPcdGet32 (PcdOvmfFlashNvStorageEventLogSize)) / > FixedPcdGet32 (PcdOvmfFirmwareBlockSize), > FixedPcdGet32 (PcdOvmfFirmwareBlockSize), > } Reviewed-by: Laszlo Ersek -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111264): https://edk2.groups.io/g/devel/message/111264 Mute This Topic: https://groups.io/mt/102591693/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-