From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web10.14061.1598514993157551262
 for <devel@edk2.groups.io>;
 Thu, 27 Aug 2020 00:56:33 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BC8AC101E;
	Thu, 27 Aug 2020 00:56:32 -0700 (PDT)
Received: from [192.168.1.205] (unknown [10.37.8.134])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AA2AC3F66B;
	Thu, 27 Aug 2020 00:56:30 -0700 (PDT)
Subject: Re: [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Fix build error in DisplayDxe
To: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>, devel@edk2.groups.io
Cc: Leif Lindholm <leif@nuviainc.com>, Pete Batard <pete@akeo.ie>,
 Andrei Warkentin <awarkentin@vmware.com>
References: <20200826232015.9030-1-Samer.El-Haj-Mahmoud@arm.com>
From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
Message-ID: <6ddde5ff-71fb-0dad-dd94-0cf386a1c09e@arm.com>
Date: Thu, 27 Aug 2020 09:56:28 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <20200826232015.9030-1-Samer.El-Haj-Mahmoud@arm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 8/27/20 1:20 AM, Samer El-Haj-Mahmoud wrote:
> Commit 0c2af04985f0bf152ac3edc70d9c6d9fe884cdcb added mDriverBinding
> extern module global, but did not remove the STATIC declaration, which
> caused the build to break. Fix the build error by removing STATIC for
> that module global variable.
> 
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Pete Batard <pete@akeo.ie>
> Cc: Andrei Warkentin <awarkentin@vmware.com>
> Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>

Pushed as 0cb34c0de123..5955ac2f10af

Thanks all

> ---
>   Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c b/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c
> index ae4b2735820c..3eba98e5aa87 100644
> --- a/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c
> +++ b/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c
> @@ -87,7 +87,7 @@ DisplayBlt (
>     IN  UINTN                                   Delta         OPTIONAL
>     );
>   
> -STATIC EFI_DRIVER_BINDING_PROTOCOL mDriverBinding = {
> +EFI_DRIVER_BINDING_PROTOCOL mDriverBinding = {
>     DriverSupported,
>     DriverStart,
>     DriverStop,
>