Re: [edk2-devel] [PATCH 13/16] UefiCpuPkg/MpInitLib: Always use AP Create if PcdSevSnpApicIds is set

["Lendacky, Thomas via groups.io" <thomas.lendacky=amd.com@groups.io>]

On 2/2/24 00:20, Ni, Ray wrote:
> 
>> +      if (SevSnpUseCreateAP (CpuMpData)) {
> 
> 1. Is it possible to rename "SevSnpUseCreateAP" to some name starting
> with "IsXXX"?
> I originally mixed it with SevSnpCreateAP() and thought you created a
> bug.

"Is" doesn't really fit for this, how about UseSevSnpCreateAP() or 
CanUseSevSnpCreateAP()?

> 
> 
>> +    GhcbApicIds = (GHCB_APIC_IDS *)(UINTN)PcdGet64 (PcdSevSnpApicIds);
> 
> 2. Can you define a GUIDed HOB to hold the contents instead of dynamic PCDs?
> Dynamic PCDs cannot tell whether the value is updated in earlier code or still
> holds the default value.
> Also, I prefer to minimize the dynamic PCD usage in CPU code.

Yep, will do.

Thanks,
Tom

> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115072): https://edk2.groups.io/g/devel/message/115072
Mute This Topic: https://groups.io/mt/103986469/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-