From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id D29B2AC1B90 for ; Fri, 2 Feb 2024 22:58:35 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ofgVy+tp1diCltIFVJeoDIKgV7MTIrGKPXhRIy/iwqo=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706914714; v=1; b=PdaO6BBUeN8emy/KCl3PIqEBMc92zEmiKXeA7ODvJ+qmqAUpzOchBYAMX+w2TZhd7+rnalTT AQp27fbJPG7mCs32nQIleXnKwcBuZMQeBmd27zdAHbrq9E/dQ6Ke5/DUD5E4o9kz/3m4hUdzt8A o4JEv4gMchytTuMa5ZHhy6uA= X-Received: by 127.0.0.2 with SMTP id Cx3wYY7687511xEAx0MOiqjo; Fri, 02 Feb 2024 14:58:34 -0800 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.65]) by mx.groups.io with SMTP id smtpd.web11.6418.1706914713844573726 for ; Fri, 02 Feb 2024 14:58:34 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iMOqUtomhC8rep0ET540j9/il3sMhEge3YA+uQTBRshBw5ebon6Z8SKg7vvXV19i0hD1AW+Usdfj1JxuEco3iwoKCI+ZSp9geyNcJAvzAsxJZA3BfAG6z04Sdv7wti5KxRmJEObqMHKsxk/JKqWZep0uUnnJq4EeqRqlKJuihDZPGXA8egSwjh1qwDcHgocZytU2gM6Xbsi5LH8/Hjxq2nVMDk2IUqXno3C6PE21tiyHxSrS92uZGkZoqCQWC5cjL3lObNMokSho7G5zcYYtkTkHUChd0ZrmcZZCOG49Gf7aW6HVr7YI5Wd26YtfIDKynMhO21p2CL+++S2xDugp6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oNSDBlqGJKiH9etmQbPTXxSJiDK87E9TD9vPSEvdCA8=; b=B15M3x9P08w+XbpIyDS/nX30sQ5QOViY66UXx1DHj9Bble31Vezf+1GX8KniqoTsD4rR0Wlh62e79oax7rgKaBDR8zbvmn7Jw/FnB9ASpswogMVN40KpLchkm/RHn2XB1O5rQUWBgjEH0CqDCSpEVKBFJIK5sKmKqb85l4UikLgYy8zpUrV1U6SJvDd9yIXLRi0Im+ZgkF+ls/3vaFVSwLcooJZIFwSEJvPjTRa2rJq8kAVkzhon/P+OsJC1h3z2YTMPBJfnpjlkPPEQk1ZRc944RggtVTIIA6FHrFTf8dyHqHPp6FMA2jkjGAw/0s8DbNjDChCjg88n6wU9gVjibw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from BL1PR12MB5732.namprd12.prod.outlook.com (2603:10b6:208:387::17) by SA1PR12MB6821.namprd12.prod.outlook.com (2603:10b6:806:25c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.11; Fri, 2 Feb 2024 22:58:31 +0000 X-Received: from BL1PR12MB5732.namprd12.prod.outlook.com ([fe80::200:c1d0:b9aa:e16c]) by BL1PR12MB5732.namprd12.prod.outlook.com ([fe80::200:c1d0:b9aa:e16c%4]) with mapi id 15.20.7270.009; Fri, 2 Feb 2024 22:58:31 +0000 Message-ID: <6de1de3b-5ae5-82c9-664f-ee93edd8f38f@amd.com> Date: Fri, 2 Feb 2024 16:58:27 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [edk2-devel] [PATCH 13/16] UefiCpuPkg/MpInitLib: Always use AP Create if PcdSevSnpApicIds is set To: "Ni, Ray" , "devel@edk2.groups.io" Cc: Ard Biesheuvel , "Aktas, Erdem" , Gerd Hoffmann , "Yao, Jiewen" , Laszlo Ersek , Liming Gao , "Kinney, Michael D" , "Xu, Min M" , "Liu, Zhiguang" , "Kumar, Rahul R" , Michael Roth References: <1948e02ed8167f9b9f8a71dd2d3216896720aa30.1706307195.git.thomas.lendacky@amd.com> From: "Lendacky, Thomas via groups.io" In-Reply-To: X-ClientProxiedBy: SN7PR04CA0183.namprd04.prod.outlook.com (2603:10b6:806:126::8) To BL1PR12MB5732.namprd12.prod.outlook.com (2603:10b6:208:387::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL1PR12MB5732:EE_|SA1PR12MB6821:EE_ X-MS-Office365-Filtering-Correlation-Id: f92cfa58-a24a-4a4a-ff1a-08dc244279b1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: Ca0AmK7K9fSRBUyq9iaHPKbAD8xJNUEC+cg+a9No9JPbWcEZEcEUvza/OENMTyTtp4jrZBebvXENCapS9+7A46Y2MP4C2+Dn92nin9Z1BazAL3YbD/bE0swCLOcadTF9ggY7A6TAr+gx4h6K907rXYnIm4BXSg595Z0OxadIEosLz52XXxUNYvGTZVQwzF8jCvtDkpe5+inQCPknYplAF950nzxB5EZeQNlHpAvxKdGEEQa+NIpHJc0FIZakHBbhLSgdkatktlWNHvbNHHkl+ARNUW+FeZBkJWmh8ZxAIk+g/wkn4BHhsqf3ShD8fOPS6xUxBpHsVedpuK+MGuehseDiPVZqFu/QF9qd2y86iWf1V9i6fxjeq4HD1tpgA60YK+eyyuLy7otRF+/PA+6rBZY7tS8DMi8Lu3S8UNZzFxmbiu3lB0caUgvSel/GfWwjF2GFN5f5Tl/6As9+HNzLmkgDxKsZrW9u5zBLPmwfU66l8G7VyDCFyf0tg6LI9LaghjrumHU4TfKOX5MPdxnE/7czt7ottHvDrjbi76OAPcpVMxS/qTu0uiGXMagOnHucEMyKElTrJmbWgfRLc8rUIuhwDQWQsRzplXMIkJZk6tz5rBb2ELRd/hb7AsjC4+cIiDcJcVlZSX3Ch/qYu5BLtLh9Z/Yfibu60/hEeL2vd34= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MnBSVWFBalFRLzdCZlFmLzJKZlMyZjRaY2NYMHNjVmR6QUZGY1Rac2IxZkJB?= =?utf-8?B?aTlqYjdTVk5taUNJSzI0UkppbXRkVVBhd0RUTW1GcnN5WFdDc3dEdTZLVEQx?= =?utf-8?B?T2tyb3RyUXZOWUtFMmY3QjZ5OWtOYTNTSjVLd1ZTZ0grZVJhZmROVEtzbHVN?= =?utf-8?B?MVNjTGJTdGpBOUxleVRYbXBRUklMVHN5dGdOUHBuZmdyVWIwK0x0Y0NsK2V5?= =?utf-8?B?OUx5QnA2bkVsVzBQaURlOFBkbUdpeDdnVW5vZ3h1QlE3S2JTakV6a01DcnNO?= =?utf-8?B?b25VLzVxTE5RRkMvNy9ZeUsydzR1eWJBOTkxZlFVcDg4VlFyNUpBQ1hxdFJr?= =?utf-8?B?UWtrbmhNVTRyQ3hMalZ4T2NBc2lzaHNCand4QXJXSWF0TWhxbDEyR29sR01U?= =?utf-8?B?bHh5M05RWSthazg3dFo1ZWpEZ3Izekp1OFpKakl1RWg3OUpYWW9Jc2pEWk1B?= =?utf-8?B?SUFFLzVqcXdOT0hyOXpMSHdzNVhWZWY3QzVHekhlZVhFRmxUWnNMTkw1cXNL?= =?utf-8?B?NDNVQTVhUkFIa1JSMitYMGVqTDVNSWhia2J6N1daTGUvZG1ycFcwUW5ybUdG?= =?utf-8?B?Zmg5L1BwMkgyNzVYU3RSblBCb1llS3E4SkhFSGlqZ2FLT1h5d2JrUk1LazVO?= =?utf-8?B?a3F1Rzc4U3FFSDhsbGM2bUY1ajlTY1NpWkFueXVTanQ0eDF5b0g4emtjZDAz?= =?utf-8?B?ZEtGaTZNQUx1NFFZNFcyaDNpbDJQMHhjTVpsbjVPaVdzTGpLeGRCR0xzSmZC?= =?utf-8?B?VFZXVTdZYlhCZWNHM1ZQbU1VY2pDYzluNkRsUWZUQ3hiMkVzVW1JTDFCUFlj?= =?utf-8?B?ekJGdlBESmZueEpVcVd4OFJWS0xtbmxBWTFLU0lmL0d0akM2ZXd5VXZVcXpN?= =?utf-8?B?ZlhkTkdZazlxWG1ETFB2TkY5VGxwQWpMSm5ZVmJ1VjRjVDlqRlZPY1M4RTVp?= =?utf-8?B?SU5VV1VEMFlFTFVsSUExeStFWWNxdThWQ3owUlBBbjRFZ2x3STNidFdzTGNB?= =?utf-8?B?OHJBV1d6dGtPNzlzYTZSK3FxeDF3MXVtUml5c2lpaXJBRk9FMDdhUjUzdndJ?= =?utf-8?B?WXdydnl0clZ6K1RtY0xSSXNJQXl5R3dqK2ZrTlBDZHhPNVZNWFdsNkNlTUNL?= =?utf-8?B?a2xLbWVHSGdxazNBTk5QTHAxTkNjdHV3TWFXVEROQ0JXSUpFaFBkcnFKeFYy?= =?utf-8?B?ZnNpRW52TXdSb3NsNitJODNoNGN1cG1LV3NldGRnaSs0VHo0Y1FtL2ZuNDdK?= =?utf-8?B?Tkx2SjhGQVI2M3E3ajJKSWFyYS9qUDNXbkI0bWFPUmJDRFNCRVVSMGNHcTdr?= =?utf-8?B?TDRJVWJoalVQdEYwUUNBR1I0RXBMcTJ4cUIvQktEWU5xQ2ZlcUZYbjE0T28r?= =?utf-8?B?eUp1M1VPNjIwaXhIRXhqcHZ1TTdHZWtCUkVKRGh5TXk2U3JUbjdVdDhsQnVE?= =?utf-8?B?ZmNiWGROTVNjY0ZsUXZqckhRbk84YmtLK2d5Ymg1S3FPQm9RRjFnZHJRdHdv?= =?utf-8?B?WjNsRlduLzIyYis4cjVleGwwSXR2c3pPT2w1dngvT01ZYmJ3czR3QXZoWm5C?= =?utf-8?B?QVFuK3ZzaUY1R0pDNnFQZThZbloyNjNoYVJlVXJIMzdlRzVwL1pFM1ZuNExH?= =?utf-8?B?OEJNS1hnekNSZm94MHIwKzFZemZiR0ppVFFyNDdlWkNEQWFlcXFWTXRPVkRO?= =?utf-8?B?eGR0OFQvd1RLRnlpQ3Q5RVhGNjkvZzJIcEpsanpjYlRldm5kUkRNL1VqQ3N6?= =?utf-8?B?L29xWjN6S3NJbGhQaDRHMVhYanVaVHU5ekEvZGpjV2ZkMit2YjhWVDdtS3ll?= =?utf-8?B?N290cEVLZFVrY2RYNURwU1BadHZnNUJ2SEJQM2pCb3NJMEkrV3BGZURIV2lJ?= =?utf-8?B?WGJ1SjVVNFVDZW9qMXVQcVZUOEFVOGVqSGpwMDgwdEFBL3h3UlR6Ymt3aEl1?= =?utf-8?B?M1M5RWh2UTlhWThhaXpQUmVoaTVtc1JuanpRbk5idE1keHYrRnhlRGpIOE5H?= =?utf-8?B?LzhiNGJSUVEzWWlJZG4vaGZuTGVOM3RGV2pnUEJ3OEwyc1Uzc0xDRDd4QWw1?= =?utf-8?B?Y2RKQkZYWUxJVGgzK1FXWWVDUDNON29UUmErZHpxaHNJMmFlK2JwcmVIMXpQ?= =?utf-8?Q?alWjfXNMEyUNHVIZjuX33Sl0v?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: f92cfa58-a24a-4a4a-ff1a-08dc244279b1 X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2024 22:58:30.9108 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9sqCH9UUggn4Hr4fVIAygtFZ1PZT+LR76Uz6LxXZE76ULXRq7kAXa75WXUckuhWfxhuqxgSah0QWmJixjxrjvA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6821 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,thomas.lendacky@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: OxrpFHVkpua8TrKSxbBzoLj4x7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=PdaO6BBU; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 2/2/24 00:20, Ni, Ray wrote: >=20 >> + if (SevSnpUseCreateAP (CpuMpData)) { >=20 > 1. Is it possible to rename "SevSnpUseCreateAP" to some name starting > with "IsXXX"? > I originally mixed it with SevSnpCreateAP() and thought you created a > bug. "Is" doesn't really fit for this, how about UseSevSnpCreateAP() or=20 CanUseSevSnpCreateAP()? >=20 >=20 >> + GhcbApicIds =3D (GHCB_APIC_IDS *)(UINTN)PcdGet64 (PcdSevSnpApicIds)= ; >=20 > 2. Can you define a GUIDed HOB to hold the contents instead of dynamic PC= Ds? > Dynamic PCDs cannot tell whether the value is updated in earlier code or = still > holds the default value. > Also, I prefer to minimize the dynamic PCD usage in CPU code. Yep, will do. Thanks, Tom >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115072): https://edk2.groups.io/g/devel/message/115072 Mute This Topic: https://groups.io/mt/103986469/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-