From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mx.groups.io with SMTP id smtpd.web10.6946.1685739946549024945
 for <devel@edk2.groups.io>;
 Fri, 02 Jun 2023 14:05:46 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linux.microsoft.com header.s=default header.b=l968ohNf;
 spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com)
Received: from [192.168.4.22] (unknown [47.201.8.94])
	by linux.microsoft.com (Postfix) with ESMTPSA id 5520820B9C3D;
	Fri,  2 Jun 2023 14:05:45 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 5520820B9C3D
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
	s=default; t=1685739945;
	bh=WridgablvrN+6enwmB2RHQZPn0ZKFsEFP6McqKf0qbo=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=l968ohNfLZQHKMt4djsNA4zR+3ldBfQVQJTK2IK523uJo29w6qV7ey0lQNL1YbZO8
	 MmQG2gntz9IMQS3rEUwE8LO3TCechZPskLxbwbuGgseOPofC3qVsfRJZF5k6of38T2
	 MUUsw0J8WOl90OXwPXQaM8wTxx/UBBuSfA/zwlGA=
Message-ID: <6de6b94f-615c-3be8-edd0-169ec2a3f283@linux.microsoft.com>
Date: Fri, 2 Jun 2023 17:05:43 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [edk2-devel][PATCH v1 1/1] CharEncodingCheckPlugin: Remove Noisy Print
To: devel@edk2.groups.io, osde@linux.microsoft.com
Cc: Sean Brogan <sean.brogan@microsoft.com>,
 Michael D Kinney <michael.d.kinney@intel.com>,
 Liming Gao <gaoliming@byosoft.com.cn>
References: <20230602204504.1455-1-osde@linux.microsoft.com>
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
In-Reply-To: <20230602204504.1455-1-osde@linux.microsoft.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 6/2/2023 4:45 PM, Oliver Smith-Denny wrote:
> Currently, CharEncodingCheckPlugin prints a message for every
> file that passes the test, which for some platforms can cause
> most of the CI build log to be filled with this print. It does
> not add any value, so this patch removes the noisy print and
> only prints if the encoding check fails.
> 
> Github PR: https://github.com/tianocore/edk2/pull/4472
> 
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> 
> Signed-off-by: Oliver Smith-Denny <osde@linux.microsoft.com>
> ---
>   .pytool/Plugin/CharEncodingCheck/CharEncodingCheck.py | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/.pytool/Plugin/CharEncodingCheck/CharEncodingCheck.py b/.pytool/Plugin/CharEncodingCheck/CharEncodingCheck.py
> index b09fb1704087..07d9e9ce223e 100644
> --- a/.pytool/Plugin/CharEncodingCheck/CharEncodingCheck.py
> +++ b/.pytool/Plugin/CharEncodingCheck/CharEncodingCheck.py
> @@ -93,9 +93,7 @@ class CharEncodingCheck(ICiBuildPlugin):
>               files = [Edk2pathObj.GetAbsolutePathOnThisSystemFromEdk2RelativePath(x) for x in files]
>               for a in files:
>                   files_tested += 1
> -                if(self.TestEncodingOk(a, enc)):
> -                    logging.debug("File {0} Passed Encoding Check {1}".format(a, enc))
> -                else:
> +                if not self.TestEncodingOk(a, enc):
>                       tc.LogStdError("Encoding Failure in {0}.  Not {1}".format(a, enc))
>                       overall_status += 1
>