From: "Benjamin Doron" <benjamin.doron00@gmail.com>
To: devel@edk2.groups.io
Cc: Chasel Chiu <chasel.chiu@intel.com>,
Nate DeSimone <nathaniel.l.desimone@intel.com>,
Rangasai V Chaganty <rangasai.v.chaganty@intel.com>,
Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>,
Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
Subject: [edk2-devel][edk2-platforms][PATCH v1 2/4] CometlakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile
Date: Tue, 6 Sep 2022 12:55:22 -0400 [thread overview]
Message-ID: <6e0303689772f9494865150d6a3b9171655f80a4.1662482547.git.benjamin.doron00@gmail.com> (raw)
In-Reply-To: <cover.1662482547.git.benjamin.doron00@gmail.com>
Follow AcpiPlatformDxe (from which this module is derived) and install
all ACPI tables added by board.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
Cc: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
Signed-off-by: Benjamin Doron <benjamin.doron00@gmail.com>
---
.../Acpi/BoardAcpiDxe/BoardAcpiDxe.c | 15 ++++++++++++++-
.../Acpi/BoardAcpiDxe/BoardAcpiDxe.inf | 2 ++
2 files changed, 16 insertions(+), 1 deletion(-)
diff --git a/Platform/Intel/CometlakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c b/Platform/Intel/CometlakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c
index 7fc71bca644a..ba59c84fd4ba 100644
--- a/Platform/Intel/CometlakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c
+++ b/Platform/Intel/CometlakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.c
@@ -270,7 +270,20 @@ InstallAcpiBoard (
//
// Platform ACPI Tables
//
- PublishAcpiTablesFromFv (&gEfiCallerIdGuid);
+ Status = PublishAcpiTablesFromFv (&gEfiCallerIdGuid);
+ if (EFI_ERROR (Status)) {
+ DEBUG ((DEBUG_ERROR, "Error: PublishAcpiTablesFromFv[%g] - %r", &gEfiCallerIdGuid, Status));
+ }
+ Status = PublishAcpiTablesFromFv (PcdGetPtr (PcdAcpiTableStorageFile));
+ if (EFI_ERROR (Status)) {
+ DEBUG ((
+ DEBUG_ERROR,
+ "Error: PublishAcpiTablesFromFv[%g] - %r",
+ PcdGetPtr (PcdAcpiTableStorageFile),
+ Status
+ ));
+ DEBUG ((DEBUG_INFO, "Does board contain ACPI tables?\n"));
+ }
//
// This protocol publish must be done after PublishAcpiTablesFromFv.
diff --git a/Platform/Intel/CometlakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf b/Platform/Intel/CometlakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf
index 09b67376fbc1..e201964a6896 100644
--- a/Platform/Intel/CometlakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf
+++ b/Platform/Intel/CometlakeOpenBoardPkg/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf
@@ -62,6 +62,8 @@
gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemBase
gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemLimit
+ gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiTableStorageFile
+
[Depex]
gEfiAcpiTableProtocolGuid AND
gEfiFirmwareVolume2ProtocolGuid AND
--
2.37.2
next prev parent reply other threads:[~2022-09-06 16:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 16:55 [edk2-devel][edk2-platforms][PATCH v1 0/4] Platform/Intel: Benjamin Doron
2022-09-06 16:55 ` [edk2-devel][edk2-platforms][PATCH v1 1/4] KabylakeOpenBoardPkg/Acpi: BoardAcpiDxe also installs all PcdAcpiTableStorageFile Benjamin Doron
2022-09-06 16:55 ` Benjamin Doron [this message]
2022-09-06 16:55 ` [edk2-devel][edk2-platforms][PATCH v1 3/4] MinPlatformPkg/Acpi: MinDsdt " Benjamin Doron
2022-09-06 16:55 ` [edk2-devel][edk2-platforms][PATCH v1 4/4] WhiskeylakeOpenBoardPkg/Acpi: BoardAcpiDxe " Benjamin Doron
-- strict thread matches above, loose matches on Subject: below --
2021-08-04 21:27 [edk2-platforms][PATCH v1 2/4] CometlakeOpenBoardPkg/Acpi: " Chaganty, Rangasai V
2021-08-04 21:51 ` [edk2-devel] " Benjamin Doron
2021-08-04 22:25 ` Nate DeSimone
2021-09-04 21:50 ` Benjamin Doron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e0303689772f9494865150d6a3b9171655f80a4.1662482547.git.benjamin.doron00@gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox