From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2014B940523 for ; Fri, 19 Jan 2024 04:43:55 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=9VAsCf1m4uuKWQH7vjb488P2ezvh2ol00dqKnG0zfBw=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1705639434; v=1; b=iMIHUjZcZU3rojJhkNmTneZtRA2GWwvbpsnbmOJ2hQtgcuMhHjPVOCISHMQfJO4R6zTN79t9 MX3KFqD8vsHksRKUPgafDQ5DdOQRqYP/jxdr58r0qcDnldJ5Ve+z8pm+bYJHnuAo4TZkImINJ9q 5h+NSaffdB3Rz3H9TK7D3qBw= X-Received: by 127.0.0.2 with SMTP id cFT5YY7687511xxsmeNMx2jw; Thu, 18 Jan 2024 20:43:54 -0800 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.126]) by mx.groups.io with SMTP id smtpd.web11.14832.1705639434011450348 for ; Thu, 18 Jan 2024 20:43:54 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LWQCpJD9fcakanBYlAph7c/6LCFwAUoVLsiM4dZstaLqBZVzEtcVcAsgMCLCgeyCUgmtnSO5pwsKoUH+EbDsHYMIFBTq9TFtDOgvidiBuVbIgesUqN63QVrisbnalQlHdFkhJR8/4yFIiIWo8gKDVj2uYqTtKl/Gg+wPbRQMKLJ4DNbuOjmSFGUuAEhtDYJwTiF3/1XfnKEnWA97V1GJs+qaN7PBwn2Tnvb2oDT5nCACpf+Cu+XZuFHQ7RbPsHgJzNjksSQfQYTNvfJSWHR1vVHo9iOG3VAtfcHNAwQp6LrMlSt9OF56XXqXSnEYhFosIIX7RMutTfLQ9uJMVmKtNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ev6UL0Oz0UXXfUuqVitemHGCc8No5gzPwWIDo8UR2j0=; b=ogimKcqQCU61TG2dij6rC+8qOQjoP4q7cFjSKWPpS1L3IZdYwXAuYBgopzRSgyTj6RJx7k2Z/VcGMq21Yzika5Tznp2mkUgntDgzGYsKS5teLfKOE8OXhAw9DnI0eMX/v+AGY0YBniexKsVQskdPlFcADlzmQh6hvfMQXgxQ0W+TamvmKA/EHQyGYRGRRCAhccB6MGoG9h4Ta6Gt0QHgiLIbw1JOn4HrO1jLpaEdE7vOPa9hDihPsNI/tiguKRRxT2dRfX4lK6MMmprwTizxcB6BYzQMSvtlgxxV1ou3HEcF4FLs2TJKyzt2bATOxJurTmf4yjKxmnt/3ZCa15dycQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by BN0PR01MB7183.prod.exchangelabs.com (2603:10b6:408:15a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.24; Fri, 19 Jan 2024 04:43:50 +0000 X-Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::d2bd:7ad:570c:9dc8]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::d2bd:7ad:570c:9dc8%6]) with mapi id 15.20.7202.024; Fri, 19 Jan 2024 04:43:50 +0000 Message-ID: <6e09ed4a-53b0-45e1-a070-b4086986876b@os.amperecomputing.com> Date: Fri, 19 Jan 2024 11:43:43 +0700 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] Memory Attribute for depex section To: Laszlo Ersek , Ard Biesheuvel Cc: "Andrew (EFI) Fish" , edk2-devel-groups-io , "ardb+tianocore@kernel.org" References: <44ca139f-4d78-4322-b5b6-8e9788bb7486@os.amperecomputing.com> <2ad16043-754e-3bb9-3a4a-702d9a50bf63@redhat.com> <45b95719-f1fc-dbc6-a4cc-a022d691844c@redhat.com> <8d745268-263c-c99a-67c6-fe0fb6cd4b8e@redhat.com> <0e0b2e56-30dd-4f5f-9708-98690246efda@os.amperecomputing.com> <20d8728f-daaa-51ed-18ad-3087695d21f1@redhat.com> <8efe1653-7383-44a6-b820-efb1c6132f74@os.amperecomputing.com> <40d61bec-49c1-e560-7d6b-05c789b2b5f6@redhat.com> From: "Nhi Pham via groups.io" In-Reply-To: <40d61bec-49c1-e560-7d6b-05c789b2b5f6@redhat.com> X-ClientProxiedBy: SI1PR02CA0044.apcprd02.prod.outlook.com (2603:1096:4:1f6::6) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB7287:EE_|BN0PR01MB7183:EE_ X-MS-Office365-Filtering-Correlation-Id: 460c2040-0ab4-4fb8-ca95-08dc18a93b48 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: SxB1Y3HBBcU1NvQeCoZC6JA+EOolVReh6NIHSDGYFqslwLQAsk3zOMXPAphllPKjYHyVuIcQTXED/u1qR8VWW7M5J6TFy3m+XvWeIyAvqYhA5eRPiWlSl1lYVjWeeAijPloDF2hNMxkdZp4KdsaYx7F2x6IMdfVVphEoeAO8rL0hTiZwVwtdzoO5RjjzRxsIAGXaZ/iSBBszp+X1Vr8nZ21nxPJ95b5VKLDQ+h6YQzJ0j11AnX8qvGD7Q7DSOqw9+g2K/ZxA9pYu11KS8hUiFJV2e04HHggITGe4lwftbnKIt6wqRIAqhMqr8loyjmkms0lQwRRK6FoyrztMhkt5VcgH73Xoc/EANreJ9qOS8LI3xlBqUp/5skSFBkaVlZdjERZnK2qInL6i0t6ZYl/njnxfqb0fuF9NQTb2Z/H9WmUKGugK25p27ldpyqTcjUsu5gczGIFwkjTBo8/GTKObcb+X7jlEFGevEBNrsu7ui/wzOWh5HZy5Re8ekfrbTYf8xvZjWqzuSS2rER1aVkqgVFYJ/v8ZVvlU2hTAIPA/d0giVrQM6aXerCTMYLQsNvWb31A+/CW55QGEcZugR2p57FZ2cOfnNsqXCK4Ws+LRqULCejpA8k48Afi1OBbBLng7 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QmVHQnIrYmVUZ2JnSUZTajRwcjYvWWZOTHpKWEwzTlc0eXNTS0VSdmc1am5M?= =?utf-8?B?MjczMzkyL2tZV25ObVF3SEdMNitoYUJ6R2doYStYaTJIb3JTSDM4MExPRXpq?= =?utf-8?B?QUdCSnlGRUVyWGQ1SmJjOWl6SGtNVFN1Vnh1Mk5GaHFhNDdLeWNyZXp0cUxh?= =?utf-8?B?YUlySWw0NVViZFVvRERvaEdobkxpTWxOVzZCbVVndXdpNlF3Z1Y4YnR1S0hV?= =?utf-8?B?cVNsWDAxdSsrQ20vb2FNV3FTN3lQeTl4N05Ia1E3dUs0WTF2QnIydkZJaHpT?= =?utf-8?B?QnM5dndOYzkzOVcxOGNSa1ZoV0lvZ1RiL3haU2NhWkdubVcyYWhuSVduaS9E?= =?utf-8?B?ZG82VW9uRmI1bjNxWFdkR1RRMXlUWnhBREdGV01kTURoTDlqWUkrYnZtQjNn?= =?utf-8?B?N0kxaTJMTHczQm9sWDNVRy84TEtKWmg5UGRIdzRhbm41aEdGQ3RFaFpNenU5?= =?utf-8?B?cG85Sm9jKzdwMEg5bzIzVE9HREZXeDBtd2c0eVVlRlBzY09yWGFaekRjSzg3?= =?utf-8?B?SlNFUEFPVnNVdUV1Z2dWbnpVL2pUUFRQK1gyK3VmbzJscjF4OHlUZGgySWgw?= =?utf-8?B?K0RGSDNqTDBOK3M5ZTVoZTVMcEdBN2FCRXQ0a0tjQWlkVjZ1c29rZmc5YTNM?= =?utf-8?B?bzZBaVgxb0Z1NmZMd0RpVHNWOFBEclJvL203SlRjRGlzK0lWZGR0NkJ3L2F1?= =?utf-8?B?S3lYUkNnaGV5cVRVY0hNQzR6YktFOUl3dkE5U0FEZGhJZ0hxdkV5aFY0NWc3?= =?utf-8?B?ZW5Say9aVDlLMW5FZlpLS1hjOWdXakZVZ3puSGdGS3BOMUxNL05hWitYeHZn?= =?utf-8?B?bHQxWk1WdDZ1dFV5eDZRQlBCZDhyY2hFZTFHSnpGOVdaSkM2R2NnY0tDSGZP?= =?utf-8?B?ek55UUxld01HNFFmZldwbndWTi82TWlZRHYrQUNndlpSMDJvN0ZHcEtjc3Vl?= =?utf-8?B?WjBINzRkZlBkUnUyOU10WHFZanVtbmx3cEgxa1ovSTkwSUhZSENQaU5SNkk3?= =?utf-8?B?T252VTlCSnR4RXVyUGE4aGVyVGZrbE1FdUQ2Sk5Sc0M0MmFSaW1SWFhwM0t0?= =?utf-8?B?OHladFlqYnNwOEdQS2FDWHNnR1gwdCtPcWZ4Q0VIM1p2Q3J0cFBSUHNvZy9v?= =?utf-8?B?VzRJTG9HY0l0dVBFWkpaSC9WS1hwZEpDcHdVcjRtd1JIcFNWaE9VWU8zK2M0?= =?utf-8?B?M1VQaTl1MVNEdGM5a3VCVnNkaWZ1SnJwcmJ5NXVEbnZ6aEcwNFZIK2YyL210?= =?utf-8?B?a3hwWCtmUzFSM1hKT0JBcEFtaDluVXJMZ3ZSSUs3WUt5MnpJVjdyRE9KRDV5?= =?utf-8?B?c1hTMXpSMTJ0QTd4L3V6clVUTnZQZjVub0NWMXJYcDNaV3Vzc0RXWFhTZXE1?= =?utf-8?B?Y1dXbmVnb1B0czk0QmFSUVU4MTFRVjFsMEVuVWwyNmxXeGpHVEhrK1dVcUd3?= =?utf-8?B?YzZsVjBIUEx5ME1TakRaZkNnYWhzVjd4ZjJ6a0IxZTlLNm82RFJmUHZvUjJo?= =?utf-8?B?NGZ6MzcrQkdWOTAyVFZXNW1Hd1VwakdEemwzYVZuS05PNXJYSWxyNmJaL2gv?= =?utf-8?B?Qkh1YlRQeG1KaVMwNDNTMVBSTlQ5MkFTU2ZJTkluZWFGakNEblNGWVlBVHVZ?= =?utf-8?B?c1BKWjMzb21UMkV3KzF5bGs5T0ZVUDA5V29wWlk1VFhwZ1pQWWQ5Yjl3WmNj?= =?utf-8?B?MlBlS25JMGVTRk5sakoyV2ZSWWIyblcwSG9Kdy9QWnNLSW1BV3IrYXBTRzQz?= =?utf-8?B?b1dZcnRBbjdPbldKZUVsclRXaE9WMU9mOUpvRS92anUya0pJZnhZL3JDRWtW?= =?utf-8?B?bklBNUNhUEZMLy9Bdm9zVnlhaWZTSmRmQTU0c3V3WnZXUGdDazJHZXVVZ1d1?= =?utf-8?B?Kzh2N1M5YmxpZWEzc2tTNnNQRVFucS9KRTh0R2dYemFzNENqOVpXTk9vLzQ3?= =?utf-8?B?ZDNJU3l5QitFUGJwMkMrRUxKenU5V1NjY25wck1zemV3VUhqR0pVTkY4cE9l?= =?utf-8?B?SVVoZGYvRXg2WExCNVdBRXdkVWhIdG1wakxPR2dXV05tRFEvYUc5MURkanhG?= =?utf-8?B?OUxSM1JBVDc0TnhGUVIrVEFRcDR3S2tCYVcwUzFmNENZS3FseFZRa1FWeTl1?= =?utf-8?B?bTVWSW9hWFpRTjNUOWEvVGxmWVBxeThxTm5Rb2dZN2REVVlLckYxMlN6M0ZZ?= =?utf-8?B?R0E9PQ==?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 460c2040-0ab4-4fb8-ca95-08dc18a93b48 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2024 04:43:50.4257 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NZOBvvKzRO0v66U9dQZxKbFSrRw0DMcqmD152UkAcGIXpjf3WAIezx6zZK1FgXO1ZZZQloVeDL5+8JaiujtTANaLvFU7a+4eNmNVFbCqTDo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR01MB7183 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nhi@os.amperecomputing.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 6ab30NcRulBfjCuikDoVkBkZx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=iMIHUjZc; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 1/18/2024 9:49 PM, Laszlo Ersek wrote: >>>> but I'd prefer to just remove this >>>> optimization from standalone MM, given that not only a) it shouldn't >>>> have to deal with a large number of protocol GUIDs, but also b) the >>>> driver dispatch is much more straight-forward. (Typically, StMM >>>> drivers can be dispatched in the order they appear in the firmware >>>> volume, in which case each DEPEX is evaluated only once anyway) >>> >>> Sounds like a promising basis for removing the optimization indeed! >>> >> >> Your patch suggested earlier works for me. And I don't see significant >> performance reduction compared with keeping optimization. >> >> I don't have strong reason on removing the optimization, but I think it >> would be simply good for now. Could you post your patch to edk2-devel >> for review and merge? >=20 > That wouldn't be correct; I don't have any platform for testing StMM. I > proposed the patch purely based on code analysis. I prefer not to post > untested patches, if I can avoid it. I got it, thanks! I thought I could give Tested-by tag when you post the patch since I=20 already verified the patch on a StMM platform >=20 > You can however post my patch; simply add your S-o-b at the bottom. You > can also preserve my authorship on the patch with --author=3D... on > git-commit; but even that is unnecessary for such a simple patch (you > don't even have to pick the patch up from the email, it's trivial to > reimplement from scratch, just reading the email). I'm going to send the patch to edk2-devel and keep your authorship on=20 the patch because there is no change compared with your suggestion in=20 the email. Thanks, Nhi -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114024): https://edk2.groups.io/g/devel/message/114024 Mute This Topic: https://groups.io/mt/103594587/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-