From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 98B331A1E57
 for <edk2-devel@ml01.01.org>; Tue, 25 Oct 2016 01:25:24 -0700 (PDT)
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
 (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id EE76DC00829A;
 Tue, 25 Oct 2016 08:25:23 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-71.phx2.redhat.com
 [10.3.116.71])
 by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id
 u9P8PMeF032734; Tue, 25 Oct 2016 04:25:23 -0400
To: edk2-devel-01 <edk2-devel@ml01.01.org>
References: <20161021212737.15974-1-lersek@redhat.com>
 <20161021212737.15974-20-lersek@redhat.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <6e3e7956-be37-3a83-53ea-6abfb3111704@redhat.com>
Date: Tue, 25 Oct 2016 10:25:22 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <20161021212737.15974-20-lersek@redhat.com>
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.32]); Tue, 25 Oct 2016 08:25:24 +0000 (UTC)
Subject: Re: [PATCH 19/19] ArmVirtPkg: disable deprecated interfaces
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Oct 2016 08:25:24 -0000
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit

Ard,

On 10/21/16 23:27, Laszlo Ersek wrote:
> At this point no code in ArmVirtPkg (and apparently no code outside of
> ArmVirtPkg that the ArmVirt binaries depend on) uses the deprecated APIs,
> so we can disable them in the common platform DSC include file:
> 
> BaseLib:
> - StrCpy
> - StrnCpy
> - StrCat
> - StrnCat
> - UnicodeStrToAsciiStr
> - AsciiStrCpy
> - AsciiStrnCpy
> - AsciiStrCat
> - AsciiStrnCat
> - AsciiStrToUnicodeStr
> 
> PcdLib:
> - PcdSet8
> - PcdSet16
> - PcdSet32
> - PcdSet64
> - PcdSetPtr
> - PcdSetBool
> - PcdSetEx8
> - PcdSetEx16
> - PcdSetEx32
> - PcdSetEx64
> - PcdSetExPtr
> - PcdSetExBool
> 
> UefiLib:
> - GetVariable
> - GetEfiGlobalVariable
> 
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> 
> Notes:
>     not build-tested with RVCT
> 
>  ArmVirtPkg/ArmVirt.dsc.inc | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
> index c071988ad8f5..dbd6678accde 100644
> --- a/ArmVirtPkg/ArmVirt.dsc.inc
> +++ b/ArmVirtPkg/ArmVirt.dsc.inc
> @@ -246,6 +246,12 @@ [BuildOptions]
>  
>    GCC:RELEASE_*_*_CC_FLAGS  = -DMDEPKG_NDEBUG
>  
> +  #
> +  # Disable deprecated APIs.
> +  #
> +  RVCT:*_*_*_CC_FLAGS = -DDISABLE_NEW_DEPRECATED_INTERFACES
> +  GCC:*_*_*_CC_FLAGS = -DDISABLE_NEW_DEPRECATED_INTERFACES
> +
>  ################################################################################
>  #
>  # Pcd Section - list of all EDK II PCD Entries defined by this Platform
> 

Can you please give an R-b for this too?

Thanks
Laszlo