public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: Michael Kubacki <michael.kubacki@outlook.com>, devel@edk2.groups.io
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>,
	Siyuan Fu <siyuan.fu@intel.com>,
	Liming Gao <liming.gao@intel.com>,
	Michael D Kinney <michael.d.kinney@intel.com>,
	Maciej Rabeda <maciej.rabeda@linux.intel.com>,
	Jian J Wang <jian.j.wang@intel.com>,
	Jiaxin Wu <jiaxin.wu@intel.com>, Hao A Wu <hao.a.wu@intel.com>
Subject: Re: [edk2-devel] [PATCH v3 0/3] Return GetVariable() attr if EFI_BUFFER_TOO_SMALL
Date: Wed, 1 Apr 2020 11:00:22 +0200	[thread overview]
Message-ID: <6e415570-74d2-ef86-7941-c5000912c1b5@redhat.com> (raw)
In-Reply-To: <MWHPR07MB3440A05075F98D2AAC69455DE9C90@MWHPR07MB3440.namprd07.prod.outlook.com>

On 04/01/20 03:15, Michael Kubacki wrote:
> I have those options set correctly in git config.
> 
> After a quick look, as far as I can tell, this is because the
> Message-Id in my email is modified such the the In-Reply-To and
> References headers do not refer to the actual Message-Id in the cover
> letter:
> 
> Cover letter:
> 
> Subject: [edk2-devel] [PATCH v3 0/3] Return GetVariable() attr if
> EFI_BUFFER_TOO_SMALL
> Date: Fri, 27 Mar 2020 14:55:33 -0700
> Message-Id: <160047F24E1D38F5.15390@groups.io>
> 
> The original Message-Id in the cover letter was moved to
> X-Microsoft-Original-Message-Id:
> 
> X-Microsoft-Original-Message-ID:
>  <20200327215536.9556-1-michael.kubacki@outlook.com>
> 
> The first patch in the series:
> 
> Subject: [edk2-devel] [PATCH v3 1/3] MdeModulePkg Variable: Return
> GetVariable() attr if EFI_BUFFER_TOO_SMALL
> Date: Fri, 27 Mar 2020 14:55:34 -0700
> Message-Id: <160047F33E58AD06.17905@groups.io>
> In-Reply-To: <20200327215536.9556-1-michael.kubacki@outlook.com>
> References: <20200327215536.9556-1-michael.kubacki@outlook.com>
> 
> Please let me know if you have suggestions. I'll look into it more.

(1) *Normally*, here's what I would tell you:

Please log in to your groups.io account, and navigate to the following
setting:

Your name (upper right corner)
  Account
    Preferences (top of left sidebar)
      I always want copies of my own emails (checkbox at the bottom)

Please *untick* this checkbox.

The name of the checkbox is very misleading. The actual behavior is the
following:

  "I am a gmail user, and gmail de-duplicates messages that are sent to
   me both directly, and reflected through the mailing list. As a
   special case, the same de-duplication applies to messages I send to
   the list, and are reflected to me by the list -- gmail just hides
   those from me as "seen". I don't like this; I want my reflected
   copies of messages that I sent. Because the de-duplication is
   Message-ID based, groups.io should please falsify the Message-ID on
   those messages that I send *AND* are delivered back to me *only*"

Meaning, if you have this box checked, then groups.io places
<....@groups.io>-style message IDs in the emails that it sends back *to
you* (only to you) *and* that originate from you.


(2) *However*, that is not the problem here. (Or, more precisely, not
the only problem.) Because, as I say above, this message-ID
re-generation by groups.io only applies to *you*; so the threading of
your patch series would only be broken in *your* list folder, not in
mine (or in any other list subscriber's).

But, the threading *is* broken on my end too.

And the reason for that is that the SMTP server that you use, ignores
the Message-ID put in place by git-send-email, and generates its own.

Your original message ID (as stated above), from git-send-email, is:

  20200327215536.9556-1-michael.kubacki@outlook.com

But the message ID in my list folder is:

  MWHPR07MB3440A69B5AFAD0E373974FBFE9CC0@MWHPR07MB3440.namprd07.prod.outlook.com

Therefore, the original message-id (from git-send-email) is not moved to
the X-Microsoft-Original-Message-ID header by groups.io -- instead, it
is moved there by your SMTP server, at <outlook.com>.

Can you disable that somehow? It is incorrect behavior. An SMTP server
itself should only put a Message-ID on an outgoing email if that email
doesn't already come with one.

To summarize, there are two issues:

(a) your groups.io account settings have the gmail-oriented Message-ID
falsification enabled, which breaks threading for you (and only for you)

(b) your SMTP server overwrites the git-send-email-generated Message-ID
with its own, which breaks threading for every list subscriber
(including you).

You can easily remedy (a) in your groups.io account settings. Not sure
how you can fix problem (b) -- can you use a different SMTP server
maybe?

(I've been very happy that we've finally seen patches posted to the list
from a @microsoft.com email address -- it would be fantastic if that
continued, with the threading fixed even!)

Thanks!
Laszlo


      reply	other threads:[~2020-04-01  9:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-27 21:55 [PATCH v3 0/3] Return GetVariable() attr if EFI_BUFFER_TOO_SMALL Michael Kubacki
2020-03-31 23:55 ` [edk2-devel] " Laszlo Ersek
2020-04-01  1:15   ` Michael Kubacki
2020-04-01  9:00     ` Laszlo Ersek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6e415570-74d2-ef86-7941-c5000912c1b5@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox