From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web10.2299.1585731633590064525 for ; Wed, 01 Apr 2020 02:00:33 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=OZSrCj38; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585731632; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LHh5vLUA/xKfr94YHCmakeWnSekLmCBZgouhzBXlUpA=; b=OZSrCj38K2SrTzvTNQeLjHcIyiB8dA9bG5joXmkX6u0NxrshzDjzXjQ6imn/3pRIfmR2kT mgM5P56mdl5kZtZkn/Oi0bsGDOeGpvujG1j0bO2fne0DDSeD5jnbzPHZ6/WK1C69y67PgB 7w/wpm0kG5Dhqa27aEK77gghv7az3YU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-226-WJoFwwSPNz6ZCQMLkWwZMw-1; Wed, 01 Apr 2020 05:00:27 -0400 X-MC-Unique: WJoFwwSPNz6ZCQMLkWwZMw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id ABE311007276; Wed, 1 Apr 2020 09:00:25 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-94.ams2.redhat.com [10.36.114.94]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3F49F60BE1; Wed, 1 Apr 2020 09:00:23 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v3 0/3] Return GetVariable() attr if EFI_BUFFER_TOO_SMALL To: Michael Kubacki , devel@edk2.groups.io Cc: Bret Barkelew , Siyuan Fu , Liming Gao , Michael D Kinney , Maciej Rabeda , Jian J Wang , Jiaxin Wu , Hao A Wu References: <58fc3ce6-b279-3974-a43d-803fe75bd964@redhat.com> From: "Laszlo Ersek" Message-ID: <6e415570-74d2-ef86-7941-c5000912c1b5@redhat.com> Date: Wed, 1 Apr 2020 11:00:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 04/01/20 03:15, Michael Kubacki wrote: > I have those options set correctly in git config. > > After a quick look, as far as I can tell, this is because the > Message-Id in my email is modified such the the In-Reply-To and > References headers do not refer to the actual Message-Id in the cover > letter: > > Cover letter: > > Subject: [edk2-devel] [PATCH v3 0/3] Return GetVariable() attr if > EFI_BUFFER_TOO_SMALL > Date: Fri, 27 Mar 2020 14:55:33 -0700 > Message-Id: <160047F24E1D38F5.15390@groups.io> > > The original Message-Id in the cover letter was moved to > X-Microsoft-Original-Message-Id: > > X-Microsoft-Original-Message-ID: > <20200327215536.9556-1-michael.kubacki@outlook.com> > > The first patch in the series: > > Subject: [edk2-devel] [PATCH v3 1/3] MdeModulePkg Variable: Return > GetVariable() attr if EFI_BUFFER_TOO_SMALL > Date: Fri, 27 Mar 2020 14:55:34 -0700 > Message-Id: <160047F33E58AD06.17905@groups.io> > In-Reply-To: <20200327215536.9556-1-michael.kubacki@outlook.com> > References: <20200327215536.9556-1-michael.kubacki@outlook.com> > > Please let me know if you have suggestions. I'll look into it more. (1) *Normally*, here's what I would tell you: Please log in to your groups.io account, and navigate to the following setting: Your name (upper right corner) Account Preferences (top of left sidebar) I always want copies of my own emails (checkbox at the bottom) Please *untick* this checkbox. The name of the checkbox is very misleading. The actual behavior is the following: "I am a gmail user, and gmail de-duplicates messages that are sent to me both directly, and reflected through the mailing list. As a special case, the same de-duplication applies to messages I send to the list, and are reflected to me by the list -- gmail just hides those from me as "seen". I don't like this; I want my reflected copies of messages that I sent. Because the de-duplication is Message-ID based, groups.io should please falsify the Message-ID on those messages that I send *AND* are delivered back to me *only*" Meaning, if you have this box checked, then groups.io places <....@groups.io>-style message IDs in the emails that it sends back *to you* (only to you) *and* that originate from you. (2) *However*, that is not the problem here. (Or, more precisely, not the only problem.) Because, as I say above, this message-ID re-generation by groups.io only applies to *you*; so the threading of your patch series would only be broken in *your* list folder, not in mine (or in any other list subscriber's). But, the threading *is* broken on my end too. And the reason for that is that the SMTP server that you use, ignores the Message-ID put in place by git-send-email, and generates its own. Your original message ID (as stated above), from git-send-email, is: 20200327215536.9556-1-michael.kubacki@outlook.com But the message ID in my list folder is: MWHPR07MB3440A69B5AFAD0E373974FBFE9CC0@MWHPR07MB3440.namprd07.prod.outlook.com Therefore, the original message-id (from git-send-email) is not moved to the X-Microsoft-Original-Message-ID header by groups.io -- instead, it is moved there by your SMTP server, at . Can you disable that somehow? It is incorrect behavior. An SMTP server itself should only put a Message-ID on an outgoing email if that email doesn't already come with one. To summarize, there are two issues: (a) your groups.io account settings have the gmail-oriented Message-ID falsification enabled, which breaks threading for you (and only for you) (b) your SMTP server overwrites the git-send-email-generated Message-ID with its own, which breaks threading for every list subscriber (including you). You can easily remedy (a) in your groups.io account settings. Not sure how you can fix problem (b) -- can you use a different SMTP server maybe? (I've been very happy that we've finally seen patches posted to the list from a @microsoft.com email address -- it would be fantastic if that continued, with the threading fixed even!) Thanks! Laszlo