public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, lichao@loongson.cn
Cc: Michael D Kinney <michael.d.kinney@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Zhiguang Liu <zhiguang.liu@intel.com>,
	Eric Dong <eric.dong@intel.com>, Ray Ni <ray.ni@intel.com>,
	Rahul Kumar <rahul1.kumar@intel.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Leif Lindholm <quic_llindhol@quicinc.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Abner Chang <abner.chang@amd.com>,
	Daniel Schaefer <git@danielschaefer.me>,
	Sami Mujawar <sami.mujawar@arm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Jordan Justen <jordan.l.justen@intel.com>
Subject: Re: [edk2-devel] [PATCH v1 00/29] Enable LoongArch virtual machine in edk2
Date: Fri, 3 Nov 2023 08:07:26 +0100	[thread overview]
Message-ID: <6e509596-e480-3256-ba54-964c1b47f0f5@redhat.com> (raw)
In-Reply-To: <20231103010302.4052990-1-lichao@loongson.cn>

On 11/3/23 02:03, Chao Li wrote:
> This patch set will enable LoongArch virtual machine in edk2, the new
> LoongArch virtual machine is located in OvmfPkg/LoongArchVirt/, it is a
> generic platform that dose not require any actual hardware.
> 
> Patch1-Patch14: Submit the common library and driver for LoongArch
> virtual machine and real hardware. Such as base help functions,
> exception handel, MMU library, multiprocessor library etc.
> 
> Patch15-Patch16: Add PrePiCpuIoSize for LoongArch64. and move ArmVirtPkg
> two PCDs into OvmfPkg for easier use by other architectures.
> 
> Patch17-Patch29: LoongArch virtual machine private code, include SEC and
> PEI phase code, some library and drivers.
> 
> Modfied modues: MdePkg, UefiCpuPkg, EmbeddedPkg, ArmVirtPkg, OvmfPkg.
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584
> 

[...]

>  127 files changed, 18478 insertions(+), 84 deletions(-)

18478 lines seem overkill... Probably too much code added / duplicated
under UefiCpuPkg, as Ray says.

Also:

- Please make sure you post the patches with the "sendemail.thread" git
config item set to "true". "BaseTools/Scripts/SetupGit.py" takes care of
that. Otherwise, just as it has now happened, your patches are not
threaded under the cover letter; they fly apart as independent messages.

- Whenever you post a (new or initial) version of a patch set, please
link the URL of the cover letter (from the mailing list archive) into
the Bugzilla ticket, in a new comment.

Thanks
Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110610): https://edk2.groups.io/g/devel/message/110610
Mute This Topic: https://groups.io/mt/102355705/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  parent reply	other threads:[~2023-11-03  7:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-03  1:03 [edk2-devel] [PATCH v1 00/29] Enable LoongArch virtual machine in edk2 Chao Li
2023-11-03  5:10 ` Ni, Ray
2023-11-03  7:08   ` Chao Li
2023-11-03  7:51     ` maobibo
2023-11-03  8:09       ` Chao Li
2023-11-03  8:16         ` maobibo
2023-11-03  7:07 ` Laszlo Ersek [this message]
2023-11-03  7:32   ` Chao Li
2023-11-03  7:40     ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6e509596-e480-3256-ba54-964c1b47f0f5@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox