From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C06542214673B for ; Mon, 26 Mar 2018 07:55:40 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 86E888D682; Mon, 26 Mar 2018 15:02:15 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-34.rdu2.redhat.com [10.10.121.34]) by smtp.corp.redhat.com (Postfix) with ESMTP id B4E8AD7DF2; Mon, 26 Mar 2018 15:02:14 +0000 (UTC) To: "Ni, Ruiyu" , Ard Biesheuvel Cc: edk2-devel-01 , Rocky References: <20180323215714.27542-1-lersek@redhat.com> From: Laszlo Ersek Message-ID: <6e6e6c0c-ad9a-459e-621a-5523e7f129a3@redhat.com> Date: Mon, 26 Mar 2018 17:02:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Mon, 26 Mar 2018 15:02:15 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Mon, 26 Mar 2018 15:02:15 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH] OvmfPkg/QemuVideoDxe: handle invalid BltOperation gracefully X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Mar 2018 14:55:41 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 03/26/18 03:26, Ni, Ruiyu wrote: > On 3/24/2018 11:52 AM, Ard Biesheuvel wrote: >> On 23 March 2018 at 21:57, Laszlo Ersek wrote: >>> According to the UEFI spec, EFI_GRAPHICS_OUTPUT_PROTOCOL.Blt() is >>> supposed >>> to catch an invalid BltOperation, and report it with >>> EFI_INVALID_PARAMETER. >>> >>> Remove the assertion from QemuVideoGraphicsOutputBlt() that prevents >>> this >>> from working in NOOPT and DEBUG builds. >>> >>> Cc: Ard Biesheuvel >>> Cc: Rocky >>> Cc: Ruiyu Ni >>> Reported-by: Rocky >>> Analyzed-by: Ruiyu Ni >>> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=897 >>> Contributed-under: TianoCore Contribution Agreement 1.1 >>> Signed-off-by: Laszlo Ersek >> >> Reviewed-by: Ard Biesheuvel >> >>> --- >>> >>> Notes: >>>      Repo:   https://github.com/lersek/edk2.git >>>      Branch: qemuvideo_invalid_bltop >>> >>>   OvmfPkg/QemuVideoDxe/Gop.c | 2 +- >>>   1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/OvmfPkg/QemuVideoDxe/Gop.c b/OvmfPkg/QemuVideoDxe/Gop.c >>> index b479d24a8763..d51efc2a83d5 100644 >>> --- a/OvmfPkg/QemuVideoDxe/Gop.c >>> +++ b/OvmfPkg/QemuVideoDxe/Gop.c >>> @@ -366,7 +366,7 @@ Returns: >>> >>>     default: >>>       Status = EFI_INVALID_PARAMETER; >>> -    ASSERT (FALSE); >>> +    break; >>>     } >>> >>>     gBS->RestoreTPL (OriginalTPL); >>> -- >>> 2.14.1.3.gb7cf6e02401b >>> > Reviewed-by: Ruiyu Ni > Thank you both, commit e1fb441624cd. Laszlo