Re: [edk2-devel] AArch64 with HeapGuard: page allocations wrongly aligned

["Oliver Smith-Denny" <osde@linux.microsoft.com>]

On 1/18/2024 9:42 AM, Rebecca Cran via groups.io wrote:
> On 1/18/2024 9:48 AM, Oliver Smith-Denny via groups.io wrote:
> 
>> Are you including this commit: 
>> https://github.com/tianocore/edk2/commit/00b51e0d78a547dd78119ec44fcc74a01b6f79c8?
>>
>> Can you share some more details on where this is failing? I.e. what
>> assert is getting tripped? Presumably without HeapGuard enabled, you
>> aren't seeing the failure?
>>
>> Are you hitting this case:
>> https://github.com/tianocore/edk2/blob/59f024c76ee57c2bec84794536302fc770cd6ec2/MdeModulePkg/Core/Dxe/Mem/Page.c#L1570-L1573?
>>
>> Does this repro on ArmVirtPkg?
> 
> Yes, I have that commit in my tree.
> 
> I'm hitting this assert in FreePages: 
> https://github.com/tianocore/edk2/blob/59f024c76ee57c2bec84794536302fc770cd6ec2/MdeModulePkg/Library/DxeCoreMemoryAllocationLib/MemoryAllocationLib.c#L190
> 
> It's called by SmbiosCreate64BitTable: 
> https://github.com/tianocore/edk2/blob/59f024c76ee57c2bec84794536302fc770cd6ec2/MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c#L1342
> 
> And yes, that's the case I'm hitting.
> 
> I'm having trouble getting ArmVirtPkg to run. Would it be useful testing 
> using SbsaQemu instead?
> 

Yeah, if you can get it running there, that would be a good data point.
I assume you mean the Project Mu QemuSbsaPkg? If so that is great, but
you will need to update the RUNTIME_PAGE_ALLOCATION_GRANULARITY back to
0x10000. It was set to 0x1000 for a historical issue that we are
working on reconciling with what edk2 has.

If you can get an open source repro, I'm happy to take a look at the
failure.

To clarify, if you turn off pool guard, does the assert go away?

I am suspicious that we are checking for the alignment before we
adjust the memory for the guard. I'm wondering if we actually
should do AdjustMemoryF (recalling function from memory) before
we check the alignment.

Thanks,
Oliver


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114003): https://edk2.groups.io/g/devel/message/114003
Mute This Topic: https://groups.io/mt/103810212/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-