From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web12.19716.1661397134058453102 for ; Wed, 24 Aug 2022 20:12:14 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=SyF5WLQ0; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [192.168.4.22] (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id 113602125998; Wed, 24 Aug 2022 20:12:12 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 113602125998 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1661397133; bh=DZJY7Qq1GelvmCE7QcZnCodDnLWmvWzjKN81WpwCTDQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=SyF5WLQ0JcUa2JmcCV4Biw81343GUM40O7IAE+MsGHioIdyM+EKTrcLMrEO2Q505P zaCT7Ullo1QUb24bSg5JYD9Q1EzExVUxNyEYURLINb16Jsa5BBNeDD0MgTdedE33cc +y05CraIDzm10hpHm8XKkGt4Fxyn2+nRPsw449/E= Message-ID: <6eacc9bb-d2b8-c1b7-1959-3be5e658cceb@linux.microsoft.com> Date: Wed, 24 Aug 2022 23:12:11 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 24/24] UnitTestFrameworkPkg: Remove duplicated words To: Pierre.Gondois@arm.com, devel@edk2.groups.io Cc: Michael D Kinney References: <20220823160031.991072-1-Pierre.Gondois@arm.com> <20220823160031.991072-25-Pierre.Gondois@arm.com> From: "Michael Kubacki" In-Reply-To: <20220823160031.991072-25-Pierre.Gondois@arm.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit In these changes: > - @param[in] SaveData A pointer pointer that will be updated with the address > + @param[out] SaveData A pointer that will be updated with the address The text "A pointer..." became unaligned with the block. Likely due to the extra character added when changing "in" to "out". Can you please try to update the alignment before submission? Reviewed-by: Michael Kubacki On 8/23/2022 12:00 PM, Pierre.Gondois@arm.com wrote: > From: Pierre Gondois > > In an effort to clean the documentation of the above > package, remove duplicated words. > > Also change in/out tag to pass the EccCheck. > > Cc: Michael D Kinney > Cc: Michael Kubacki > Signed-off-by: Pierre Gondois > --- > .../Library/Posix/DebugLibPosix/DebugLibPosix.c | 2 +- > UnitTestFrameworkPkg/Library/UnitTestLib/Assert.c | 2 +- > UnitTestFrameworkPkg/Library/UnitTestLib/AssertCmocka.c | 2 +- > .../UnitTestPersistenceLibNull/UnitTestPersistenceLibNull.c | 2 +- > .../UnitTestPersistenceLibSimpleFileSystem.c | 2 +- > .../PrivateInclude/Library/UnitTestPersistenceLib.h | 2 +- > UnitTestFrameworkPkg/ReadMe.md | 6 +++--- > 7 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/UnitTestFrameworkPkg/Library/Posix/DebugLibPosix/DebugLibPosix.c b/UnitTestFrameworkPkg/Library/Posix/DebugLibPosix/DebugLibPosix.c > index 694f4beb8bf5..cfee36d2ac7f 100644 > --- a/UnitTestFrameworkPkg/Library/Posix/DebugLibPosix/DebugLibPosix.c > +++ b/UnitTestFrameworkPkg/Library/Posix/DebugLibPosix/DebugLibPosix.c > @@ -179,7 +179,7 @@ DebugClearMemory ( > ASSERT (Buffer != NULL); > > // > - // SetMem() checks for the the ASSERT() condition on Length and returns Buffer > + // SetMem() checks for the ASSERT() condition on Length and returns Buffer > // > return SetMem (Buffer, Length, PcdGet8 (PcdDebugClearMemoryValue)); > } > diff --git a/UnitTestFrameworkPkg/Library/UnitTestLib/Assert.c b/UnitTestFrameworkPkg/Library/UnitTestLib/Assert.c > index 35636565b783..9bb0798dd801 100644 > --- a/UnitTestFrameworkPkg/Library/UnitTestLib/Assert.c > +++ b/UnitTestFrameworkPkg/Library/UnitTestLib/Assert.c > @@ -516,7 +516,7 @@ UnitTestAssertNotNull ( > is either pass, skipped, or failed. > @param[in] FunctionName Null-terminated ASCII string of the function > executing the UT_EXPECT_ASSERT_FAILURE() macro. > - @param[in] LineNumber The source file line number of the the function > + @param[in] LineNumber The source file line number of the function > executing the UT_EXPECT_ASSERT_FAILURE() macro. > @param[in] FileName Null-terminated ASCII string of the filename > executing the UT_EXPECT_ASSERT_FAILURE() macro. > diff --git a/UnitTestFrameworkPkg/Library/UnitTestLib/AssertCmocka.c b/UnitTestFrameworkPkg/Library/UnitTestLib/AssertCmocka.c > index dc05bbd4384c..0b1f6b197a35 100644 > --- a/UnitTestFrameworkPkg/Library/UnitTestLib/AssertCmocka.c > +++ b/UnitTestFrameworkPkg/Library/UnitTestLib/AssertCmocka.c > @@ -349,7 +349,7 @@ UnitTestAssertNotNull ( > is either pass, skipped, or failed. > @param[in] FunctionName Null-terminated ASCII string of the function > executing the UT_EXPECT_ASSERT_FAILURE() macro. > - @param[in] LineNumber The source file line number of the the function > + @param[in] LineNumber The source file line number of the function > executing the UT_EXPECT_ASSERT_FAILURE() macro. > @param[in] FileName Null-terminated ASCII string of the filename > executing the UT_EXPECT_ASSERT_FAILURE() macro. > diff --git a/UnitTestFrameworkPkg/Library/UnitTestPersistenceLibNull/UnitTestPersistenceLibNull.c b/UnitTestFrameworkPkg/Library/UnitTestPersistenceLibNull/UnitTestPersistenceLibNull.c > index e28327652eaf..6cd8e4150465 100644 > --- a/UnitTestFrameworkPkg/Library/UnitTestPersistenceLibNull/UnitTestPersistenceLibNull.c > +++ b/UnitTestFrameworkPkg/Library/UnitTestPersistenceLibNull/UnitTestPersistenceLibNull.c > @@ -55,7 +55,7 @@ SaveUnitTestCache ( > Will allocate a buffer to hold the loaded data. > > @param[in] FrameworkHandle A pointer to the framework that is being persisted. > - @param[in] SaveData A pointer pointer that will be updated with the address > + @param[out] SaveData A pointer that will be updated with the address > of the loaded data buffer. > > @retval EFI_SUCCESS Data has been loaded successfully and SaveData is updated > diff --git a/UnitTestFrameworkPkg/Library/UnitTestPersistenceLibSimpleFileSystem/UnitTestPersistenceLibSimpleFileSystem.c b/UnitTestFrameworkPkg/Library/UnitTestPersistenceLibSimpleFileSystem/UnitTestPersistenceLibSimpleFileSystem.c > index ed4a7d161524..4e2fb785be78 100644 > --- a/UnitTestFrameworkPkg/Library/UnitTestPersistenceLibSimpleFileSystem/UnitTestPersistenceLibSimpleFileSystem.c > +++ b/UnitTestFrameworkPkg/Library/UnitTestPersistenceLibSimpleFileSystem/UnitTestPersistenceLibSimpleFileSystem.c > @@ -312,7 +312,7 @@ Exit: > Will allocate a buffer to hold the loaded data. > > @param[in] FrameworkHandle A pointer to the framework that is being persisted. > - @param[in] SaveData A pointer pointer that will be updated with the address > + @param[out] SaveData A pointer that will be updated with the address > of the loaded data buffer. > > @retval EFI_SUCCESS Data has been loaded successfully and SaveData is updated > diff --git a/UnitTestFrameworkPkg/PrivateInclude/Library/UnitTestPersistenceLib.h b/UnitTestFrameworkPkg/PrivateInclude/Library/UnitTestPersistenceLib.h > index be29e079ec3e..f2806cadd2a8 100644 > --- a/UnitTestFrameworkPkg/PrivateInclude/Library/UnitTestPersistenceLib.h > +++ b/UnitTestFrameworkPkg/PrivateInclude/Library/UnitTestPersistenceLib.h > @@ -57,7 +57,7 @@ SaveUnitTestCache ( > Will allocate a buffer to hold the loaded data. > > @param[in] FrameworkHandle A pointer to the framework that is being persisted. > - @param[in] SaveData A pointer pointer that will be updated with the address > + @param[out] SaveData A pointer that will be updated with the address > of the loaded data buffer. > > @retval EFI_SUCCESS Data has been loaded successfully and SaveData is updated > diff --git a/UnitTestFrameworkPkg/ReadMe.md b/UnitTestFrameworkPkg/ReadMe.md > index e696412cb3cf..a7b64bd65392 100644 > --- a/UnitTestFrameworkPkg/ReadMe.md > +++ b/UnitTestFrameworkPkg/ReadMe.md > @@ -144,7 +144,7 @@ will be used when adding test cases. > Great! Now we've finished some of the cruft, red tape, and busy work. We're ready to add some tests. Adding a test > to a test suite is accomplished with the -- you guessed it -- `AddTestCase` function. It takes in the suite handle; > a `CHAR8` string for the description and class name; a function pointer for the test case itself; additional, optional > -function pointers for prerequisite check and cleanup routines; and and optional pointer to a context structure. > +function pointers for prerequisite check and cleanup routines; and optional pointer to a context structure. > > Okay, that's a lot. Let's take it one piece at a time. The description and class name strings are very similar in > usage to the suite title and package name strings in the test suites. The former is for user presentation and the > @@ -268,8 +268,8 @@ stuart_ci_build -c .pytool/CISettings.py TOOL_CHAIN_TAG=VS2019 -p MdePkg -t NOOP > > ## Building and Running Host-Based Tests > > -The EDK2 CI infrastructure provides a convenient way to run all host-based tests -- in the the entire tree or just > -selected packages -- and aggregate all the the reports, including highlighting any failures. This functionality is > +The EDK2 CI infrastructure provides a convenient way to run all host-based tests -- in the entire tree or just > +selected packages -- and aggregate all the reports, including highlighting any failures. This functionality is > provided through the Stuart build system (published by EDK2-PyTools) and the `NOOPT` build target. > > ### Building Locally