Re: [edk2-platforms][PATCH 1/1] RPi3: default DisplayDxe to just native mode

["Pete Batard" <pete@akeo.ie>]

On 2020.05.11 12:06, Ard Biesheuvel wrote:
> On 5/11/20 12:58 PM, Pete Batard wrote:
>> On 2020.05.10 22:36, Andrei Warkentin wrote:
>>> The scaled resolutions are useful, but are not the default expected
>>> by most users. Linux and BSDs don't set preferred resolution in
>>> their OS loader, so when booting via setup UI, the OS is left
>>> running at 800x600, not the native resolution. This looks crummy.
>>>
>>> Signed-off-by: Andrei Warkentin <andrey.warkentin@gmail.com>
>>> ---
>>>   Platform/RaspberryPi/RPi3/RPi3.dsc | 6 +++++-
>>>   Platform/RaspberryPi/RPi4/RPi4.dsc | 6 +++++-
>>>   2 files changed, 10 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc 
>>> b/Platform/RaspberryPi/RPi3/RPi3.dsc
>>> index a138c874..8dd4cbff 100644
>>> --- a/Platform/RaspberryPi/RPi3/RPi3.dsc
>>> +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc
>>> @@ -471,7 +471,11 @@
>>>     #
>>>     # Display-related.
>>>     #
>>> - 
>>> gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|L"DisplayEnableScaledVModes"|gConfigDxeFormSetGuid|0x0|0x3f 
>>>
>>> +
>>> +  #
>>> +  # Just enable native resolution by default.
>>> +  #
>>> + 
>>> gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|L"DisplayEnableScaledVModes"|gConfigDxeFormSetGuid|0x0|0x20 
>>>
>>> gRaspberryPiTokenSpaceGuid.PcdDisplayEnableSShot|L"DisplayEnableSShot"|gConfigDxeFormSetGuid|0x0|1 
>>>
>>>     #
>>> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc 
>>> b/Platform/RaspberryPi/RPi4/RPi4.dsc
>>> index 75867f03..9413fe66 100644
>>> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc
>>> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
>>> @@ -486,7 +486,11 @@
>>>     #
>>>     # Display-related.
>>>     #
>>> - 
>>> gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|L"DisplayEnableScaledVModes"|gConfigDxeFormSetGuid|0x0|0x3f 
>>>
>>> +
>>> +  #
>>> +  # Just enable native resolution by default.
>>> +  #
>>> + 
>>> gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|L"DisplayEnableScaledVModes"|gConfigDxeFormSetGuid|0x0|0x20 
>>>
>>> gRaspberryPiTokenSpaceGuid.PcdDisplayEnableSShot|L"DisplayEnableSShot"|gConfigDxeFormSetGuid|0x0|1 
>>>
>>>     #
>>>
>>
>> Reviewed-by: Pete Batard <pete@akeo.ie>
>>
>> For the series:
>> Tested-by: Pete Batard <pete@akeo.ie>
> 
> Thanks Pete.
> 
> What do you mean by series? This is patch 1/1
> 

My bad, I treated the previous 2 and this one as a 3 patches series.

/Pete