From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by mx.groups.io with SMTP id smtpd.web10.10186.1589197092256197953 for ; Mon, 11 May 2020 04:38:12 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=SFdKmHZJ; spf=none, err=permanent DNS error (domain: akeo.ie, ip: 209.85.221.67, mailfrom: pete@akeo.ie) Received: by mail-wr1-f67.google.com with SMTP id v12so10478598wrp.12 for ; Mon, 11 May 2020 04:38:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=6EGffW0MrCgbw4672sYBEnEyEE63nDUnZqGaAmmFCTY=; b=SFdKmHZJXJL6ITr2R8C84qDIxfzWaMyWJc/fPGwYX6l3657eNTFjgxT3BEjiIWHAw4 t7N1Cv0NpwtUVLDeuhVd0jafQVStkQp7Pzzc2yZLkCTncaRdE9fg5laY+2eMm8c3q1Lc c0+7a3XajUjqqQwmJmuS4tvTyf3viroKnGhGqRKsHpcFzawjn//iq/pNY5lX6ziEplBQ jA+a6g5lybetDPsPA4iUJyx815E1ZRw8XMiIJVZdhaWsfd2xG/4TrUZ4WLvXeiHhgID0 H23y0Oj6r1YpeEf9J9RNo3n//qs9DPHb9vGawBD7+AGRNzpEKT3oqQ5kgdBX6cW73KgJ 3wFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6EGffW0MrCgbw4672sYBEnEyEE63nDUnZqGaAmmFCTY=; b=d1zFz6fFxsKB5ldXujqj1on/JUPBnXxVui709+AUQ0SCikyhf7WG+BhzIbgNdE68KD hkOXFITOzC99usJmjzuFeOXDGjZN/cFQFthw2MQPpmPkmqqHk8Vj2kKGBF2Yi6ZO6xE1 cp+6EWGx4q2Z63OxRKyrJGs8HvlohZmfqEMR9aPfwkU0mgx7j7dzztYH4tb7LINed5vm oymh5qM3lIX8FMCsK/KXvOY01RTHbA9N+dIObh81ZXNYZLlA8xqXDb6dcWlY9KV+w5T3 1S/piNQatOIVegvrEETEtNarsWDPWLVr56nHa3UKAQhRGbgag3oAGLLXe9PjG1Xj4QLU 4wxQ== X-Gm-Message-State: AGi0PuZQSzaYWpCJUrhEf8Y6vOLtRS9pxMibqLaIqeS6Bss2zp8PNwHL lAi2ig9iNLSe+nfL4N8LHHc45g== X-Google-Smtp-Source: APiQypL2hU0rd28EvVenVqPThPX5hLMC1uqkh6WmzBz8Wp+ZJ2+CnW4GbiBTh+Ph3vfUvAjJmbMH2Q== X-Received: by 2002:a05:6000:85:: with SMTP id m5mr17459480wrx.281.1589197090706; Mon, 11 May 2020 04:38:10 -0700 (PDT) Return-Path: Received: from [10.0.0.122] ([84.203.75.87]) by smtp.googlemail.com with ESMTPSA id 89sm16721178wrj.37.2020.05.11.04.38.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 May 2020 04:38:10 -0700 (PDT) Subject: Re: [edk2-platforms][PATCH 1/1] RPi3: default DisplayDxe to just native mode To: Ard Biesheuvel , Andrei Warkentin , devel@edk2.groups.io Cc: leif@nuviainc.com, philmd@redhat.com References: <20200510213603.12741-1-andrey.warkentin@gmail.com> <45d9af40-7d74-91d5-6c12-acb2eea998c0@arm.com> From: "Pete Batard" Message-ID: <6ec7aee0-3b5c-87f1-79b4-4102eaf60a60@akeo.ie> Date: Mon, 11 May 2020 12:38:08 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <45d9af40-7d74-91d5-6c12-acb2eea998c0@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit On 2020.05.11 12:06, Ard Biesheuvel wrote: > On 5/11/20 12:58 PM, Pete Batard wrote: >> On 2020.05.10 22:36, Andrei Warkentin wrote: >>> The scaled resolutions are useful, but are not the default expected >>> by most users. Linux and BSDs don't set preferred resolution in >>> their OS loader, so when booting via setup UI, the OS is left >>> running at 800x600, not the native resolution. This looks crummy. >>> >>> Signed-off-by: Andrei Warkentin >>> --- >>>   Platform/RaspberryPi/RPi3/RPi3.dsc | 6 +++++- >>>   Platform/RaspberryPi/RPi4/RPi4.dsc | 6 +++++- >>>   2 files changed, 10 insertions(+), 2 deletions(-) >>> >>> diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc >>> b/Platform/RaspberryPi/RPi3/RPi3.dsc >>> index a138c874..8dd4cbff 100644 >>> --- a/Platform/RaspberryPi/RPi3/RPi3.dsc >>> +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc >>> @@ -471,7 +471,11 @@ >>>     # >>>     # Display-related. >>>     # >>> - >>> gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|L"DisplayEnableScaledVModes"|gConfigDxeFormSetGuid|0x0|0x3f >>> >>> + >>> +  # >>> +  # Just enable native resolution by default. >>> +  # >>> + >>> gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|L"DisplayEnableScaledVModes"|gConfigDxeFormSetGuid|0x0|0x20 >>> >>> gRaspberryPiTokenSpaceGuid.PcdDisplayEnableSShot|L"DisplayEnableSShot"|gConfigDxeFormSetGuid|0x0|1 >>> >>>     # >>> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc >>> b/Platform/RaspberryPi/RPi4/RPi4.dsc >>> index 75867f03..9413fe66 100644 >>> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc >>> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc >>> @@ -486,7 +486,11 @@ >>>     # >>>     # Display-related. >>>     # >>> - >>> gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|L"DisplayEnableScaledVModes"|gConfigDxeFormSetGuid|0x0|0x3f >>> >>> + >>> +  # >>> +  # Just enable native resolution by default. >>> +  # >>> + >>> gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|L"DisplayEnableScaledVModes"|gConfigDxeFormSetGuid|0x0|0x20 >>> >>> gRaspberryPiTokenSpaceGuid.PcdDisplayEnableSShot|L"DisplayEnableSShot"|gConfigDxeFormSetGuid|0x0|1 >>> >>>     # >>> >> >> Reviewed-by: Pete Batard >> >> For the series: >> Tested-by: Pete Batard > > Thanks Pete. > > What do you mean by series? This is patch 1/1 > My bad, I treated the previous 2 and this one as a 3 patches series. /Pete