From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web11.16311.1602778840166701907 for ; Thu, 15 Oct 2020 09:20:40 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=JwMeQJCj; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602778839; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QiLzjfTEoRw7H31OppNeTvOrfYfLPeCpT3O3lYDhWN4=; b=JwMeQJCjtwLDzUKwnSEdfIcb8wxPlYUwx1uukgYbhSiCNHCIvvB6SoDQ3uoolazwiUv+Vb U/jIvJVcYK101GBl8HTjyqbB2W3ur6XO61TdeNUf5TPmJNuvXaP5+SSexDbbaZpCYmuzET CmaYdIJqFeYGmHyezEazZW7q4Wyx1RE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-504-cnGuKqjaPqicK7HEgW-McA-1; Thu, 15 Oct 2020 12:20:34 -0400 X-MC-Unique: cnGuKqjaPqicK7HEgW-McA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3F174EC508; Thu, 15 Oct 2020 16:20:32 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-119.ams2.redhat.com [10.36.113.119]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3BB6776670; Thu, 15 Oct 2020 16:20:29 +0000 (UTC) Subject: Re: [PATCH 0/9] SEV-ES guest support fixes and cleanup Cc: Tom Lendacky , devel@edk2.groups.io, Brijesh Singh , Ard Biesheuvel , Eric Dong , Liming Gao , Jordan Justen , Michael D Kinney , Rahul Kumar , Zhiguang Liu , Ray Ni References: From: "Laszlo Ersek" To: Michael Kinney Message-ID: <6ecc2e13-697b-1aa4-7674-e504d1a7b6a9@redhat.com> Date: Thu, 15 Oct 2020 18:20:28 +0200 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Mike, (top posting on purpose) can you please update the bugzilla installation so that it show the edk2-stable202008 tag in the "list of affected releases" and "list of releases needing fixes" widgets? Thanks! Laszlo On 10/15/20 15:26, Tom Lendacky wrote: > On 10/15/20 2:43 AM, Laszlo Ersek wrote: >> Hi Tom, >> >> On 10/10/20 18:06, Tom Lendacky wrote: >>> From: Tom Lendacky >>> >>> This patch series provides some fixes, updates and cleanup to the SEV-ES >>> guest support: >>> >>> The first patch updates the calculation of the qword offset of fields >>> within the GHCB. Specifically, it removes the hardcoding of the offsets >>> and uses the OFFSET_OF () and sizeof () functions to calculate the >>> values, removes unused values and add values that will be used in later >>> patches. >>> >>> The next five patches set the >>> SwExitCode/SwExitInfo1/SwExitInfo2/SwScratch >>> valid bits in the GHCB ValidBitmap area when these fields are set at >>> VMGEXIT. >>> >>> The next two patches update the Qemu flash drive services support to >>> add SEV-ES support to erasing blocks and to disable interrupts when >>> using >>> the GHCB. >>> >>> Finally, the last patch uses the processor number for setting the AP >>> stack >>> pointer instead of the APIC ID (using GetProcessorNumber()). >> >> please file a TianoCore BZ for this series, assign it to yourself, link >> the v1 posting in a comment on the BZ, and update the commit messages to >> reference that BZ. >> >> I find this relevant because edk2-stable202008 resolved TianoCore#2198. >> If (in your opinion) downstreams that aim at supporting SEV-ES should >> also have these patches (for example, if they should backport them on >> top of edk2-stable202008), then having a TianoCore Bugzilla would be >> quite helpful to them, for tracking purposes. > > Ok, done (https://bugzilla.tianocore.org/show_bug.cgi?id=3008). > > One thing I noticed in the bugzilla is that there is a way to specify > the releases the issue was observed in and must be fixed in, but the > edk2-stable202008 release isn't listed in it (yet). > > Thanks, > Tom > >> >> Thanks, >> Laszlo >> >>> >>> --- >>> >>> These patches are based on commit: >>> ae511331e0fb ("BaseTools Build_Rule: Add the missing ASM16_FLAGS for >>> ASM16 source file") >>> >>> Cc: Ard Biesheuvel >>> Cc: Eric Dong >>> Cc: Laszlo Ersek >>> Cc: Liming Gao >>> Cc: Jordan Justen >>> Cc: Michael D Kinney >>> Cc: Rahul Kumar >>> Cc: Zhiguang Liu >>> Cc: Ray Ni >>> Cc: Tom Lendacky >>> Cc: Brijesh Singh >>> >>> Tom Lendacky (9): >>>    OvmfPkg/VmgExitLib: Update ValidBitmap settings >>>    OvmfPkg/VmgExitLib: Set the SW exit fields when performing VMGEXIT >>>    OvmfPkg/VmgExitLib: Set the SwScratch valid bit for IOIO events >>>    OvmfPkg/VmgExitLib: Set the SwScratch valid bit for MMIO events >>>    UefiCpuPkg/MpInitLib: Set the SW exit fields when performing VMGEXIT >>>    OvmfPkg/QemuFlashFvbServicesRuntimeDxe: Set the SwScratch valid bit >>>    OvmfPkg/QemuFlashFvbServicesRuntimeDxe: Fix erase blocks for SEV-ES >>>    OvmfPkg/QemuFlashFvbServicesRuntimeDxe: Disable interrupts when using >>>      GHCB >>>    UefiCpuPkg/MpInitLib: For SEV-ES guest set stack based on processor >>>      number >>> >>>   MdePkg/Include/Register/Amd/Ghcb.h                    | 48 >>> ++++++++------------ >>>   OvmfPkg/Library/VmgExitLib/VmgExitLib.c               | 30 >>> ++++++++++++ >>>   OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c         | 10 +++- >>>   OvmfPkg/QemuFlashFvbServicesRuntimeDxe/QemuFlash.c    |  4 +- >>>   OvmfPkg/QemuFlashFvbServicesRuntimeDxe/QemuFlashDxe.c | 21 +++++++++ >>>   UefiCpuPkg/Library/MpInitLib/MpLib.c                  |  7 ++- >>>   UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm         |  6 +++ >>>   7 files changed, 91 insertions(+), 35 deletions(-) >>> >> >