From: "xianglai" <lixianglai@loongson.cn>
To: devel@edk2.groups.io, git@xen0n.name
Cc: Bibo Mao <maobibo@loongson.cn>, Chao Li <lichao@loongson.cn>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Michael D Kinney <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH] Platform/Loongson: Allow building with stack protector support
Date: Wed, 8 Mar 2023 11:17:08 +0800 [thread overview]
Message-ID: <6ed30673-98f7-7c16-1c16-33cc4988dfaa@loongson.cn> (raw)
In-Reply-To: <20230305044035.476989-1-git@xen0n.name>
[-- Attachment #1: Type: text/plain, Size: 1361 bytes --]
Reviewed-by: Xianglai Li <lixianglai@loongson.cn>
On 2023/3/5 下午12:40, WANG Xuerui wrote:
> Some toolchains have stack protection enabled by default, so without the
> appropriate library included the build will fail with missing symbols
> during link.
>
> Cc: Bibo Mao <maobibo@loongson.cn>
> Cc: Xianglai li <lixianglai@loongson.cn>
> Cc: Chao Li <lichao@loongson.cn>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: WANG Xuerui <git@xen0n.name>
> ---
> Platform/Loongson/LoongArchQemuPkg/Loongson.dsc | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc b/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc
> index d1162519cd..465e9229a2 100644
> --- a/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc
> +++ b/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc
> @@ -95,6 +95,9 @@
> TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf
> !endif
>
> + # For stack protector support
> + NULL | MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
> +
> BaseLib | MdePkg/Library/BaseLib/BaseLib.inf
> SafeIntLib | MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
> TimeBaseLib | EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf
[-- Attachment #2: Type: text/html, Size: 2213 bytes --]
next prev parent reply other threads:[~2023-03-08 3:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-05 4:40 [PATCH] Platform/Loongson: Allow building with stack protector support WANG Xuerui
2023-03-07 1:44 ` [edk2-devel] " Chao Li
2023-03-08 3:17 ` xianglai [this message]
2023-03-20 8:07 ` Chao Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ed30673-98f7-7c16-1c16-33cc4988dfaa@loongson.cn \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox