public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Nhi Pham via groups.io" <nhi=os.amperecomputing.com@groups.io>
To: Rebecca Cran <rebecca@os.amperecomputing.com>,
	devel@edk2.groups.io, quic_llindhol@quicinc.com,
	Nhi Pham <nhi@os.amperecomputing.com>
Cc: patches@amperecomputing.com
Subject: Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/Ampere: Update Readme.md
Date: Tue, 12 Sep 2023 08:54:47 +0700	[thread overview]
Message-ID: <6ee549a4-569c-0dba-a4dc-84209e055dfd@amperemail.onmicrosoft.com> (raw)
In-Reply-To: <20230911174412.785658-1-rebecca@os.amperecomputing.com>

Reviewed-by: Nhi Pham <nhi@os.amperecomputing.com>

Thanks,

Nhi

On 9/12/2023 12:44 AM, Rebecca Cran wrote:
> Improve the Readme.md in Platform/Ampere:
>
> - At this point eMAG is irrelevant, and most people are likely
>    using Altra systems. Drop mention of it.
> - Instead of mentioning the 'latest' versions of CentOS and Ubuntu
>    (which will by definition change over time), specify Ubuntu 22.04
>    and CentOS 7.
> - Fix the link to the acpica download, since content has been moved from
>    acpica.org to intel.com.
> - Assuming the build is being done on Linux, acpica shouldn't be built
>    with a CYGWIN definition.
> - To avoid making people wait ages for acpica to build, add `-j8` as an
>    example of building in parallel.
>
> Signed-off-by: Rebecca Cran <rebecca@os.amperecomputing.com>
> ---
>   Platform/Ampere/Readme.md | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Platform/Ampere/Readme.md b/Platform/Ampere/Readme.md
> index 894bad3437b8..066876dab4b5 100644
> --- a/Platform/Ampere/Readme.md
> +++ b/Platform/Ampere/Readme.md
> @@ -8,8 +8,8 @@ Silicon code is located under Silicon/Ampere/Ampere{SoC Name}Pkg.
>   
>   # Build machines
>   
> -- x86 Linux host machines running latest Ubuntu or CentOS releases.
> -- Arm64 Linux host machines if native compiling. This has been tested on Ampere's eMAG and Altra hardware platforms with latest AArch64 CentOS or Ubuntu releases.
> +- x86 Linux host machines running Ubuntu 22.04 or CentOS 7 releases.
> +- Arm64 Linux host machines if native compiling. This has been tested on Ampere's Altra hardware platforms with AArch64 CentOS 7 or Ubuntu 22.04 releases.
>   
>   # How to build (Linux Environment)
>   
> @@ -32,8 +32,8 @@ If you run into any build issue with the Intel ASL+ Optimizing Compiler/Disassem
>   download and install the IASL compiler from https://acpica.org/. At the time of this write-up, we have tested with version 20200110.
>   
>   ```bash
> -$ wget https://acpica.org/sites/acpica/files/acpica-unix2-20200110.tar.gz
> +$ wget https://downloadmirror.intel.com/774850/acpica-unix2-20200110.tar.gz
>   $ tar xzf acpica-unix2-20200110.tar.gz
>   $ cd acpica-unix2-20200110
> -$ make HOST=_CYGWIN && sudo make install
> +$ make -j8 && sudo make install
>   ```


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108512): https://edk2.groups.io/g/devel/message/108512
Mute This Topic: https://groups.io/mt/101298216/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2023-09-12  1:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-11 17:44 [edk2-devel] [PATCH edk2-platforms 1/1] Platform/Ampere: Update Readme.md Rebecca Cran via groups.io
2023-09-12  1:54 ` Nhi Pham via groups.io [this message]
2023-09-12  9:58 ` Leif Lindholm
2023-09-12 13:07   ` Rebecca Cran via groups.io
2023-09-12 15:11     ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6ee549a4-569c-0dba-a4dc-84209e055dfd@amperemail.onmicrosoft.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox