From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id A1EF794151D for ; Thu, 30 May 2024 10:33:58 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=bZcs/o+PofQ6YxsSyWZ6ZOiijNvgdkMOHM65TK9RtDM=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition:Content-Transfer-Encoding; s=20240206; t=1717065238; v=1; b=zSgIWo9edOEkVTcNH4RbZ/Afa5XkrGFmJjcnvJ1EqaUfhR22QnIhty6s2qcS2HYH5D4XC5TD se804wRugau0g21jEh9b6V1iT9ZaAWRMO27hopmBNZ29EmXdJEbCwWMnWnAbGLiZ6QPQOrjBZTq sbQsKMup6W+UepgMA7YeqEgDzEAgX3msxe4QFGBYfVfWHEkf/kzwzxLQ5uZkQNHCOOVpEYeS3Z2 8DMxKr8GfHF+Bco1mn5gzFbzqq1j9jYojpdhvSi8mn362AngUAL+lYEO/Sjm6nyj3XS3oYl6zI6 FS4S93xJc+dmurrMpu8huwI/xuLo6Jvnkaw8rRgg/BaBg== X-Received: by 127.0.0.2 with SMTP id CVNIYY7687511xLwmudoBzKj; Thu, 30 May 2024 03:33:57 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.5132.1717065236676953242 for ; Thu, 30 May 2024 03:33:56 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-671-R9Bxd22KN8K8IUiIlBzIew-1; Thu, 30 May 2024 06:33:54 -0400 X-MC-Unique: R9Bxd22KN8K8IUiIlBzIew-1 X-Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5485D81227E; Thu, 30 May 2024 10:33:53 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.192.101]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E230D1C00A97; Thu, 30 May 2024 10:33:52 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 7AEB618000A9; Thu, 30 May 2024 12:33:51 +0200 (CEST) Date: Thu, 30 May 2024 12:33:51 +0200 From: "Gerd Hoffmann" To: Michael Brown Cc: devel@edk2.groups.io, gaoliming@byosoft.com.cn, dougflick@microsoft.com, 'Ard Biesheuvel' Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW2VkazItZGV2ZWxdIFtQQVRDSCB2MyAwMC8yMF0gTmV0d29ya1BrZzogQ1ZFLTIwMjMtNDUyMzYgYW5kIENWRS0yMDIzLTQ1MjM3?= Message-ID: <6f2dad4f6ozcpcsmserp53a7prvtvmeevf3i26jolu3uyligf2@sn3t4tmunsvu> References: <20240524054512.523329-1-douglas.flick@microsoft.com> <00e401dab24f$4eccdc20$ec669460$@byosoft.com.cn> <0102018fc8f8e7c3-2d45d61e-42bd-4b1a-9071-74ee563f303a-000000@eu-west-1.amazonses.com> MIME-Version: 1.0 In-Reply-To: <0102018fc8f8e7c3-2d45d61e-42bd-4b1a-9071-74ee563f303a-000000@eu-west-1.amazonses.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 30 May 2024 03:33:56 -0700 Resent-From: kraxel@redhat.com Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: fzym2eL0LDtkiZLPSuVpsSLDx7686176AA= Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=zSgIWo9e; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On Thu, May 30, 2024 at 10:08:26AM GMT, Michael Brown wrote: > iPXE shouldn't be triggering any protocol installations in response to > ExitBootServices. > > We used to make a good-faith effort to clean up gracefully by uninstalling > protocols. This ended up exposing so many bugs in EDK2 and third-party UEFI > code (where the uninstallation paths seem to almost never be tested) that we > eventually gave up. Most likely it is exactly this ... > As of commit > https://github.com/ipxe/ipxe/commit/6769a7c3c, we now deliberately leak > resources once ExitBootServices has been triggered by skipping the cleanup > calls to UninstallMultipleProtocolInterfaces etc. ... as the ipxe binaries shipped in upstream qemu repo are older than that commit. Time to run an update I guess. Trying to update to current ipxe master gives me build errors though (with fedora 40 + gcc 14): kraxel@sirius ~/projects/qemu/roms (sirius/ipxe)# make efirom /usr/bin/gmake -C ipxe/src CONFIG=qemu \ CROSS_COMPILE=x86_64-linux-gnu- \ bin/8086100e.rom bin/808610d3.rom bin/80861209.rom bin/10500940.rom bin/10222000.rom bin/10ec8139.rom bin/1af41000.rom bin/15ad07b0.rom gmake[1]: Entering directory '/home/kraxel/projects/qemu/roms/ipxe/src' [BUILD] bin/etherfabric.o In file included from drivers/net/etherfabric.c:36: In function ‘falcon_xaui_link_ok’, inlined from ‘falcon_init_xmac’ at drivers/net/etherfabric.c:2355:14, inlined from ‘falcon_init_xmac’ at drivers/net/etherfabric.c:2314:1: drivers/net/etherfabric.h:524:28: error: ‘reg.u32[0]’ may be used uninitialized [-Werror=maybe-uninitialized] 522 | (dword).u32[0] = ( ( (dword).u32[0] \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 523 | & ~EFAB_INPLACE_MASK32 ( 0, 31, field ) ) \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 524 | | EFAB_INSERT_FIELD32 ( 0, 31, field, value ) ); \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/net/etherfabric.c:2233:9: note: in expansion of macro ‘EFAB_SET_DWORD_FIELD’ 2233 | EFAB_SET_DWORD_FIELD ( reg, FCN_XX_DISPERR, FCN_XX_DISPERR_RESET); | ^~~~~~~~~~~~~~~~~~~~ drivers/net/etherfabric.c: In function ‘falcon_init_xmac’: drivers/net/etherfabric.c:2213:22: note: ‘reg.u32[0]’ was declared here 2213 | efab_dword_t reg; | ^~~ cc1: all warnings being treated as errors gmake[1]: *** [Makefile.housekeeping:964: bin/etherfabric.o] Error 1 gmake[1]: Leaving directory '/home/kraxel/projects/qemu/roms/ipxe/src' gmake: *** [Makefile:123: build-pxe-roms] Error 2 take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119389): https://edk2.groups.io/g/devel/message/119389 Mute This Topic: https://groups.io/mt/106383321/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-