From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (EUR02-AM0-obe.outbound.protection.outlook.com [40.107.247.81]) by mx.groups.io with SMTP id smtpd.web08.6911.1666787871600547389 for ; Wed, 26 Oct 2022 05:37:51 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=1yeysHmu; spf=pass (domain: arm.com, ip: 40.107.247.81, mailfrom: sami.mujawar@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=gQIoiyCg3K6lQ9nuCOXolpELUifNVs3aw4fLt4/RJlcvaQ003l5wZqPqUPQ5FD85QIkQN7MRch6lY4TsLnqezTx8x1CA5SUip9CzHwGt5hmJiiapYmzp5IIeM5oyV+5y5LKRNMfACuT3dGF7gwn1/uj4ueSLcRlyeuvMlTPeOderJrf5e4vbwUh6LnYx1uLQ1w5OZ78bKVDpZoM9ddY6fS+bhjnAQgt0/90rv6o3NlsT6mVO59pnyuAm+uNMcsfp3W9EKj0xkTtI3JBVeqMP+rG9BNjYFvGG+q/sorx3f+4uUlz8oLSQmv7qFCLRFvUMerEyaKA/Y1PHZ7brtqJsxw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lDXKH+QfPxOeyXRiRqvS50X4XYl3X4vmAEGUdnx8AvY=; b=ndp+5kGJkk7hSocAMOYiLztvyf0QJ+kqeWVqgtrlm3bkGFpgq1wAmsxRpGkZ57f9fgb2T3SusLEJrthzJn2/6lLZm0CKKk5OZrJirpos8ilAiIGwJkwr45QaFpyDLdmwH3MwSbxw0I2g1HFwt3UtXj9jgp9Yqjcq59fBTN3IObOCnqbckl/YJpAKx422m1v7ng8/d0O4sT+wH/Yv4RpQ/hZXmZRznJcvQJ5CydRZDLD+7DU3IIEs/nRQtl52cSdlj5X/J3ljU5and01JA5nmk1MPQ8AlDt4ygFVsk7JW6WStZu+IDnNyAQ4WCIn0WC3oDYWHxOlw7+53xUhppDWmTQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lDXKH+QfPxOeyXRiRqvS50X4XYl3X4vmAEGUdnx8AvY=; b=1yeysHmuf7mwlV3NN7Ac1QYngD/tuTK30nESq1063hVeZrhsKs/Sy1vg7bN3HPW/bEL41pvEmMtJLNss1oydXcSTNWH22GeVaze6TEw54bIoBS3ZYOobWs82AlieyTwaeGxeH647T+IlVBJCuE3OuxEQRb985jsRZIWfvE9pauY= Received: from AM5PR1001CA0068.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:15::45) by PAXPR08MB7528.eurprd08.prod.outlook.com (2603:10a6:102:24e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23; Wed, 26 Oct 2022 12:37:48 +0000 Received: from VI1EUR03FT041.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:15:cafe::ef) by AM5PR1001CA0068.outlook.office365.com (2603:10a6:206:15::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26 via Frontend Transport; Wed, 26 Oct 2022 12:37:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT041.mail.protection.outlook.com (100.127.145.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32 via Frontend Transport; Wed, 26 Oct 2022 12:37:48 +0000 Received: ("Tessian outbound 6c699027a257:v130"); Wed, 26 Oct 2022 12:37:48 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 705e282b8a5956c4 X-CR-MTA-TID: 64aa7808 Received: from 8a1454ea416a.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C208329E-0DA7-4F9B-8BBA-A8A5E4AF8B30.1; Wed, 26 Oct 2022 12:37:37 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8a1454ea416a.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 26 Oct 2022 12:37:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CCv916Cl3mi7AMFvClWEZUC5sIClXBF9tIwNr2Dro+bCk08veX7pvLEdmZIFoVB225EBT0hydA6IB4Oq3ncNzCHlY5vFvlXfa8Cj3llfocw7CmEpd51oIoOr5YuECCNWSN4nBSbtKfpDBJQylLiirJrTzSN8LajjlNs4NgJxzoHZco1FGh2cKd3KUt9mp1dybCz9y4JqsGmoqDQEvrkE/HbT+M9S7UqI6cj7UcMWSiYUdTICk18HN91X22JpKWfo8r3hFzCXCNB0UMc3RsnWKlD0TB38HfjTW9FkfB7Su9wk+ugTdI1qx2rx1aCpC0sjWhUkFUcf5cm+FzfqBy72Xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lDXKH+QfPxOeyXRiRqvS50X4XYl3X4vmAEGUdnx8AvY=; b=bLC/fHJGk1JrKfEvHc+/vGts3n2Ply6Qrtgc1z2eWK13AaG68TX67ynlmMazF22iiv1585i5EytroHXleLNHb34C+uffr0U7VLPyOcIPNE32Ug+U5F5eay5GVU7gQQrdaE3TUOldpWUHEhcbJ+/lSugvnQHWtQT7dQX3vGai8ALHQ1jypCnSns0lUDhc7t1xiZer4Qr06WUcv/HfP7lzSHUK5cc84xthzWbqK4qehidXTERzA8QxeedRb4Q69u/VrTaIlgRKjoshHvngrTPczt+zDUiCgjhwECpzTDHd1g7iNqRH/3SqEi2P1teLxurMo0lbzHD5qiANEwWYCB6X6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lDXKH+QfPxOeyXRiRqvS50X4XYl3X4vmAEGUdnx8AvY=; b=1yeysHmuf7mwlV3NN7Ac1QYngD/tuTK30nESq1063hVeZrhsKs/Sy1vg7bN3HPW/bEL41pvEmMtJLNss1oydXcSTNWH22GeVaze6TEw54bIoBS3ZYOobWs82AlieyTwaeGxeH647T+IlVBJCuE3OuxEQRb985jsRZIWfvE9pauY= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by DU0PR08MB8638.eurprd08.prod.outlook.com (2603:10a6:10:402::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Wed, 26 Oct 2022 12:37:35 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::283c:fe2e:699d:2bf]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::283c:fe2e:699d:2bf%5]) with mapi id 15.20.5746.027; Wed, 26 Oct 2022 12:37:35 +0000 Message-ID: <6f45b4c6-d58a-67c5-9dbc-16a2d8cbc959@arm.com> Date: Wed, 26 Oct 2022 13:37:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 08/14] DynamicTablesPkg: FdtHwInfoParserLib: Remove wrong comment To: Pierre.Gondois@arm.com, devel@edk2.groups.io Cc: Alexei Fedorov , "nd@arm.com" References: <20221010092058.118714-1-Pierre.Gondois@arm.com> <20221010092058.118714-9-Pierre.Gondois@arm.com> From: "Sami Mujawar" In-Reply-To: <20221010092058.118714-9-Pierre.Gondois@arm.com> X-ClientProxiedBy: LO4P123CA0407.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:189::16) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|DU0PR08MB8638:EE_|VI1EUR03FT041:EE_|PAXPR08MB7528:EE_ X-MS-Office365-Filtering-Correlation-Id: e7eecffe-adca-4d2c-6214-08dab74ee3f8 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: JgYNqIzygGLrcSCWYMPEHLOyljAay+RLklDKcB0QX2YpZRiBezuzqG7K+/yPS4OvMk+kFX0WkDulslD4ui/1iVRTefcprJ1BXQKOHujMASqYOdw2qHgqmwbBqMDHQOXOUudpYyrXM8LPQdoBTdwy16+OTAY77TCUnVl2HRNos7TpVgK2Acee5I3lcvLttOmpyWyvQCW3/LjB18i+c+TIKbViBkB1M0Hl0eqMblS1fAQh0DIoA+RhSjpUGCgkPDQGVi1BlQlbNCM55xUpVnJRnxl+KWubQFGklJMxexOmAA/TRdConfQ5u1rLDeGTKixK35oz0CrO5OgN5aX4jHE9pJG2Yj5gfoe8KiIc6D8E3hKpzoOIckQVsnatK0EL1tjRr6kqyrYRLPQKQ2gTHQwQfpKFKGYmSOiKNiNCtLTOZvUKM8ni94NE9ikZJx3OUHdiMXeDRC9tN3yjHfXDhXlZyODmdQw9IjmNZxnTTSfaLWnKuqkaj2ImFAZn++AmTRAgk0KRGBnrgWnacnRmBknbgdgr5tJti96fwq3ZqTVWsGQFfF5pT7WYng3hFcT8ojZ7OBfyqoR8NymqeUGo5kt8ZE5TnMthrOJgfZFgmIIwpDYOvLUjFILdMm7cbjohU9ajzy2lfQXXXJEPJeBeTJ7K6tQcWjmJvl/GybfeKxxMyxiBXidRoM6Dv88yUmTZXFdbNR4ZdXNjfhP/AQ256ehud8pvC9ThmvOQ0BKnO5QipeAs+pw/KyIoAuGYwMO7V9g/fv3y7xyyXff6SUWLovM5UOgy/sr73f4cFRVGmuTY2ms= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(6029001)(4636009)(346002)(39860400002)(376002)(136003)(366004)(396003)(451199015)(31686004)(478600001)(316002)(6506007)(54906003)(8676002)(66476007)(66946007)(66556008)(4326008)(53546011)(6486002)(5660300002)(8936002)(86362001)(26005)(6512007)(41300700001)(186003)(2906002)(83380400001)(31696002)(44832011)(2616005)(36756003)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8638 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c7641cea-ee99-4d30-d4b4-08dab74edbc1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YTx/Xkf1pTQJ5CSBJal5+hGEhqg8jFCmd/jjwc/21bLsfe9BSsoPHrLWVngbnjt1BJF2fcrLf7FHaC9XZD3Ittx0LUbY6PZvKIaAFrscntoTssoa4RkEVDJhOkQfqnroB3s3v4FjrKL5cUPEquA567fXFrFqtSw0G1r/mMvnAfTtH5SVBymKgtnIJKbBianiKoNaZKiNcM7VVsGgm3ir+0j+R//QWp/YufT0perQ0+qanVzm4J/mVR4ME82u6vV/VbZ22TAiHlrpYPasTx1J8MmOzi4Uc5iUQ1RlcGbw4L8ogIaEV398idFdBlEqgHZAINs+PZeP468qwS5lglw+ZyM9ntjqjyiYTJmGk3BgzzFhHRi3ZC92q/pIA/Zj4dXT4URAbVidF0d1e0NHFGg0Py3f83mdDy1vbiTsf09nLo6gn2zUCr/BYx54/6GWR6+k7mZZ0hEy/A3VmOBxKKMy7ufjo3mVOv6DqB/yNXF7pik82m336y/gQcrQY79X2yy2BjMq1cRlInWiWpeh4TaWsIqyAsWt7HcIBZMPp1tjEra3cCpUem+AklWlItadDmsC3RBtHwfdWTeyMUE2LSHuSI5hTcVUcWIXRgjPnyT5ZOO77+ssvoodCIFlKVkj+J8Zx/bmosqEli5uGrGJdeOgPpRCA5QWmVYWu5A++OyqL9iS1/MW0FR3WTovLkjt3N63vuwPzZSyuwCOG564Rv6YNZD7MoEC+M5nS2cMY2SHobg2ZRE0Qwo1By4Y42yud5om1QNFOZQr3Nle7XjakZXMS3EyxGXHRZxYAYIf7Psi00BC2woRV3T/UzaItTQZUM5d X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(6029001)(4636009)(39860400002)(396003)(346002)(376002)(136003)(451199015)(36840700001)(46966006)(40470700004)(8676002)(31686004)(36756003)(70206006)(2906002)(31696002)(44832011)(186003)(336012)(86362001)(54906003)(83380400001)(2616005)(47076005)(356005)(81166007)(5660300002)(41300700001)(8936002)(70586007)(40480700001)(4326008)(82310400005)(36860700001)(316002)(6486002)(26005)(6512007)(40460700003)(82740400003)(478600001)(53546011)(6506007)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 12:37:48.5291 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e7eecffe-adca-4d2c-6214-08dab74ee3f8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7528 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 10/10/2022 10:20 am, Pierre.Gondois@arm.com wrote: > From: Pierre Gondois > > commit 13136cc3111f ("DynamicTablesPkg: FdtHwInfoParserLib: > Parse Pmu info") > adds support for pmu parsing. Thus, remove the wrong comment. > > Signed-off-by: Pierre Gondois > --- > .../Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c | 3 --- > .../Library/FdtHwInfoParserLib/Gic/ArmGicCParser.h | 3 --- > 2 files changed, 6 deletions(-) > > diff --git a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c > index fb01aa0d19e2..2c72bd0c582e 100644 > --- a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c > +++ b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c > @@ -785,9 +785,6 @@ GicCPmuNodeParser ( > UINT32 AffinityFlags; // {default = 0} > } CM_ARM_GICC_INFO; > > - The pmu information can be found in the pmu node. There is no support > - for now. > - > A parser parses a Device Tree to populate a specific CmObj type. None, > one or many CmObj can be created by the parser. > The created CmObj are then handed to the parser's caller through the > diff --git a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.h b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.h > index fd980484a28d..539f39cecb22 100644 > --- a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.h > +++ b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicCParser.h > @@ -41,9 +41,6 @@ > UINT32 AffinityFlags; // {default = 0} > } CM_ARM_GICC_INFO; > > - The pmu information can be found in the pmu node. There is no support > - for now. > - > A parser parses a Device Tree to populate a specific CmObj type. None, > one or many CmObj can be created by the parser. > The created CmObj are then handed to the parser's caller through the