From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by mx.groups.io with SMTP id smtpd.web09.3714.1649408869689759958
 for <devel@edk2.groups.io>;
 Fri, 08 Apr 2022 02:07:49 -0700
Authentication-Results: mx.groups.io;
 dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=U4dre7nh;
 spf=none, err=permanent DNS error (domain: linux.intel.com, ip: 134.134.136.65, mailfrom: maciej.rabeda@linux.intel.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1649408869; x=1680944869;
  h=message-id:date:mime-version:subject:to:cc:references:
   from:in-reply-to:content-transfer-encoding;
  bh=9qJKnTlom0kdDs95mOAPxLJNxD6w7WKjwJqSSOnS0yQ=;
  b=U4dre7nhEMob9tDS29eJ/Botw2rLLDiSUCMYH/+x4aQbl1APNaigWQi8
   BtCGfydFRq5S9Yung+xavtXf8s1Izatpu7F9UNMNVxyhbYo5XNMV9I//I
   yQpoNoKVmwppEyY9DVAD9dLpQi0WHBMNH7uaqEeLcewdOxPrJotH5kHb+
   zaJGGxWUpYJ0gEWyKT0J9oMWoYizjiFiOt8h0IywZsWNmJZVxbrWh5f9Q
   7OsOkEkpo8qyg/wABDhcMrrYu1f5fhx1D0BQK9rXuxNDpF0m3niGJfqZR
   0j+t5ft+QtzKI10+DwCOWSZ63Y+ptqHchoTEjrpYRfu+/k7RMqj9KJN2p
   A==;
X-IronPort-AV: E=McAfee;i="6400,9594,10310"; a="261543473"
X-IronPort-AV: E=Sophos;i="5.90,244,1643702400"; 
   d="scan'208";a="261543473"
Received: from orsmga004.jf.intel.com ([10.7.209.38])
  by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2022 02:07:48 -0700
X-IronPort-AV: E=Sophos;i="5.90,244,1643702400"; 
   d="scan'208";a="659418319"
Received: from mrabeda-mobl2.ger.corp.intel.com (HELO [10.237.142.93]) ([10.237.142.93])
  by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2022 02:07:46 -0700
Message-ID: <6f5285bf-4c1b-b67e-c7dd-0215e7f43725@linux.intel.com>
Date: Fri, 8 Apr 2022 11:07:41 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW2VkazItZGV2ZWxdIFtQQVRDSCB2MyAwLzVdIEh0dHAgRml4ZXMgKFRha2UgVHdvKQ==?=
To: devel@edk2.groups.io, osteffen@redhat.com
Cc: Gerd Hoffmann <kraxel@redhat.com>, gaoliming@byosoft.com.cn,
 jiaxin.wu@intel.com, siyuan.fu@intel.com
References: <20220304130403.47832-1-osteffen@redhat.com>
 <20220322133008.152037-1-osteffen@redhat.com>
 <01f201d83e53$ff55a440$fe00ecc0$@byosoft.com.cn>
 <20220407095750.rqwjlf3cvcj2gy5f@sirius.home.kraxel.org>
 <10f3672d-9e0c-61be-344d-9b8a2675942e@linux.intel.com>
 <CA+bRGFpNYEGDdszG+_fg+5BLqj6ERv7TEOgTo-WHw7MrFbm+WQ@mail.gmail.com>
From: "Maciej Rabeda" <maciej.rabeda@linux.intel.com>
In-Reply-To: <CA+bRGFpNYEGDdszG+_fg+5BLqj6ERv7TEOgTo-WHw7MrFbm+WQ@mail.gmail.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Alright.

Reviewed-by: Maciej Rabeda <maciej.rabeda@linux.intel.com>

Merge soon.

On 7 kwi 2022 14:55, Oliver Steffen wrote:
> On Thu, Apr 7, 2022 at 2:46 PM Rabeda, Maciej
> <maciej.rabeda@linux.intel.com> wrote:
>
>> 1. In HttpResponseWorker():
>>
>>       if (AsciiStrnCmp (HttpHeaders, "HTTP/1.0", AsciiStrLen
>> ("HTTP/1.0")) == 0) {
>>         DEBUG ((DEBUG_VERBOSE, "HTTP: Server version is 1.0. Setting
>> Connection close.\n"));
>>         HttpInstance->ConnectionClose = TRUE;
>>       }
>>
>> I'd change AsciiStrLen ("HTTP/1.0") to sizeof("HTTP/1.0") - 1. No need
>> to call a AsciiStrLen every time this flow is executed, it is easily a
>> compile-time thing.
> Yes, of course.
>
>> 2. In HttpResponseWorker(), index -> Index, coding standard.
> Sorry, I missed that one.
>
>> I can merge this patch with changes above one I get an ACK from you.
> Sounds good to me. Thank you!
>
> -- Oliver
>
>
>
> 
>
>