From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 69C6FD80D4E for ; Fri, 17 Nov 2023 09:16:22 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=99pq5KaUJWvAoYJOLZ5ZeaoWyqHGeMzTXGkuz5msrec=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1700212581; v=1; b=ojDik4BMlU4mr1ykrUfQ6EW7oYRi8DPGPLYLNVtFdOPUZXVAGBz78cl2mbMtq1aboqqzr8g4 00A5uHEqTQDRHxzALAgN5We470oXeANXYwv4hCGYvH92QEUpsVaAuqtcOuKDeOzopx14p/vPn5C 0yn+OW30MVKBSFnIKW/YxyDE= X-Received: by 127.0.0.2 with SMTP id AD9OYY7687511xQTuuN4TvGU; Fri, 17 Nov 2023 01:16:21 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.7895.1700212580404914006 for ; Fri, 17 Nov 2023 01:16:20 -0800 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-613-vFyCh0AsNc-MJK7Js50Y6A-1; Fri, 17 Nov 2023 04:16:14 -0500 X-MC-Unique: vFyCh0AsNc-MJK7Js50Y6A-1 X-Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D992038116E5; Fri, 17 Nov 2023 09:16:13 +0000 (UTC) X-Received: from [10.39.193.21] (unknown [10.39.193.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F1C301121306; Fri, 17 Nov 2023 09:16:11 +0000 (UTC) Message-ID: <6f62e3d2-cf82-a23b-174a-fa24dd94fbe1@redhat.com> Date: Fri, 17 Nov 2023 10:16:10 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v2] OvmfPkg/MemEncryptSevLib: Fix address overflow during PVALIDATE To: devel@edk2.groups.io, kraxel@redhat.com, Michael Roth Cc: Ray Ni , Erdem Aktas , Jiewen Yao , Min Xu , Tom Lendacky , "Liming Gao (Byosoft address)" , Michael Kinney References: <20231115175153.813213-1-michael.roth@amd.com> From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Sfud1B41LBZ4ymJtgFhiIAdlx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ojDik4BM; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none) (+Liming +Mike) On 11/16/23 10:01, Gerd Hoffmann wrote: > On Wed, Nov 15, 2023 at 11:51:53AM -0600, Michael Roth wrote: >> The struct used for GHCB-based page-state change requests uses a 40-bit >> bit-field for the GFN, which is shifted by PAGE_SHIFT to generate a >> 64-bit address. However, anything beyond 40-bits simply gets shifted off >> when doing this, which will cause issues when dealing with 1TB+ >> addresses. Fix this by casting the 40-bit GFN values to 64-bit ones >> prior to shifting it by PAGE_SHIFT. >> >> Fixes: ade62c18f474 ("OvmfPkg/MemEncryptSevLib: add support to validate = system RAM") >> Signed-off-by: Michael Roth >=20 > Reviewed-by: Gerd Hoffmann >=20 > take care, > Gerd Is this hard feature freeze material? Do we have a BZ? Also, the patch looks garbled to me on-list (superfluous line breaks). Michael's git setup may not be perfect. Michael, can you compare gitconfigs with Tom? Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111345): https://edk2.groups.io/g/devel/message/111345 Mute This Topic: https://groups.io/mt/102610323/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-