Re: 回复: [edk2-devel][PATCH v2 1/1] MdeModulePkg: Remove ArmPkg Dependency

["Oliver Smith-Denny" <osde@linux.microsoft.com>]

Thanks for the review!

Oliver

On 3/14/2024 7:43 AM, gaoliming wrote:
> Sorry for the late response. I think this is a good clean up. Reviewed-by:
> Liming Gao <gaoliming@byosoft.com.cn>
> 
>> -----邮件原件-----
>> 发件人: Oliver Smith-Denny <osde@linux.microsoft.com>
>> 发送时间: 2024年2月15日 7:20
>> 收件人: devel@edk2.groups.io
>> 抄送: Leif Lindholm <quic_llindhol@quicinc.com>; Ard Biesheuvel
>> <ardb+tianocore@kernel.org>; Sami Mujawar <sami.mujawar@arm.com>;
>> Liming Gao <gaoliming@byosoft.com.cn>; Sean Brogan
>> <sean.brogan@microsoft.com>; Ard Biesheuvel <ardb@kernel.org>
>> 主题: [edk2-devel][PATCH v2 1/1] MdeModulePkg: Remove ArmPkg
>> Dependency
>>
>> With commita21a994f55e53325d3e060c435ca3a87fd7c2c79
>> MdeModulePkg no longer has a hard dependency on ArmMmuLib and
>> therefore
>> ArmLib. This is the final dependency on ArmPkg, so remove the
>> unused libs and drop the allowed dependency on ArmPkg as
>> MdeModulePkg should not depend on it as this is a circular
>> dependency.
>>
>> Github PR: https://github.com/tianocore/edk2/pull/5361
>> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3651
>>
>> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> Cc: Sami Mujawar <sami.mujawar@arm.com>
>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>>
>> Signed-off-by: Oliver Smith-Denny <osde@linux.microsoft.com>
>> Reviewed-by: Sean Brogan <sean.brogan@microsoft.com>
>> Acked-by: Ard Biesheuvel <ardb@kernel.org>
>> ---
>>
>> Notes:
>>      v2:
>>      - Add bugzilla link to commit message
>>      - Add Sean's RB and Ard's ack
>>
>>   MdeModulePkg/MdeModulePkg.dsc     | 2 --
>>   MdeModulePkg/MdeModulePkg.ci.yaml | 3 +--
>>   2 files changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/MdeModulePkg/MdeModulePkg.dsc
>> b/MdeModulePkg/MdeModulePkg.dsc
>> index 6b3052ff4614..c0f1df3bfbca 100644
>> --- a/MdeModulePkg/MdeModulePkg.dsc
>> +++ b/MdeModulePkg/MdeModulePkg.dsc
>> @@ -179,8 +179,6 @@ [LibraryClasses.common.MM_STANDALONE]
>>
>> MemLib|StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMm
>> MemLib.inf
>>
>>   [LibraryClasses.ARM, LibraryClasses.AARCH64]
>> -  ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf
>> -  ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
>>     LockBoxLib|MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf
>>
>>     #
>> diff --git a/MdeModulePkg/MdeModulePkg.ci.yaml
>> b/MdeModulePkg/MdeModulePkg.ci.yaml
>> index 669f54e33c0d..a3de60a12c9e 100644
>> --- a/MdeModulePkg/MdeModulePkg.ci.yaml
>> +++ b/MdeModulePkg/MdeModulePkg.ci.yaml
>> @@ -53,8 +53,7 @@
>>           "AcceptableDependencies": [
>>               "MdePkg/MdePkg.dec",
>>               "MdeModulePkg/MdeModulePkg.dec",
>> -            "StandaloneMmPkg/StandaloneMmPkg.dec",
>> -            "ArmPkg/ArmPkg.dec"  # this should be fixed by promoting
>> an abstraction
>> +            "StandaloneMmPkg/StandaloneMmPkg.dec"
>>           ],
>>           # For host based unit tests
>>           "AcceptableDependencies-HOST_APPLICATION":[
>> --
>> 2.40.1
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116758): https://edk2.groups.io/g/devel/message/116758
Mute This Topic: https://groups.io/mt/104927624/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-